Bianca Nenciu
60196cc192
FIX: Hide bootbox after a negative answer ( #10028 )
...
Starting to reply and then editing a post was not possible because of a
bootbox which kept showing up.
2020-06-12 13:48:45 +02:00
Penar Musaraj
f57ecf22e0
UX: Send background color to iPad app too
...
Previously, we were only updating mobile devices.
2020-06-11 23:20:25 -04:00
Guo Xiang Tan
62ad473716
FIX: Preload readonly mode attribute seperately.
...
There are two problems I'm trying to tackle here.
1. The site json is cached for anonymous users so readonly mode can be
cached for up to 30 minutes which makes it confusing.
2. We've already checked for readonly mode in the controller so having
to check for readonly mode again in `SiteSerializer` is adding an extra
Redis query on every request.
2020-06-12 09:54:05 +08:00
Bianca Nenciu
dd85d44dda
FIX: Show tag count for existing tags ( #9892 )
...
* FIX: Show tag count for existing tags
* Add test
2020-06-11 14:13:48 +03:00
Sam Saffron
a26b490047
FIX: present correct new/unread counts when filtered by tag
...
Previously we would incorrectly ignore tags.
This ensures tracking state is properly shipped to client if
show_filter_by_tag is enabled.
2020-06-11 16:47:57 +10:00
Mark VanLandingham
b8acb36532
DEV: Plugin outlet at top of user preference interface ( #10020 )
2020-06-10 13:36:50 -05:00
Dan Ungureanu
5bfe1ee4f1
FEATURE: Improve UX support for multiple email addresses ( #9691 )
2020-06-10 19:11:49 +03:00
Dan Ungureanu
3a7ca97c36
FIX: Use include-subcategories filter in report export ( #10007 )
...
Some filters were renamed and the conversion of the filter names and arguments
was removed.
2020-06-10 18:57:39 +03:00
Joffrey JAFFEUX
8fe074430b
REVERT: partly revert change to ensure context is the same ( #10012 )
2020-06-10 11:10:39 +02:00
David Taylor
9e98c02dd7
FIX: Don't call cooked decorators in composer if cooked is unchanged
...
If cooked is unchanged, ember will not re-render the preview area, so we should not re-run the post-processing decorators. This can cause issues when decorateCooked functions are not idempotent.
2020-06-09 23:01:07 +01:00
Vinoth Kannan
f67e7d2fad
FIX: add attributes of params to topic findOpts.
...
If `params` is ignored then `findTopicList` won't get the `no_subcategories` attribute.
d27b877a40
2020-06-10 01:33:58 +05:30
Joffrey JAFFEUX
43e17f92e0
DEV: allows to call a widget function without re-rendering the widget ( #10004 )
2020-06-09 19:58:17 +02:00
Joffrey JAFFEUX
84d767716f
linting ( #10008 )
2020-06-09 19:54:06 +02:00
Joffrey JAFFEUX
a3cf1cf6ff
DEV: allows to prepend widgets to post nav controls ( #10005 )
...
Co-authored-by: Régis Hanol <regis@hanol.fr>
2020-06-09 19:37:06 +02:00
Joffrey JAFFEUX
23ed16339f
DEV: adds mouse{Over,Out} and touch{Start,End} to widgets ( #10003 )
2020-06-09 19:36:28 +02:00
Joe
415c1bb9e1
FIX: don't show create topic suggestion to users who can't
...
Users with TL below the "min trust to create topic" setting used to see a prompt to create new topics in the footer message below the topic list. Those topics would never be submitted because those users don't meet the TL requirements to create a new topic (based on that site setting). This PR removes that prompt for those users.
2020-06-10 00:02:11 +08:00
Arpit Jalan
3094459cd9
FEATURE: multiple use invite links ( #9813 )
2020-06-09 20:49:32 +05:30
David Taylor
f1fc6cd40d
DEV: Add user-card-additional-buttons plugin outlet
...
The user-card-additional-controls outlet is outside the `<li>` element, which makes styling difficult. Placing an outlet inside the button list means that themes/plugins can easily reuse core styling.
2020-06-09 14:33:24 +01:00
Sam Saffron
08044b4f94
FIX: emoji autocomplete triggering incorrectly
...
Previous to this fix the we were checking for non letters.
This was mismatching what pretty-text/addon/emoji.js was doing.
`ù:su`
and
`1:su`
Would lead to an emoji autocomplete popup in the composer.
2020-06-09 17:22:51 +10:00
Martin Brennan
3e210b76d9
FIX: Change bookmark name "name" attr to disable autocomplete
2020-06-09 14:47:30 +10:00
Kris
d09bf892c7
UX: Improve layout of topic pin admin modal
2020-06-08 23:58:53 -04:00
Penar Musaraj
c5b1f028ed
FIX: update minimum required tag when switching categories in composer
2020-06-08 17:10:26 -04:00
Penar Musaraj
bdba17cdf7
FIX: Restore stream position in safari ( #9993 )
...
Safari uses an aggressive back/forward cache, which means the app loads
very quickly when hitting Back. But, in topics with > 30 posts, hitting
Back runs post stream calculations too early, which means that users
get taken back to an earlier point in the stream, consistently.
Using `onpageshow`, we can restore the correct location before the post
stream calculations take place.
2020-06-08 10:13:46 -04:00
Joffrey JAFFEUX
cb13152a43
FIX: ensures edit-category-setting is correctly casting boolean ( #9999 )
2020-06-08 15:16:42 +02:00
David Taylor
833b5d89e0
PERF: Cache PrettyText instance for rendering composer preview ( #9987 )
...
Previously we were building pretty-text from scratch on every keypress
2020-06-08 10:42:59 +01:00
David Taylor
293467a37a
REFACTOR: Remove jquery usage from resolveAllShortUrls, and fix debounce
...
- This function now requires an explicit scope. It will never run on the entire document.
- Previously debounce was being used with an anonymous function, which means it was having no effect.
2020-06-05 17:15:14 +01:00
David Taylor
0f09fd22f3
DEV: Remove attachment css handling from resolveAllShortUrls
...
This was moved inside the markdown processor in 65481858
2020-06-05 15:12:30 +01:00
Robin Ward
a9def011d0
FIX: (getURL "") was not working with the i18n helper
2020-06-05 09:53:43 -04:00
David Taylor
be5974734d
PERF: Pass element to resolveAllShortUrl function, not text selector ( #9988 )
...
We already have a reference to the preview element, so there is no need to look it up again. This saves about 1ms per keypress in my testing.
2020-06-05 13:37:07 +01:00
David Taylor
731263b81c
PERF: Correctly memoize baseUri value in javascript app ( #9986 )
...
An empty string is a falsey value in javascript, so we were looking for the meta tag every time getURL was called, which took approximately 1.5ms every time.
2020-06-05 13:36:48 +01:00
Rafael dos Santos Silva
f00e5515e4
FIX: Service Worker URL was broken
...
Behavior was changed in #9966 , which made the URL be relative.
If the user landed in a topic, for example, the browser was given a
service worker URL under that specific topic URL, which was a 404.
Fixes broken PWA install and broken push notifications
2020-06-04 14:49:39 -03:00
Joffrey JAFFEUX
a23d31e4d6
DEV: removes unecessary casting ( #9982 )
2020-06-04 19:07:34 +02:00
Penar Musaraj
2d880b42a3
UX: Add simple-list setting type ( #9970 )
2020-06-04 10:44:54 -04:00
Arpit Jalan
40dfac176f
FIX: client side /my/ redirects were appending extra slash
2020-06-04 17:32:34 +05:30
Mark VanLandingham
c200238bdc
DEV: Reorder appending extra header icons ( #9973 )
2020-06-03 14:28:02 -05:00
Vinoth Kannan
3e7f7fdde8
FEATURE: category setting for default list filter. ( #9975 )
2020-06-04 00:56:56 +05:30
Robin Ward
ba00cc8ec4
DEV: Move Discourse.getURL and related functions to a module ( #9966 )
...
* DEV: Move `Discourse.getURL` and related functions to a module
* DEV: Remove `Discourse.getURL` and `Discourse.getURLWithCDN`
* FIX: `get-url` is required for server side code
* DEV: Deprecate `BaseUri` too.
2020-06-03 12:45:26 -04:00
Joffrey JAFFEUX
d27b877a40
FIX: prevents false boolean param to be filtered as non existant ( #9968 )
...
* FIX: prevents false boolean param to be filtered as non existant
This was preventing to filter top category route to be filtered by replies.
* if order is different ascending should be true on first click
* test
* fix
* just pass params
* more fixxes
2020-06-03 10:19:53 -06:00
Sam Saffron
10e321a96f
Revert "DEV: makes autocomplete debounced ( #9941 )"
...
This reverts commit f9e715672b
2020-06-03 08:40:21 +10:00
Kris
9e9ff01e86
Add missing text back in
2020-06-02 16:39:18 -04:00
Gerhard Schlager
0cf297725f
DEV: Use consistent interpolation key format in translations
...
From now on client strings can easily be reused on the server and you don’t have to think about choosing the right format anymore.
2020-06-02 19:05:10 +02:00
Mark VanLandingham
b3c8d36412
DEV: Plugin api for adding extra header icons ( #9964 )
2020-06-02 11:39:12 -05:00
Bianca Nenciu
d76ea9fa6b
FIX: Do not destroy $.fileupload element ( #9888 )
...
conditional-loading-section component rerendered the <input> element
and lost the necessary event handlers for jQuery-File-Upload.
2020-06-02 16:14:41 +10:00
Dan Ungureanu
ef3e3077d0
FIX: Staff users can bypass tag validation rule ( #9924 )
2020-06-02 16:11:25 +10:00
Joffrey JAFFEUX
f9e715672b
DEV: makes autocomplete debounced ( #9941 )
...
* DEV: makes autocomplete debounced
* better wording
2020-06-02 15:20:14 +10:00
Sam Saffron
7e52106812
DEV: when synchornizing state pull tags
...
In some cases we may want topic tracking state to keep track of tags
this small change ensures we do not remove them if they are already in place
2020-06-02 11:42:00 +10:00
Robin Ward
a95826f60c
Remove discourse constants ( #9958 )
...
* DEV: `Discourse.baseUri` does not exist
This never could have worked - should have been `Discourse.BaseUri` if
anything.
* DEV: Remove Discourse.Environment
* DEV: Remove `Discourse.disableMissingIconWarning`
* DEV: A bunch more missing environment checks
2020-06-01 16:33:43 -04:00
Kane York
9162cd8f3d
FIX: Only render group card if user title is from group ( #9946 )
...
This was failing when a user with a primary_group chose to display a title coming from a badge.
2020-06-01 11:44:41 -07:00
Mark VanLandingham
b6709f0dda
DEV: Add option to only show icons to header widget ( #9935 )
2020-06-01 12:26:59 -05:00
tshenry
0d6b638dac
FEATURE: New plugin outlet under badges page title ( #9936 )
2020-06-01 08:55:51 -07:00
Penar Musaraj
c2abf88a61
UX: Adjustments to topic admin menu on mobile ( #9945 )
2020-06-01 09:39:38 -04:00
Joffrey JAFFEUX
57e587f39f
DEV: removes dead code of dropdown-menu ( #9942 )
2020-06-01 11:22:35 +02:00
Joffrey JAFFEUX
40c4a8e3fc
DEV: skips/tweaks brittle tests ( #9952 )
2020-06-01 11:09:34 +02:00
Sam Saffron
82de9c5308
DEV: add countTags to topic tracking state
...
This introduces a new core API to get counts per tag from topic
tracking state
This API will only be useful if a plugin enable tags in topic
tracking state using
`TopicTrackingState.include_tags_in_report = true`
2020-06-01 17:05:24 +10:00
Jarek Radosz
754a255ef7
UX: Remove the period after "Enable Notifications" button
2020-06-01 05:50:49 +02:00
Penar Musaraj
f2647f1f36
UX: Position topic admin menu next to wrench ( #9932 )
2020-05-30 15:32:57 -04:00
Vinoth Kannan
e1af91f5ae
Revert "FEATURE: category setting for default list filter."
...
This reverts commit 6f03d14c23
2020-05-30 20:53:53 +05:30
Joe
7a76f3c295
UX: Relocate before-topic-list outlet so it shows up on Top as well
2020-05-30 03:31:28 +08:00
Joe
8e6d95a309
DEV: adds a few plugin outlets required for themes ( #9929 )
2020-05-30 03:04:12 +08:00
Joffrey JAFFEUX
931bfca454
DEV: allows categories-admin-dropdown to have custom items ( #9931 )
...
Usage:
```
modifySelectKit("categories-admin-dropdown").appendContent(function() {
return {
id: "foo",
name: I18n.t("foo"),
description: I18n.t("foo_description"),
icon: "gear",
onChange: () => alert("Foo.")
};
});
```
2020-05-29 21:01:19 +02:00
Robin Ward
2b2434b82d
Start Discourse in an initializer ( #9930 )
...
* DEV: To be pedantic, there is more than EMBER in there now
* DEV: Use less globals. Have `Discourse` start in an initializer
* DEV: Remove another global
2020-05-29 14:37:02 -04:00
Robin Ward
3fe5eacd1b
DEV: Abstract Ember.testing so our application code doesn't use it
2020-05-29 12:16:58 -04:00
Robin Ward
e5cd331fb3
DEV: Why use a whole object when a functionw will do?
2020-05-29 11:56:45 -04:00
Joffrey JAFFEUX
31d1468922
UX: reworks various menus to homogenize them ( #9905 )
...
- bookmark modal menu
- topic-footer-mobile-dropdown
- post-admin-menu
- topic-admin-menu
- quick-access menus
- toolbar-popup-menu
2020-05-29 08:05:21 +02:00
Vinoth Kannan
ef5320dd47
FIX: don't rerender whole users page while typing on input.
2020-05-29 09:06:26 +05:30
Vinoth Kannan
ce1491e830
UX: remove in:unpinned filter from advanced search page. ( #9911 )
2020-05-29 00:47:28 +05:30
Penar Musaraj
a98182debf
UX: Fix activity column display in wizard homepage step
...
Followup to f8f281cdad
2020-05-28 11:24:24 -04:00
Robin Ward
2033c3ec9c
Revert "Revert "DEV: Import MessageBus from message-bus-client instead of globals""
...
This reverts commit b10e995d9d
2020-05-28 08:42:36 -04:00
Joffrey JAFFEUX
0854785175
FIX: allows to define label/title properties for display instead of name
...
Usage:
```
const content = [{foo: "FOO", bar: "BAR", value: 1, name: "foo-bar"}];
{{combo-box
content=content
value=value
labelProperty="foo"
titleProperty="bar"
}}
```
2020-05-28 08:30:31 +02:00
Sam Saffron
ecc8e559ec
UX: remove edit PM button
...
Edit PM button leads to confusion and is uneeded
2020-05-28 15:15:27 +10:00
Sam Saffron
9841569bba
Revert "DEV: Fix a deprecated ember import ( #9903 )"
...
This reverts commit 75f46ca632
2020-05-28 10:06:05 +10:00
Blake Erickson
b10e995d9d
Revert "DEV: Import MessageBus from message-bus-client instead of globals"
...
This reverts commit 9dddbcc00d
2020-05-27 16:14:09 -06:00
Jarek Radosz
75f46ca632
DEV: Fix a deprecated ember import ( #9903 )
...
See the following for `Ember.testing` and `@ember/debug isTesting`:
* 8cf29959f7/packages/ember/index.js (L372-L376)8cf29959f7/packages/%40ember/debug/lib/testing.ts
2020-05-27 22:47:46 +02:00
Robin Ward
9dddbcc00d
DEV: Import MessageBus from message-bus-client instead of globals
2020-05-27 16:42:42 -04:00
Robin Ward
0f71d38d3a
Revert "DEV: Import MessageBus from message-bus-client instead of globals ( #9902 )"
...
This reverts commit d3bd482142
2020-05-27 16:34:30 -04:00
Robin Ward
d3bd482142
DEV: Import MessageBus from message-bus-client instead of globals ( #9902 )
2020-05-27 15:56:46 -04:00
Joffrey JAFFEUX
77801aa9be
FIX: allows to have custom emoji translation without static file ( #9893 )
2020-05-27 20:11:52 +02:00
Roman Rizzi
207b72ade1
UX: Don't show the suspension date if the user is permantently suspended. ( #9895 )
...
Use the same pattern used in user.hbs
2020-05-27 14:50:17 -03:00
Penar Musaraj
7bc496070f
UX: Keep focus on input after selecting an autocomplete option
...
This is particularly helpful on mobile, now tapping on an item from
the autocomplete dropdown keeps the keyboard visible.
2020-05-27 12:45:03 -04:00
Arpit Jalan
68fdfd76f5
fix the build
2020-05-27 22:06:45 +05:30
Arpit Jalan
8d2908dd9e
UX: do not show redundant user count
...
UX: add spacing between +member_count and "more"
2020-05-27 21:53:59 +05:30
Roman Rizzi
461df7d050
UX: Rename Priority to score for sorting. ( #9846 )
2020-05-27 12:50:28 -03:00
Joffrey JAFFEUX
f51093dde7
FIX: correctly set values and defaults for group-form-interaction-fields ( #9891 )
2020-05-27 12:10:27 +02:00
Sam Saffron
1cf2d1f9f2
FIX: when destroying a draft always ensure saving is done
...
There was a race condition where drafts could be either saving
or queued to be saved and a user canceled draft leading to destroying
it.
This cancels debounce save and waits for save in the pipeline to
be over prior to firing off a DELETE on the draft
2020-05-27 18:46:19 +10:00
Sam Saffron
f41fcad6c3
FIX: opening cancel draft dialog broke autosave
...
cancelComposer would leak a promise that never got resolved if
you aborted cancelling a composer.
This change ensured the promise will always be resolved
2020-05-27 18:16:48 +10:00
Penar Musaraj
b1c726be0d
Remove support for FontAwesome 4.7 icon names ( #9871 )
2020-05-26 14:53:32 -04:00
Mark VanLandingham
7820686f73
FIX: Wizard previews if color step is excluded ( #9881 )
2020-05-26 12:56:36 -05:00
Joffrey JAFFEUX
675e9b81c6
FIX: document.activeElement can be null on IE11 ( #9880 )
2020-05-26 16:51:55 +02:00
Joffrey JAFFEUX
253a185769
FIX: makes focust text area after complete more resilient ( #9879 )
2020-05-26 16:27:02 +02:00
Joffrey JAFFEUX
d9f915b195
FIX: documentation was using incorrect function ( #9876 )
2020-05-25 21:55:30 +02:00
Joffrey JAFFEUX
be16205118
DEV: plugin api should have been bumped for #8825395 ( #9874 )
2020-05-25 21:44:15 +02:00
Joffrey JAFFEUX
8825395bdc
DEV: allows to decorate username selector ( #9869 )
...
Usage:
```
api.addUsernameSelectorDecorator(username => {
return iconHTML("calendar-alt");
});
```
2020-05-25 19:09:55 +02:00
Gerhard Schlager
631024ae5d
FEATURE: Permalinks for tags
2020-05-25 14:51:01 +02:00
Sam Saffron
48fb354bce
PERF: avoid traversing DOM in loadScript
...
Once a script is loaded operation should be very fast.
This optimisation avoids a DOM traverse and call to getURL on
every invocation.
2020-05-25 18:19:59 +10:00
Vinoth Kannan
47c6fe9bfa
Merge branch 'master' of github.com:discourse/discourse
2020-05-25 11:36:18 +05:30
Bianca Nenciu
e31adef32d
FIX: Keep composer title and reply when switching to PM ( #9851 )
2020-05-25 15:46:02 +10:00
Vinoth Kannan
8e56197728
UX: use "icon-picker" & "image-uploader" fields to set group flair. ( #9779 )
2020-05-25 11:08:47 +05:30
Vinoth Kannan
6f03d14c23
FEATURE: category setting for default list filter.
2020-05-25 00:04:06 +05:30
Vinoth Kannan
058bf56b4c
FIX: group card not showing if user can't see its members.
2020-05-24 23:08:51 +05:30
Vinoth Kannan
60a3110113
FIX: call getURL method explicitly to prevent this context override.
2020-05-24 21:58:03 +05:30
