Penar Musaraj
c2abf88a61
UX: Adjustments to topic admin menu on mobile ( #9945 )
2020-06-01 09:39:38 -04:00
Joffrey JAFFEUX
57e587f39f
DEV: removes dead code of dropdown-menu ( #9942 )
2020-06-01 11:22:35 +02:00
Joffrey JAFFEUX
40c4a8e3fc
DEV: skips/tweaks brittle tests ( #9952 )
2020-06-01 11:09:34 +02:00
Sam Saffron
82de9c5308
DEV: add countTags to topic tracking state
...
This introduces a new core API to get counts per tag from topic
tracking state
This API will only be useful if a plugin enable tags in topic
tracking state using
`TopicTrackingState.include_tags_in_report = true`
2020-06-01 17:05:24 +10:00
Jarek Radosz
754a255ef7
UX: Remove the period after "Enable Notifications" button
2020-06-01 05:50:49 +02:00
Penar Musaraj
f2647f1f36
UX: Position topic admin menu next to wrench ( #9932 )
2020-05-30 15:32:57 -04:00
Vinoth Kannan
e1af91f5ae
Revert "FEATURE: category setting for default list filter."
...
This reverts commit 6f03d14c23
.
2020-05-30 20:53:53 +05:30
Joe
7a76f3c295
UX: Relocate before-topic-list outlet so it shows up on Top as well
2020-05-30 03:31:28 +08:00
Joe
8e6d95a309
DEV: adds a few plugin outlets required for themes ( #9929 )
2020-05-30 03:04:12 +08:00
Joffrey JAFFEUX
931bfca454
DEV: allows categories-admin-dropdown to have custom items ( #9931 )
...
Usage:
```
modifySelectKit("categories-admin-dropdown").appendContent(function() {
return {
id: "foo",
name: I18n.t("foo"),
description: I18n.t("foo_description"),
icon: "gear",
onChange: () => alert("Foo.")
};
});
```
2020-05-29 21:01:19 +02:00
Robin Ward
2b2434b82d
Start Discourse in an initializer ( #9930 )
...
* DEV: To be pedantic, there is more than EMBER in there now
* DEV: Use less globals. Have `Discourse` start in an initializer
* DEV: Remove another global
2020-05-29 14:37:02 -04:00
Robin Ward
3fe5eacd1b
DEV: Abstract Ember.testing
so our application code doesn't use it
2020-05-29 12:16:58 -04:00
Robin Ward
e5cd331fb3
DEV: Why use a whole object when a functionw will do?
2020-05-29 11:56:45 -04:00
Joffrey JAFFEUX
31d1468922
UX: reworks various menus to homogenize them ( #9905 )
...
- bookmark modal menu
- topic-footer-mobile-dropdown
- post-admin-menu
- topic-admin-menu
- quick-access menus
- toolbar-popup-menu
2020-05-29 08:05:21 +02:00
Vinoth Kannan
ef5320dd47
FIX: don't rerender whole users page while typing on input.
2020-05-29 09:06:26 +05:30
Vinoth Kannan
ce1491e830
UX: remove in:unpinned
filter from advanced search page. ( #9911 )
2020-05-29 00:47:28 +05:30
Penar Musaraj
a98182debf
UX: Fix activity column display in wizard homepage step
...
Followup to f8f281cdad
, thanks @jjafeux
2020-05-28 11:24:24 -04:00
Robin Ward
2033c3ec9c
Revert "Revert "DEV: Import MessageBus
from message-bus-client
instead of globals""
...
This reverts commit b10e995d9d
.
2020-05-28 08:42:36 -04:00
Joffrey JAFFEUX
0854785175
FIX: allows to define label/title properties for display instead of name
...
Usage:
```
const content = [{foo: "FOO", bar: "BAR", value: 1, name: "foo-bar"}];
{{combo-box
content=content
value=value
labelProperty="foo"
titleProperty="bar"
}}
```
2020-05-28 08:30:31 +02:00
Sam Saffron
ecc8e559ec
UX: remove edit PM button
...
Edit PM button leads to confusion and is uneeded
2020-05-28 15:15:27 +10:00
Sam Saffron
9841569bba
Revert "DEV: Fix a deprecated ember
import ( #9903 )"
...
This reverts commit 75f46ca632
.
This unfortunately breaks
`RAILS_ENV=production bin/rake assets:precompile`
I don't think discourse-loader.js is transpiled
2020-05-28 10:06:05 +10:00
Blake Erickson
b10e995d9d
Revert "DEV: Import MessageBus
from message-bus-client
instead of globals"
...
This reverts commit 9dddbcc00d
.
2020-05-27 16:14:09 -06:00
Jarek Radosz
75f46ca632
DEV: Fix a deprecated ember
import ( #9903 )
...
See the following for `Ember.testing` and `@ember/debug isTesting`:
* 8cf29959f7/packages/ember/index.js (L372-L376)
* 8cf29959f7/packages/%40ember/debug/lib/testing.ts
2020-05-27 22:47:46 +02:00
Robin Ward
9dddbcc00d
DEV: Import MessageBus
from message-bus-client
instead of globals
2020-05-27 16:42:42 -04:00
Robin Ward
0f71d38d3a
Revert "DEV: Import MessageBus
from message-bus-client
instead of globals ( #9902 )"
...
This reverts commit d3bd482142
.
2020-05-27 16:34:30 -04:00
Robin Ward
d3bd482142
DEV: Import MessageBus
from message-bus-client
instead of globals ( #9902 )
2020-05-27 15:56:46 -04:00
Joffrey JAFFEUX
77801aa9be
FIX: allows to have custom emoji translation without static file ( #9893 )
2020-05-27 20:11:52 +02:00
Roman Rizzi
207b72ade1
UX: Don't show the suspension date if the user is permantently suspended. ( #9895 )
...
Use the same pattern used in user.hbs
2020-05-27 14:50:17 -03:00
Penar Musaraj
7bc496070f
UX: Keep focus on input after selecting an autocomplete option
...
This is particularly helpful on mobile, now tapping on an item from
the autocomplete dropdown keeps the keyboard visible.
2020-05-27 12:45:03 -04:00
Arpit Jalan
68fdfd76f5
fix the build
2020-05-27 22:06:45 +05:30
Arpit Jalan
8d2908dd9e
UX: do not show redundant user count
...
UX: add spacing between +member_count and "more"
2020-05-27 21:53:59 +05:30
Roman Rizzi
461df7d050
UX: Rename Priority to score for sorting. ( #9846 )
2020-05-27 12:50:28 -03:00
Joffrey JAFFEUX
f51093dde7
FIX: correctly set values and defaults for group-form-interaction-fields ( #9891 )
2020-05-27 12:10:27 +02:00
Sam Saffron
1cf2d1f9f2
FIX: when destroying a draft always ensure saving is done
...
There was a race condition where drafts could be either saving
or queued to be saved and a user canceled draft leading to destroying
it.
This cancels debounce save and waits for save in the pipeline to
be over prior to firing off a DELETE on the draft
2020-05-27 18:46:19 +10:00
Sam Saffron
f41fcad6c3
FIX: opening cancel draft dialog broke autosave
...
cancelComposer would leak a promise that never got resolved if
you aborted cancelling a composer.
This change ensured the promise will always be resolved
2020-05-27 18:16:48 +10:00
Penar Musaraj
b1c726be0d
Remove support for FontAwesome 4.7 icon names ( #9871 )
2020-05-26 14:53:32 -04:00
Mark VanLandingham
7820686f73
FIX: Wizard previews if color step is excluded ( #9881 )
2020-05-26 12:56:36 -05:00
Joffrey JAFFEUX
675e9b81c6
FIX: document.activeElement can be null on IE11 ( #9880 )
2020-05-26 16:51:55 +02:00
Joffrey JAFFEUX
253a185769
FIX: makes focust text area after complete more resilient ( #9879 )
2020-05-26 16:27:02 +02:00
Joffrey JAFFEUX
d9f915b195
FIX: documentation was using incorrect function ( #9876 )
2020-05-25 21:55:30 +02:00
Joffrey JAFFEUX
be16205118
DEV: plugin api should have been bumped for #8825395 ( #9874 )
2020-05-25 21:44:15 +02:00
Joffrey JAFFEUX
8825395bdc
DEV: allows to decorate username selector ( #9869 )
...
Usage:
```
api.addUsernameSelectorDecorator(username => {
return iconHTML("calendar-alt");
});
```
2020-05-25 19:09:55 +02:00
Gerhard Schlager
631024ae5d
FEATURE: Permalinks for tags
2020-05-25 14:51:01 +02:00
Sam Saffron
48fb354bce
PERF: avoid traversing DOM in loadScript
...
Once a script is loaded operation should be very fast.
This optimisation avoids a DOM traverse and call to getURL on
every invocation.
2020-05-25 18:19:59 +10:00
Vinoth Kannan
47c6fe9bfa
Merge branch 'master' of github.com:discourse/discourse
2020-05-25 11:36:18 +05:30
Bianca Nenciu
e31adef32d
FIX: Keep composer title and reply when switching to PM ( #9851 )
2020-05-25 15:46:02 +10:00
Vinoth Kannan
8e56197728
UX: use "icon-picker" & "image-uploader" fields to set group flair. ( #9779 )
2020-05-25 11:08:47 +05:30
Vinoth Kannan
6f03d14c23
FEATURE: category setting for default list filter.
2020-05-25 00:04:06 +05:30
Vinoth Kannan
058bf56b4c
FIX: group card not showing if user can't see its members.
2020-05-24 23:08:51 +05:30
Vinoth Kannan
60a3110113
FIX: call getURL
method explicitly to prevent this
context override.
2020-05-24 21:58:03 +05:30
Michael Brown
d9a02d1336
Revert "Revert "Merge branch 'master' of https://github.com/discourse/discourse ""
...
This reverts commit 20780a1eee
.
* SECURITY: re-adds accidentally reverted commit:
03d26cd6: ensure embed_url contains valid http(s) uri
* when the merge commit e62a85cf
was reverted, git chose the 2660c2e2
parent to land on
instead of the 03d26cd6
parent (which contains security fixes)
2020-05-23 00:56:13 -04:00
Jeff Atwood
20780a1eee
Revert "Merge branch 'master' of https://github.com/discourse/discourse "
...
This reverts commit e62a85cf6f
, reversing
changes made to 2660c2e21d
.
2020-05-22 20:25:56 -07:00
Mark VanLandingham
f9649c92b5
FIX: Live reloading of css in development ( #9859 )
2020-05-22 16:37:35 +02:00
Neil Lalonde
5a71c51ddd
FIX: tag input says tags are optional when they're required
2020-05-21 12:40:33 -04:00
Mark VanLandingham
1a5bcf2a64
UX: Remove live theme previewing in favor of refresh ( #9798 )
2020-05-21 08:32:50 -05:00
Joffrey JAFFEUX
66960563ea
FIX: ensures category chooser is case insensitive ( #9850 )
2020-05-21 11:16:44 +02:00
Arpit Jalan
18959ff9da
UX: user name instead username for profile link title
2020-05-21 14:02:12 +05:30
Arpit Jalan
3c9212fd88
UX: add title for user profile link
2020-05-21 13:00:05 +05:30
Roman Rizzi
234933c781
FIX: Show staff counters if the rejected posts count is the only value to show ( #9845 )
2020-05-20 19:00:35 -03:00
Robin Ward
ba04bb7552
FIX: Path should be addon
not app
2020-05-20 12:13:15 -04:00
Robin Ward
3062036f2f
FIX: Allow deprecation to work with Ember CLI
2020-05-20 12:05:56 -04:00
Robin Ward
09ca75d17e
FIX: select-kit was in the wrong place
...
`app/` means we want to merge it into our application there. `addon`
means give it its own module namespace, which is what we wanted.
2020-05-20 11:51:49 -04:00
Robin Ward
6c9c8dfefd
FIX: guidFor
is not part of Ember.Object
2020-05-20 11:31:11 -04:00
Mark VanLandingham
bd57ae83f1
DEV: Guardian for hiding about stats ( #9841 )
2020-05-20 10:26:20 -05:00
Joffrey JAFFEUX
30631a963f
UX: moves editFirstPost in taggable Pms in dropdown on mobile ( #9840 )
2020-05-20 14:07:00 +02:00
Bianca Nenciu
fb15da43da
Remove old web hooks in favor of 'reviewable' web hook ( #9776 )
...
* FIX: Emit web hooks for flags
* FEATURE: Remove 'flag' web hook in favor of 'reviewable' web hook
* FEATURE: Remove 'queued post' web hook in favor of 'reviewable' web hook
* FIX: Do not set a default value for web hooks with no events
2020-05-20 12:07:48 +03:00
Sam Saffron
e97cb20c2a
UX: strip text from PM bookmark and share buttons
...
Also organize priorities in an easier to reason about way and
shift bookmark topic so it is after link. (consistent with posts)
2020-05-20 16:46:49 +10:00
Roman Rizzi
52228b1fa6
DEV: These routes don't exist anymore ( #9823 )
2020-05-19 16:09:03 -03:00
Joffrey JAFFEUX
05d8091bd3
DEV: adds triggerOnChangeOnTab option to select-kit ( #9833 )
...
Usage:
```
options=(hash triggerOnChangeOnTab=false)
```
This will prevent to select the row when pressing tab.
2020-05-19 20:39:29 +02:00
Joffrey JAFFEUX
ab6737c44a
UX: improves topic-notifications-button loading behavior ( #9832 )
2020-05-19 17:13:40 +02:00
Joffrey JAFFEUX
7c3663ff73
UX: adds visual feedback when changing topic notifications level ( #9831 )
2020-05-19 13:27:57 +02:00
Joffrey JAFFEUX
3623a395dc
UI: refinements to topic footer buttons ( #9780 )
2020-05-19 09:51:34 +02:00
Guo Xiang Tan
062cb1e1cb
UX: Remove caret from notifications-button.
2020-05-19 13:41:13 +08:00
Joffrey JAFFEUX
cfad38184d
FIX: improves and fixes a regression with category-selector ( #9821 )
2020-05-18 17:44:47 +02:00
Joffrey JAFFEUX
1876b3cc4c
FIX: more resilient/consistent date-picker loading ( #9817 )
2020-05-18 15:29:24 +02:00
Joffrey JAFFEUX
48ed1b40cf
REFACTOR: ensures later is correctly canceled ( #9796 )
2020-05-18 14:20:23 +02:00
Joffrey JAFFEUX
9482ddff73
UX: show caret only in topic footer buttons dropdown select boxes ( #9816 )
2020-05-18 14:07:40 +02:00
Joffrey JAFFEUX
320b21ab5b
UX: allows dropdown-select-box to display a caret ( #9803 )
...
```
selectKitOptions: {
showCaret: true // default false
}
```
2020-05-18 10:50:33 +02:00
Joffrey JAFFEUX
e5dc843185
FIX: ensures hide is called when card is destroyed ( #9814 )
2020-05-18 10:10:40 +02:00
Joffrey JAFFEUX
e81a4048e3
REFACTOR: s/focusAfterOnchange/focusAfterOnChange ( #9801 )
2020-05-16 11:20:37 +02:00
Robin Ward
db8e872bda
DEV: Move select kit to an addon ( #9797 )
2020-05-15 16:07:35 -04:00
Alan Guo Xiang Tan
7f07c513a7
FIX: Switching composer action does not refresh composer actions content ( #9791 )
2020-05-15 13:54:44 -04:00
Robin Ward
6b04760572
FIX: Component was still used by data explorer
2020-05-15 13:52:03 -04:00
Joffrey JAFFEUX
7edd312f85
UX: focus category name when editing category ( #9795 )
2020-05-15 18:27:06 +02:00
Joffrey JAFFEUX
b07f1bfd93
FIX: displays a title on sk header if no selected name ( #9794 )
...
none has to be defined.
2020-05-15 17:36:00 +02:00
Justin DiRose
9810ca1dbd
UX: Add copied text upon copy button click ( #9793 )
2020-05-15 17:08:46 +02:00
Guo Xiang Tan
d1146ccb7b
Revert "FIX: Correct plugin api version bump."
...
This reverts commit 6a96c424b7
.
False alarm. I was deploying on a docker image which was still on 0.9.0.
2020-05-15 21:22:44 +08:00
Guo Xiang Tan
6a96c424b7
FIX: Correct plugin api version bump.
...
It doesn't seem to be following semver.
2020-05-15 21:17:50 +08:00
Guo Xiang Tan
162d125b83
Fix lint.
2020-05-15 20:23:17 +08:00
Guo Xiang Tan
dada1fc417
UX: Better composer-action icon when creating new topic.
2020-05-15 16:40:49 +08:00
Guo Xiang Tan
f9a9bd136b
FEATURE: Expose Composer.serializeToTopic
in client side plugin api.
2020-05-15 16:16:58 +08:00
Blake Erickson
1a2b9435b0
DEV: Standardize table sorting verbiage ( #9757 )
...
* DEV: Standardize table sorting verbiage
This commit creates a common component that tables can use to make their
headers sortable. This commit also standardizes on using `desc` as the
default and passing in the `asc=true` flag to adjust the sorting
direction.
* Add deprecation warnings
Adds deprecation warnings if using previous params and maintains
backwards compatibility. Set the default sort value for group members to
be asc.
* switch group requests to use common table-header-toggle
* update fixture
2020-05-14 20:10:59 -06:00
Kane York
869f9b20a2
PERF: Dematerialize topic_reply_count ( #9769 )
...
* PERF: Dematerialize topic_reply_count
It's only ever used for trust level promotions that run daily, or compared to 0. We don't need to track it on every post creation.
* UX: Add symbol in TL3 report if topic reply count is capped
* DEV: Drop user_stats.topic_reply_count column
2020-05-14 15:42:00 -07:00
Kane York
e0e967ac46
FIX: Apply code quoting with no syntax highlighting ( #9784 )
2020-05-14 13:03:42 -07:00
Mark VanLandingham
bec6bace53
DEV: Allow plugins to hide user stats by new guardian method ( #9772 )
2020-05-14 11:57:35 -05:00
Robin Ward
aa2d040526
DEV: Update ESLint to remove I18n global
...
Also fixes missed imports in core.
2020-05-14 10:18:12 -04:00
Joffrey JAFFEUX
42e5a5bb39
DEV: do not append/prepend if callback returns nothing ( #9778 )
2020-05-14 14:38:03 +02:00
Guo Xiang Tan
9a18bacbe3
DEV: Fix lint.
2020-05-14 16:10:51 +08:00
Guo Xiang Tan
a1a798ac7d
DEV: Expose Composer.serializeOnUpdate
in client side plugin api.
...
Also expose `Composer.serializeOnCreate` as well.
2020-05-14 16:06:29 +08:00
Guo Xiang Tan
fdea969f14
DEV: Minor follow up to d7e230c1b9
2020-05-14 16:02:54 +08:00
Guo Xiang Tan
95a80525ae
DEV: Remove erroneous code introduced in d7e230c1b9
2020-05-14 15:58:44 +08:00
Guo Xiang Tan
d7e230c1b9
UX: Introduce composer-actions when editing a post.
2020-05-14 15:56:08 +08:00
Vinoth Kannan
c014b93854
UX: don't disable "create account" button & display error message for required fields. ( #9643 )
2020-05-14 12:15:33 +05:30
Sam Saffron
3d050bdaa3
DEV: correct test suite
...
We have no choice but to bypass recursive debouncers in test
Otherwise we overrun the stack with frames
2020-05-14 16:41:34 +10:00
Sam Saffron
ce4b5b56e5
FIX: never save draft while it is saving
...
Previously if saving a draft took longer than 2 seconds there
could be conditions where drafts could be saved concurrently.
This meant the composer could race with itself and raise conflicts.
This is likely to happen on bad internet connections or where
latency is really high.
Additionally a throttle was added so drafts save unconditionally
every 15 seconds.
Save draft in the model now properly and consistently returns a
promise.
2020-05-14 15:36:18 +10:00
Penar Musaraj
ad7c964cd1
FIX: Prevent Safari from scrolling when closing composer
...
Unlike other browsers, Safari maintains focus on elements even when
they are hidden. And since the composer is fixed-positioned when hidden,
closing the composer on a topic with several replies causes Safari to
scroll the window up.
Deliberately blurring the focused element fixes the issue.
2020-05-13 21:24:40 -04:00
Robin Ward
eab560fe2a
DEV: import I18n instead of global usage ( #9768 )
...
Co-authored-by: Mark VanLandingham <markvanlan@gmail.com>
Co-authored-by: Robin Ward <robin.ward@gmail.com>
Co-authored-by: Mark VanLandingham <markvanlan@gmail.com>
2020-05-13 16:23:41 -04:00
Mark VanLandingham
3d54f497db
DEV: add classes to li's inside user navigation ( #9766 )
2020-05-13 12:22:14 -05:00
Guo Xiang Tan
c405b15914
DEV: Add plugin outlet revision-user-details-after
.
2020-05-13 15:40:37 +08:00
Martin Brennan
a64cf265fd
FIX: Change /bookmarks URL back to topic list and add bookmark poster avatars ( #9759 )
...
* Changes the /bookmarks URL to show the original "topics filtered by bookmark" list instead of redirecting to user activity bookmarks (see https://meta.discourse.org/t/domain-com-bookmarks-is-showing-domain-com-u-user-activity-bookmarks-with-reminders/149252/12 )
* Add the user avatar for the user who made the post that is bookmarked
2020-05-13 14:03:24 +10:00
Guo Xiang Tan
822e594fc8
UX: Improve display of site setting validation message.
...
Previously, the validation message is shown inline with the label which
leads to the available width for both element being reduced.
2020-05-13 11:10:08 +08:00
Robin Ward
d9f5499f3a
Revert "Revert "DEV: Remove Discourse.Route
""
...
This reverts commit b4d27d327d
.
Plugins have been updated to not use this anymore.
2020-05-12 14:15:07 -04:00
Mark VanLandingham
9bce91f59f
DEV: Allow plugins to add extra icons to category-link ( #9743 )
2020-05-12 09:41:16 -05:00
Bianca Nenciu
16137308b0
FIX: Show Settings button if plugin has settings ( #9728 )
...
It used to check if the plugin has an enabled_setting.
2020-05-12 11:18:19 +03:00
Martin Brennan
39a2d90e0f
DEV: Pass currentUser to post-menu button builders ( #9752 )
...
Adding this from a review; I was using Discourse.currentUser which is frowned upon now.
Passing currentUser both for regular post menu buttons and extra buttons attached via the plugin API.
Lots of formatting/whitespace changes, best off reviewing with ?w=1
2020-05-12 14:09:38 +10:00
Kris
a009ec597d
remove ember container div
2020-05-11 21:12:33 -04:00
tshenry
6f228b0312
FIX: Remove unnecessary forward slashes in regex
2020-05-11 17:55:44 -07:00
Penar Musaraj
7cdf41d311
DEV: Remove reference to Discourse.Category
2020-05-11 18:28:45 -04:00
Jeff Wong
e744b9efec
FIX: add tabindex=-1 on tabLoc post links
...
This prevents tabbing from confusing screenreaders, as having default tabindex
with aria-hidden confuses screenreaders
2020-05-11 14:43:12 -07:00
Penar Musaraj
90b900704b
FIX: Improve mobile footer nav accessibility
2020-05-11 16:55:34 -04:00
Robin Ward
b4d27d327d
Revert "DEV: Remove Discourse.Route
"
...
This reverts commit eed7983404
.
2020-05-11 16:50:53 -04:00
Robin Ward
22af44ac49
DEV: Remove Discourse.Mobile
2020-05-11 16:13:29 -04:00
Robin Ward
eed7983404
DEV: Remove Discourse.Route
2020-05-11 16:11:33 -04:00
Robin Ward
74db317974
DEV: Remove deprecation for Discourse.Category
2020-05-11 16:10:21 -04:00
Joffrey JAFFEUX
286b4e535e
DEV: allows buttons to define aria-label ( #9747 )
2020-05-11 22:09:44 +02:00
Robin Ward
b4bd238dd6
DEV: Add safe deprecation to Discourse.User
2020-05-11 16:08:12 -04:00
Robin Ward
46730a2f0d
DEV: Allow us to keep the deprecation with Ember CLI
2020-05-11 16:06:06 -04:00
Robin Ward
4c17ff98fa
DEV: Remove deprecation for Discourse.Session
2020-05-11 15:51:10 -04:00
Robin Ward
8311374a5a
DEV: Replace version.js.erb
with pre generated file
2020-05-11 15:43:09 -04:00
Robin Ward
d2b16a7618
DEV: Generate emoji/data
on demand ( #9744 )
...
These emoji rarely change and can be re-generated when we make changes
to them.
2020-05-11 15:29:46 -04:00
Joffrey JAFFEUX
af6e61defd
FIX: sets a title for notifications button ( #9745 )
2020-05-11 20:46:08 +02:00
jjaffeux
5a073c6a0a
Revert "FIX: title should attempt to fallback to label before name ( #9739 )"
...
This reverts commit c6bf552ca3
.
2020-05-11 20:09:11 +02:00
jjaffeux
0deb05740f
Revert "DEV: allows to define an ariaLabel on d-button ( #9716 )"
...
This reverts commit 7a95dd4841
.
2020-05-11 19:19:13 +02:00
Joffrey JAFFEUX
7a95dd4841
DEV: allows to define an ariaLabel on d-button ( #9716 )
...
* DEV: allows to define an ariaLabel on d-button
This topic also adds this function to topic-footer-buttons, simplifies the whole logic of titile/label/arialabel in d-button and adds tests for these properties.
* typo
2020-05-11 18:42:51 +02:00
Joffrey JAFFEUX
c6bf552ca3
FIX: title should attempt to fallback to label before name ( #9739 )
2020-05-11 18:42:18 +02:00
Jarek Radosz
7d3c4a5f13
FIX: Show category name in badge preview on edit ( #9726 )
2020-05-11 17:05:40 +02:00
Jarek Radosz
a2bb33b6d7
REFACTOR: Remove an unused Topic model observer ( #9723 )
...
As far I can tell nothing sets categoryName on the Topic model. Didn't find anything in all-the-plugins/all-the-themes either.
2020-05-11 17:05:05 +02:00
Mark VanLandingham
89c6f697b8
DEV: Plugin outlet after save or cancel composer buttons ( #9725 )
2020-05-11 09:23:36 -05:00
Sam Saffron
77f5bb1419
FIX: stop clearing title by mistake
...
b180e6e737
caused a short lived regression.
This code is very deliberate about ensuring originalTitle is
set correctly
2020-05-11 19:07:32 +10:00
Guo Xiang Tan
a3a464b838
DEV: Improve description of addPosterIcon plugin api.
2020-05-11 16:44:47 +08:00
Sam Saffron
b180e6e737
FIX: default to blank title on open
...
In production `title` was set to undefined causing a
discrepancy between originalTitle and title
This attempts to work around the issue in the production bundle
2020-05-11 18:36:09 +10:00
Martin Brennan
29842e682b
FIX: Resolve issues with Next Monday for bookmarks not working in certain locales ( #9737 )
...
In moment.js the .day() function can accept a day string but this is locale based, so e.g. in Finnish locale the string "Monday" means nothing and will parse incorrectly to Sunday. To resolve this we always use the moment.js number for the day of the week we want.
2020-05-11 13:59:14 +10:00
Martin Brennan
12d4d51d81
FIX: CurrentUser now must be passed to resolveTimezone and user card local time issues ( #9734 )
...
* This is to prevent user's timezones being changed accidentally
e.g. by admin looking at a user
* This problem only occurred via the user card, however the user card
was still calling userTimezone even if the setting to display user
time in card was disabled
2020-05-11 11:01:47 +10:00
Sam Saffron
44712c5f98
FIX: ESC to dismiss empty draft topic composer
...
Previously originalTitle was set to undefined leading to
titleDirty being unconditionally undefined for new topics
That mean you could not dismiss the composer via ESC
2020-05-11 10:04:38 +10:00
Bianca Nenciu
8149bfbaf1
FEATURE: Filter settings by plugin ( #9692 )
2020-05-10 14:07:45 +03:00
Joffrey JAFFEUX
3b2b635e9b
DEV: removes setInterval as it might cause issues ( #9722 )
2020-05-10 08:57:48 +02:00
Joffrey JAFFEUX
862d153f54
REFACTOR: removes dead code ( #9721 )
2020-05-09 11:50:47 +02:00
Joffrey JAFFEUX
9bf11a8c68
DEV: allows select-kit to prevent autofocus of header after onChange ( #9718 )
2020-05-09 10:26:23 +02:00
Robin Ward
34e5f807ec
DEV: User UPPER_CASE for constants
2020-05-08 15:50:55 -04:00
Mark VanLandingham
da561a430d
DEV: Add data-name to popular-theme-item rows ( #9714 )
2020-05-08 14:38:41 -05:00