56950 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
dependabot[bot]	39198afa49	Build(deps): Bump timeout from 0.4.1 to 0.4.2 (#29625) ... Bumps [timeout](https://github.com/ruby/timeout) from 0.4.1 to 0.4.2. - [Release notes](https://github.com/ruby/timeout/releases) - [Commits](https://github.com/ruby/timeout/compare/v0.4.1...v0.4.2) --- updated-dependencies: - dependency-name: timeout dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-07 00:13:09 +01:00
dependabot[bot]	4205b06fcd	Build(deps): Bump json from 2.7.6 to 2.8.1 (#29624) ... Bumps [json](https://github.com/ruby/json) from 2.7.6 to 2.8.1. - [Release notes](https://github.com/ruby/json/releases) - [Changelog](https://github.com/ruby/json/blob/master/CHANGES.md) - [Commits](https://github.com/ruby/json/compare/v2.7.6...v2.8.1) --- updated-dependencies: - dependency-name: json dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-07 00:11:07 +01:00
dependabot[bot]	b8295b8b70	Build(deps-dev): Bump @swc/core from 1.8.0 to 1.9.1 (#29628) ... Bumps [@swc/core](https://github.com/swc-project/swc) from 1.8.0 to 1.9.1. - [Release notes](https://github.com/swc-project/swc/releases) - [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md) - [Commits](https://github.com/swc-project/swc/compare/v1.8.0...v1.9.1) --- updated-dependencies: - dependency-name: "@swc/core" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-07 00:06:08 +01:00
Kris	f24c274867	UX: replace broken link SVG with new Font Awesome 6 name (#29623)	2024-11-06 13:35:07 -05:00
Renato Atilio	ac33ecdc8c	FIX: pass topic+category to @-mention user search (#29620) ... When replying to a topic, the @-mention userSearch needs the topicId and the categoryId so they can trigger immediately, with sane suggestions. This was broken when the mentions were moved from ComposerEditor to DEditor.	2024-11-06 15:20:54 -03:00
Bianca Nenciu	635faaaf59	DEV: Add system spec for categories page (#29621) ... Follow up to commit 948e283e0f.	2024-11-06 20:01:27 +02:00
Bianca Nenciu	da43deb9ea	DEV: Fix mismatched column types (#29477) ... The primary key is usually a bigint column, but the foreign key columns are usually of integer type. This can lead to issues when joining these columns due to mismatched types and different value ranges. This was using a temporary plugin / test API to make tests pass. After more careful consideration, we concluded that it is safe to alter the tables directly. Even for larger communities, with about 1M chat messages, the slowest `ALTER` query runs in about 15 seconds, which well under the 30 seconds query timeout limit. As a result, chat messages will be delayed for a few seconds, but the system will remain operational.	2024-11-06 20:00:40 +02:00
Jean	708533b1e0	FEATURE: Add links to searchable user fields in users directory and user profile (#29338) ... * FEATURE: Add links to searchable user fields in users directory and user profile	2024-11-06 13:35:30 -04:00
Ella E.	13c7773036	UX: Make the emojis in the admin page table list work better on mobile (#29619) ... * UX: Apply admin table classes for consistent mobile styling on the emojis page * UX: remove icon from the button * UX: styling tweaks on the emoji uploader form * UX: right align table button controls * apply prettier	2024-11-06 10:25:03 -07:00
Loïc Guitaut	6158a1ae29	DEV: Refactor the Chat::CreateThread service a bit ... Follow best practices from our docs.	2024-11-06 15:53:43 +01:00
Gabriel Grubba	45ecb34aec	UX: update create_post_for_category_and_tag_changes to include that it needs whispers enabled to work (#29618) ... * UX: update `create_post_for_category_and_tag_changes` to include that it needs whispers enabled to work * DEV: update phrasing in `create_post_for_category_and_tag_changes`	2024-11-06 11:18:20 -03:00
David Taylor	0237ef80bd	DEV: Enable ember/no-classic-classes eslint rule (#28610)	2024-11-06 13:31:01 +00:00
Jarek Radosz	1ba6f6f1ae	DEV: Update content-tag to 2.0.3 (#29616)	2024-11-06 13:29:24 +01:00
Gabriel Grubba	75beb5a84f	FIX: Change create_post_for_category_and_tag_changes setting to use whispers instead of small actions (#29602) ... It currently can leak private tags/categories, to address this we are moving to whispers.	2024-11-06 09:28:28 -03:00
Loïc Guitaut	5177aef37d	FIX: Don’t try to serialize associations in PostRevisionSerializer ... Currently, if an association is added as a tracked field in `PostRevisor`, the `PostRevisionSerializer` class will try to serialize it somehow. This will raise an error as ActiveRecord collection proxies can't be serialized. This patch addresses this issue by skipping any association tracked by the `PostRevisor` class.	2024-11-06 10:38:41 +01:00
Ted Johansson	3be925e161	DEV: Untangle award badge admin CSS (#29614) ... I was skimming through existing pages to get a feel for the admin UI guidelines. I noticed that this part was missing its margin. On some further investigation, it seems that a single CSS selector, .award-badge was being used both for the section and for the button in the header, so I decided to 1) separate the two and 2) add in the missing margin.	2024-11-06 16:10:39 +08:00
chapoi	a097d86eea	UX: fix visibility of grant badge modal dropdowns (#29613)	2024-11-06 07:30:13 +01:00
Krzysztof Kotlarek	d57b7abe67	FIX: setup with db:create db:migrate (#29609) ... After data seed, we should reset Redis cache to ensure that the correct flags are cached. However, `db:create` is skipping Redis https://github.com/discourse/discourse/blob/main/lib/tasks/db.rake#L39 And uses `ActiveSupport::Cache::MemoryStore.new` e2292d4c59/lib/discourse.rb (L523) Therefore, the reset flags cache was moved to initializers and evaluated only when the cache is Redis and Flags table already exists. Meta: https://meta.discourse.org/t/development-install-fails-when-running-bin-rails-db-migrate/332754	2024-11-06 15:06:17 +11:00
Osama Sayegh	6f8f6a7726	FIX: Pass upload type correctly to uploads#create (#29600) ... Prior to Uppy, the `uploads#create` endpoint used to receive a `type` param that indicated the purpose/target of the upload, such as `avatar`, `site_setting` and so on. With the introduction of Uppy, the `type` param became the MIME type of the file being uploaded, and the purpose/target of the upload became a new param called `upload_type`, however the backend could still use the `type` param (which now contains MIME type) as the purpose/target of the upload if `upload_type` is absent. We technically don't need to send the MIME type over the network, but it seems like it's done by Uppy and we have no control over the `type` param that Uppy includes: 758de8167b/app/assets/javascripts/discourse/app/lib/uppy/uppy-upload.js (L146-L151) This commit does a couple of things: 1. It amends the `uploads#create` endpoint so it always requires the `upload_type` param and doesn't fallback to `type` if `upload_type` is absent 2. It forces consumers of the `UppyUpload` class (and by extension `UppyImageUploader`) to specify `type` of the upload Internal topic: t/140945.	2024-11-06 07:00:35 +03:00
Osama Sayegh	ae721bd0f1	DEV: Fetch settings by area name instead of individual settings (#29604) ... This commit switches the route for the about config page to retrieve the list of site settings that control the /about page by their area instead of their individual names. Internal topic: t/136384.	2024-11-06 06:56:27 +03:00
Ted Johansson	7d9d98422c	DEV: Enable the normalize_emails site setting by default (#29587) ... The normalize_emails setting makes it so that only canonical e-mails are considered for validation purposes. This means disallowing "plus addressing". For example, with this enabled, bob@discourse.org and bob+foo@discourse.org are considered the same address, and you can only sign up with one of them. Currently this is disabled by default, leading to a lot of spam sign-ups. It's healthier to consider this an opt-out setting.	2024-11-06 11:20:36 +08:00
Krzysztof Kotlarek	973b599e11	FIX: correctly display category name in replace text modal (#29612) ... Bug introduced in this PR https://github.com/discourse/discourse/pull/23232 The previous modal was using `category.name` https://github.com/discourse/discourse/pull/23232/files#diff-bfae353a2f3457780e5c281b6a165261cfe552dd9dd791f3859e52d60e22be7fL20	2024-11-06 13:39:52 +11:00
chapoi	8cb8ad763a	UX: add heading role to close composer dialog (#29590)	2024-11-06 03:39:37 +01:00
chapoi	fa03499c7e	UX: add missing role attribute (#29591)	2024-11-06 03:21:48 +01:00
dependabot[bot]	e2292d4c59	Build(deps): Bump ember-auto-import from 2.9.0 to 2.10.0 (#29606) ... Bumps [ember-auto-import](https://github.com/embroider-build/ember-auto-import/tree/HEAD/packages/ember-auto-import) from 2.9.0 to 2.10.0. - [Release notes](https://github.com/embroider-build/ember-auto-import/releases) - [Changelog](https://github.com/embroider-build/ember-auto-import/blob/main/packages/ember-auto-import/CHANGELOG.md) - [Commits](https://github.com/embroider-build/ember-auto-import/commits/HEAD/packages/ember-auto-import) --- updated-dependencies: - dependency-name: ember-auto-import dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-06 01:06:08 +01:00
Alan Guo Xiang Tan	57f4176b57	DEV: Bump rubocop_discourse (#29608)	2024-11-06 06:27:49 +08:00
dependabot[bot]	ff494f2f94	Build(deps-dev): Bump parser from 3.3.5.1 to 3.3.6.0 (#29605) ... Bumps [parser](https://github.com/whitequark/parser) from 3.3.5.1 to 3.3.6.0. - [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md) - [Commits](https://github.com/whitequark/parser/compare/v3.3.5.1...v3.3.6.0) --- updated-dependencies: - dependency-name: parser dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-06 05:48:04 +08:00
Jordan Vidrine	cf350ba54c	UX: Make codeblock buttons 'flat' (#29603)	2024-11-05 14:45:08 -06:00
Amanda Alves Branquinho	758de8167b	DEV: Add outlet wrapper for user card information replacement (#29523) ... * DEV: Add outlet wrapper for user card information replacement * Fix format issues * Fix format issues	2024-11-05 14:03:20 -03:00
Régis Hanol	afdca41fd5	FIX: weird slow auto scrolling on iOS (#29598) ... In some cases, on Safari iOS, we would recompute the "--composer-vh" variable due to a minimal change in the viewport. This ends up triggering a loop where setting this variable triggers another viewport resize event, which triggers another change of the variable... In order to fix (patch?) this issue, we now have a 1px leeway when checking the difference between the previous and new viewport. Internal ref - t/141088	2024-11-05 17:58:00 +01:00
Discourse Translator Bot	8a201c1e92	Update translations (#29595)	2024-11-05 16:55:45 +01:00
Bianca Nenciu	948e283e0f	FIX: Use correct styles on category pages (#29588) ... Multiple category styles can be used on the same site. The category and subcategories page will use the "desktop_category_page_style" setting and individual category pages will use the style selected in settings, if any. Commit c1f078ca tried to use the same style for both the category and subcategories page, but the route matching did not take into account the "discovery.categoryAll" and "discovery.categoryNone" variants of the "discovery.category" route.	2024-11-05 23:51:22 +08:00
dependabot[bot]	fc2a511ee2	Build(deps): Bump the rails group with 6 updates ... Bumps the rails group with 6 updates: | Package | From | To | | --- | --- | --- | | [actionmailer](https://github.com/rails/rails) | `7.1.4.2` | `7.1.5` | | [actionpack](https://github.com/rails/rails) | `7.1.4.2` | `7.1.5` | | [actionview](https://github.com/rails/rails) | `7.1.4.2` | `7.1.5` | | [activerecord](https://github.com/rails/rails) | `7.1.4.2` | `7.1.5` | | [activesupport](https://github.com/rails/rails) | `7.1.4.2` | `7.1.5` | | [railties](https://github.com/rails/rails) | `7.1.4.2` | `7.1.5` | Updates `actionmailer` from 7.1.4.2 to 7.1.5 - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v7.2.2/actionmailer/CHANGELOG.md) - [Commits](https://github.com/rails/rails/compare/v7.1.4.2...v7.1.5) Updates `actionpack` from 7.1.4.2 to 7.1.5 - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v7.2.2/actionpack/CHANGELOG.md) - [Commits](https://github.com/rails/rails/compare/v7.1.4.2...v7.1.5) Updates `actionview` from 7.1.4.2 to 7.1.5 - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v7.2.2/actionview/CHANGELOG.md) - [Commits](https://github.com/rails/rails/compare/v7.1.4.2...v7.1.5) Updates `activerecord` from 7.1.4.2 to 7.1.5 - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v7.2.2/activerecord/CHANGELOG.md) - [Commits](https://github.com/rails/rails/compare/v7.1.4.2...v7.1.5) Updates `activesupport` from 7.1.4.2 to 7.1.5 - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v7.2.2/activesupport/CHANGELOG.md) - [Commits](https://github.com/rails/rails/compare/v7.1.4.2...v7.1.5) Updates `railties` from 7.1.4.2 to 7.1.5 - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v7.2.2/railties/CHANGELOG.md) - [Commits](https://github.com/rails/rails/compare/v7.1.4.2...v7.1.5) --- updated-dependencies: - dependency-name: actionmailer dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rails - dependency-name: actionpack dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rails - dependency-name: actionview dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rails - dependency-name: activerecord dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rails - dependency-name: activesupport dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rails - dependency-name: railties dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rails ... Signed-off-by: dependabot[bot] <support@github.com>	2024-11-05 16:15:20 +01:00
David Taylor	415921a106	DEV: Use glint stable (#29597) ... Dependabot had ended up putting some glint packages on the stable version, and some on the unstable version. This made for some very weird behavior.	2024-11-05 15:12:54 +00:00
dependabot[bot]	2aeb529a69	Build(deps-dev): Bump @swc/core from 1.7.42 to 1.8.0 (#29578) ... Bumps [@swc/core](https://github.com/swc-project/swc) from 1.7.42 to 1.8.0. - [Release notes](https://github.com/swc-project/swc/releases) - [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md) - [Commits](https://github.com/swc-project/swc/compare/v1.7.42...v1.8.0) --- updated-dependencies: - dependency-name: "@swc/core" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-05 15:36:47 +01:00
dependabot[bot]	cc61efbb07	Build(deps): Bump json from 2.7.5 to 2.7.6 (#29573) ... Bumps [json](https://github.com/ruby/json) from 2.7.5 to 2.7.6. - [Release notes](https://github.com/ruby/json/releases) - [Changelog](https://github.com/ruby/json/blob/master/CHANGES.md) - [Commits](https://github.com/ruby/json/compare/v2.7.5...v2.7.6) --- updated-dependencies: - dependency-name: json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-05 15:16:15 +01:00
dependabot[bot]	0d27c7db70	Build(deps): Bump ace-builds from 1.36.3 to 1.36.4 (#29579) ... Bumps [ace-builds](https://github.com/ajaxorg/ace-builds) from 1.36.3 to 1.36.4. - [Release notes](https://github.com/ajaxorg/ace-builds/releases) - [Changelog](https://github.com/ajaxorg/ace-builds/blob/master/CHANGELOG.md) - [Commits](https://github.com/ajaxorg/ace-builds/compare/v1.36.3...v1.36.4) --- updated-dependencies: - dependency-name: ace-builds dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-05 15:15:20 +01:00
dependabot[bot]	84784d8733	Build(deps-dev): Bump puppeteer-core from 23.6.1 to 23.7.0 (#29577) ... Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer) from 23.6.1 to 23.7.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json) - [Commits](https://github.com/puppeteer/puppeteer/compare/puppeteer-core-v23.6.1...puppeteer-core-v23.7.0) --- updated-dependencies: - dependency-name: puppeteer-core dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-05 15:13:27 +01:00
dependabot[bot]	e4e93e0342	Build(deps-dev): Bump concurrently from 9.0.1 to 9.1.0 (#29576) ... Bumps [concurrently](https://github.com/open-cli-tools/concurrently) from 9.0.1 to 9.1.0. - [Release notes](https://github.com/open-cli-tools/concurrently/releases) - [Commits](https://github.com/open-cli-tools/concurrently/compare/v9.0.1...v9.1.0) --- updated-dependencies: - dependency-name: concurrently dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-05 15:12:58 +01:00
dependabot[bot]	85c30f4882	Build(deps-dev): Bump rubocop-ast from 1.33.1 to 1.34.0 (#29574) ... Bumps [rubocop-ast](https://github.com/rubocop/rubocop-ast) from 1.33.1 to 1.34.0. - [Release notes](https://github.com/rubocop/rubocop-ast/releases) - [Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop-ast/compare/v1.33.1...v1.34.0) --- updated-dependencies: - dependency-name: rubocop-ast dependency-type: indirect update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-11-05 15:12:35 +01:00
Jarek Radosz	d076ed8c77	DEV: Convert some simple model methods to async/await (#29594)	2024-11-05 14:59:51 +01:00
Juan David Martínez Cubillos	e65367d603	DEV: Add plugin outlet to about.hbs (#29582) ... * DEV: Add plugin outlet to about.hbs * linter issues * removed unintended code	2024-11-05 08:33:20 -05:00
Osama Sayegh	c3bc7a6a05	DEV: Add support for image fields in FormKit PageObject (#29589) ... This commit adds an API `upload_image` to `FormKitField` page object for setting an image file on an `Image` field in FormKit. Usage is like this: ```ruby form.field("image_field").upload_image(image_path) ``` The `value` API also now supports `Image` fields; it returns an `Upload` record if the field has an uploaded image.	2024-11-05 15:35:53 +03:00
Jarek Radosz	a553c9ea0c	FIX: Incorrect reference in TopicListHeaderColumn (#29593)	2024-11-05 13:17:41 +01:00
Jarek Radosz	cbfd596b1b	DEV: Remove unnecessary setupController methods (#29592) ... and call super instead of manually setting model	2024-11-05 13:17:32 +01:00
Martin Brennan	54e7dee6d7	FIX: Chat uploads over-secured in some situations (#29586) ... In the case where: * Secure uploads were enabled * Allow unsecure chat uploads was enabled * For a site with login required enabled When a chat upload was created, it was being marked as secure. Since there is no provision for secure uploads in chat, this would lead to broken uploads/images shown in the channel. We can use the "public types" functionality of secure uploads to make sure we never mark chat uploads as secure, and we can revisit this whenever we get around to allowing secure uploads in chat.	2024-11-05 15:56:30 +10:00
Sam	3b0332ef6c	DEV: use Sets for setting lists. (#29584) ... This makes membership checks more efficient	2024-11-05 16:04:24 +11:00
Robert	1aa836163e	FIX: poll ranked choice results not showing on first vote (#28542) ... Currently (for Ranked Choice only) a javascript exception is raised on very first vote, preventing the results from being rendered requiring a browser refresh (which doesn't error). Resolves: TypeError: this.args.rankedChoiceOutcome.round_activity is undefined with simple addition of optional chaining operator.	2024-11-05 09:29:07 +08:00
Robert	40a4d55c77	FIX: poll ranked choice voter expansion should append additional voters (#28432) ... Currently, for Ranked Choice results and voter list expansion, the code is replacing the voter list with the newly fetched page of voters instead of appending to the existing voter list. This is resolved in this PR and brings it in line with regular polls. See: https://meta.discourse.org/t/ranked-choice-poll-does-not-reflect-change-of-votes-in-outcome/321227/18	2024-11-05 09:28:32 +08:00
Martin Brennan	bba9a99e2e	DEV: Move all experimental settings into new setting category (#29583) ... This will allow admins to easily see all the experiments in one place. In the future, we would like a full Experiments config page with descriptions and screenshots, but this will do for now.	2024-11-05 09:43:12 +10:00