Guo Xiang Tan
6c65718301
Include response body when raising an error in FileHelper#download
.
2018-09-13 15:43:58 +08:00
Guo Xiang Tan
05a57d4f27
DEV: Clear cache after not before.
...
* Clearing after ensures that state does not leak
to specs in other files.
2018-09-13 14:23:32 +08:00
Guo Xiang Tan
5eb65ad612
FIX: Do not try to recover invalid Upload#short_url
in UploadRecovery
.
2018-09-13 13:59:17 +08:00
Guo Xiang Tan
1afe7162e1
Fix the build.
2018-09-13 13:41:38 +08:00
Guo Xiang Tan
d99dd840e4
Add basic test case for UploadRecovery
.
2018-09-13 13:26:23 +08:00
Sam
49f1f10f75
file is a .js file so don't use let
2018-09-13 14:58:45 +10:00
Sam
daa02431df
FIX: remove div used to measure textarea position
...
Also corrects the positioning of autocomplete (when typing @ or emoji)
Previously there were edge conditions where autocomplete would be hundreds
of pixels away due to a bug measuring.
This correct an issue where Firefox ends up having an enormous blank space
at the bottom of topics after editing.
2018-09-13 14:53:32 +10:00
Guo Xiang Tan
a3b3b0810d
Rescue errors when running dry run for UploadRecovery
.
2018-09-13 11:57:51 +08:00
Guo Xiang Tan
4dc25ad201
Fix s3 recovery from tombstone in UploadRecovery
.
2018-09-13 09:19:45 +08:00
David Taylor
9461c99210
DEV: Add travis_fold to termination stage
2018-09-12 18:59:48 +01:00
David Taylor
26bd67a865
DEV: Add travis_fold statements to docker_test
2018-09-12 17:52:58 +01:00
Guo Xiang Tan
24c55bd613
Add dry run option to UploadRecovery
.
2018-09-12 21:53:01 +08:00
Joffrey JAFFEUX
38668818a5
FIX: allows forcing unsafe string in select-kit ( #6386 )
...
forceEscape will be defaulted to true before next release.
2018-09-12 12:19:04 +02:00
Guo Xiang Tan
2cc48cfd06
Fix incorrect variable.
2018-09-12 02:06:14 -07:00
Guo Xiang Tan
c053f8ccf6
New rake task uploads:recover
.
2018-09-12 01:52:30 -07:00
Guo Xiang Tan
6d01e0aa04
DEV: Print the error class in uploads:list_posts_with_broken_images
.
2018-09-12 01:06:51 -07:00
Guo Xiang Tan
3884e99e88
Add extra protection in Upload#get_from_url
.
...
In case the extension goes missing from the URL.
2018-09-12 00:12:14 -07:00
Guo Xiang Tan
b3469bea2d
FIX: Uploads not being linked correctly to posts.
...
Regression due to 1f636c445b
.
2018-09-11 23:50:23 -07:00
Sam
d1984a0b4d
FIX: display a correct error when attempting to agree on a deferred flag
...
Previously we would raise a 500 error if a moderator tried to agree on a
flag another moderator deferred.
This can happen cause the UX for flags does not live refresh as flags
are handled
2018-09-12 13:16:59 +10:00
Guo Xiang Tan
71185c13b5
Merge pull request #6377 from tgxworld/remove_tif_tiff
...
Drop `tif`, `tiff`, `webp` and `bmp` from supported images.
2018-09-12 09:32:32 +08:00
Guo Xiang Tan
71caf7521d
Drop tif
, tiff
, webp
and bmp
from supported images.
...
https://meta.discourse.org/t/cr2-raw-files-are-being-treated-as-tiff-files/96775/3?u=tgxworld
2018-09-12 09:29:54 +08:00
Guo Xiang Tan
e1b16e445e
Rename FileHelper.is_image?
-> FileHelper.is_supported_image?
.
2018-09-12 09:22:28 +08:00
Guo Xiang Tan
d59e635a77
Rename FileHelper.images
to FileHelper.supported_images
.
2018-09-12 09:22:28 +08:00
Carsten Brandt
921e2213b8
FEATURE: Updated IPB import script
...
* IPB import script replace PHP code tags with proper markdown
remove excess newlines in code blocks
decode HTML entities in code blocks
add replacement for list items
proper handling of attachments that are not images
fix typo
improved quote handling
fix code style complaint from travis-ci build
2018-09-12 11:12:28 +10:00
Osama Sayegh
16bd3f2cf2
FIX: use current user color scheme when filling theme-color
attribute ( #6384 )
...
* FIX: use current user color scheme when filling `meta` attribute `theme-color`
* update manifest.webmanifest colors
2018-09-12 11:04:58 +10:00
Kyle Zhao
f1cb431968
FIX: rescue ActiveRecord::RecordInvalid in find_or_create_by_safe! ( #6385 )
...
AR uniqueness validation could raise ActiveRecord::RecordInvalid
2018-09-12 11:03:12 +10:00
Jeff Atwood
02f582eca0
add recent security commits info
2018-09-11 12:43:52 -07:00
Robin Ward
3bb4f4c5ef
Adds test to make sure moderators can't make master keys
...
It wasn't obvious from the code, plus we'd never want this to regress!
2018-09-11 12:02:06 -04:00
Gerhard Schlager
1a01385e88
FIX: "false" didn't work as locale_default
2018-09-11 13:42:10 +02:00
Gerhard Schlager
e847bb33d5
Better default settings for Japanese
2018-09-11 11:58:36 +02:00
Guo Xiang Tan
a033327b93
Manage qunit via yarn.
2018-09-11 15:07:28 +08:00
Guo Xiang Tan
85620abb71
DEV: Clear connections after multisite specs.
2018-09-11 10:15:06 +08:00
Guo Xiang Tan
244948497a
Lock puppeteer to 1.4.x.
...
1.8 doesn't seem to be able to click reliably.
2018-09-11 09:52:39 +08:00
Guo Xiang Tan
4ee8e77073
Apply prettier.
2018-09-11 09:16:03 +08:00
Arpit Jalan
51edb19aa9
FIX: pop3 polling password and mailgun API key should be secret
2018-09-11 06:40:33 +05:30
Neil Lalonde
b3b9ac3b19
Version bump to v2.2.0.beta1
2018-09-10 19:43:15 -04:00
Sam
103f9b5dc7
UX: missing translation in AWS site settings
2018-09-11 09:34:02 +10:00
Sam
e64402cb3b
SECURITY: correct edge case when SSO provides unvalidated emails
2018-09-11 08:24:02 +10:00
Rishabh
80eace4268
Merge pull request #6383 from discourse/fix_username_suggester
...
FIX: don't raise an error on integer usernames in user_name_suggester
2018-09-11 00:30:29 +05:30
Neil Lalonde
4653627a40
update plugin-translations.rb script to update .tx/config file in plugins when languages are added or removed
2018-09-10 14:22:45 -04:00
Neil Lalonde
6afc86398c
Update translations
2018-09-10 13:29:07 -04:00
Rishabh Nambiar
81c87df18a
FIX: don't raise an error on integer usernames
2018-09-10 22:17:56 +05:30
Blake Erickson
1d41f3c3fb
Merge pull request #6380 from discourse/rake-destroy-sub-category
...
FIX: Allow `rake destroy:topics` to delete topics in sub-categories
2018-09-10 10:26:04 -06:00
Kris
2b7e50cab8
Prevent fade-out from overlapping button in admin nav
2018-09-10 11:25:41 -04:00
Guo Xiang Tan
94ff428571
Pass the right value to rake task.
2018-09-10 20:07:28 +08:00
David Taylor
84fc7abb73
FIX: Allow rake destroy:topics
to delete topics in sub-categories
2018-09-10 12:52:14 +01:00
Guo Xiang Tan
4a966c639d
DEV: Update uploads:list_posts_with_broken_images
to recover from tombstone.
2018-09-10 17:01:41 +08:00
Joffrey JAFFEUX
d4080c020f
FIX: sets trends to 7 days instead of 3 ( #6379 )
2018-09-10 10:40:19 +02:00
Guo Xiang Tan
df04e69cde
FIX: S3Helper#list
creates incorrect prefix.
2018-09-10 16:34:40 +08:00
Guo Xiang Tan
68572b8afc
Print error messages on why upload fails to save.
2018-09-10 16:02:13 +08:00