Commit Graph

682 Commits

Author SHA1 Message Date
Sérgio Saquetim
1505978586
DEV: Upgrade dependencies to Ember 5.12 () 2024-12-11 11:09:25 -03:00
Régis Hanol
6ef0b5d508
Cleanup mobile topic footer area () 2024-12-11 14:59:37 +01:00
Isaac Janzen
00f8d7bb5d
DEV: Remove unused binding.pry () 2024-12-10 11:25:37 -06:00
zogstrip
aaec80413d FIX: fast edit with a typographic character
When a post containing an apostrophe (') is being cooked, the apostrophe is being converted to the "typographic" version (’) (because we enable markdown-it's **typographer** mode by default in Discourse)

When you select text that contains such apostrophe and then try to save your fast edit, it fails miserably without any error.

That's because when you select text from the DOM, it uses the cooked version which has the typographic apostrophe.

When you save your fast edit, we fetch the raw version of the post, which has the "regular" apostrophe. Thus doing `raw.replace(selectedText, editedText)` doesn't work because `raw` has the regular apostrophe but `selectedText` has the typographic apostrophe.

Since it's somewhat complicated to handle all typographic characters, we would basically have to reverse the process done in `custom-typographer-replacements.js`, we instead bail out and show the composer when we detect such character in the selection.

Internal ref - t/143836
2024-12-10 12:13:10 +01:00
Krzysztof Kotlarek
51a5fa036a
UX: the ability to hide the admin header ()
Some pages like new/edit item should not display admin header. New attribute called `@shouldDisplay` was added.

As a proof of concept, the flags page was updated.
2024-12-10 11:59:47 +11:00
Osama Sayegh
acc180611f
FEATURE: Add an option to block IPs and emails to bulk user delete ()
This commit adds an option for blocking the IP and email addresses when bulk-deleting users.

Internal topic: t/140321/11.
2024-12-09 14:25:31 +03:00
Martin Brennan
4ddf7e61f9
UX: Move "What's new?" link in admin sidebar to root section ()
This is so the link is more visible, instead of being
buried in the Account section.
2024-12-09 10:01:09 +10:00
Krzysztof Kotlarek
5759d80091
FIX: correct breadcrumb for admin users page ()
Omission and instead of `permlinks`, `users` title should be used.
2024-12-09 10:52:50 +11:00
Sérgio Saquetim
b8325f2190
FIX: Recover user deleted post ()
This commit fixes an issue where the recover button would not be displayed for a user delete post.
2024-12-06 15:47:57 -03:00
Gary Pendergast
2513339955
FEATURE: Show when a badge has been granted for a post ()
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
2024-12-03 13:43:27 +11:00
Régis Hanol
9bdd97db42
FIX: editing post while replying ()
BEFORE: if you click the "reply" button on a post and then decided that you want to "edit" the same post, clicking the "edit" button would do nothing. Clicking "edit" on another post works, but editing the same post would appear broken.

AFTER: if you click the "edit" button, it will properly load the content of the post you're trying to edit. No matter which one it is.

This was somewhat tricky to track down as the system specs seemed to contradict the qunit tests until I realized that the qunit tests were only testing the edit on the 1st post and the system specs were testing on replies.

I improved the qunit tests to test both editing OP and a reply and (hopefully) made the system specs a little bit clearer.

This is a follow up to bbe62d88d2.
2024-12-02 16:06:36 +01:00
Jarek Radosz
b3423c40b0
DEV: Fix random typos ()
(late) Nov 2024 edition
2024-12-02 07:34:05 +08:00
Krzysztof Kotlarek
6d4c6ee154
UX: admins users page follows admin ux guideline ()
Conversion of `/admin/users` page to follow admin UX guidelines.

In addition, add the username to the title on the user admin page.
2024-12-02 10:11:23 +11:00
Penar Musaraj
cd4de88e4a
FIX: Correctly toggle bulk select checkboxes for regular users ()
Non-admin/moderator users can bulk select items in new/unread, but not in
latest/top/hot. This commit ensures that when the user can no longer
bulk select items in a list, the bulk select checkboxes in the topic list
rows are hidden.
2024-11-28 09:39:17 -05:00
Jan Cernik
93443adf22
DEV: Remove the experimental_ prefix for fullpage login () 2024-11-26 11:08:27 -03:00
Ted Johansson
15a61a0c1f
DEV: Change admin emoji delete button from icon to text ()
The Admin UI guidelines states that buttons should have text, not icons. This was an oversight on the admin emoji listing.

Part of this change is also opportunistically removing the CSS file for admin emojis, none of which is used any more since the conversion.
2024-11-26 14:10:14 +08:00
Jan Cernik
a964e62cd8
FIX: Discourse Connect fixes for full page login () 2024-11-25 18:06:14 -03:00
Penar Musaraj
e6fdfcdcd2
DEV: Remove experimental_topics_filter setting () 2024-11-25 10:49:40 -05:00
Osama Sayegh
118f7869bb
FEATURE: Add bulk destroy to admin users list ()
This commit introduces a new feature that allows staff to bulk select and delete users directly from the users list at `/admin/users/list`. The main use-case for this feature is make deleting spammers easier when a site is under a large spam attack.

Internal topic: t/140321.
2024-11-25 11:13:35 +03:00
Osama Sayegh
eaa3f813c1
FIX: Don't secure the about banner image ()
Uploads that are linked to site settings shouldn't be flagged as secure in login-required sites that enable secure uploads. However, in order for site setting uploads to not be marked secured, the frontend uploader has to include 2 params in the upload request: `for_site_setting: true` and `type: "site_setting"`.

Since these 2 params are semantically identical, we want the `type: "site_setting"` param alone to make the upload correctly treated as a site setting upload. To achieve that, we need to include the `site_setting` type in the public types list because the `for_site_setting` param has the same effect — it marks the upload as a public type.

b138eaf9e5/lib/upload_security.rb (L128-L131)
2024-11-25 11:12:00 +03:00
Ted Johansson
88af23e1ca
DEV: Modernize admin user fields ()
This PR modernizes the user fields area of the admin UI. It is largely based on the work on the emoji section.
2024-11-25 11:54:43 +08:00
Akshay Birajdar
b138eaf9e5
FEATURE: Add Bulk actions to /filter page ()
- Add bulk actions component on /filter page for both desktop & mobile view.
- Add system specs to assert bulk actions to be available on /filter page.
2024-11-22 11:51:06 +11:00
Blake Erickson
acc87202b9
DEV: Fix flaky test with bulk select closing topics ()
This commit is going to try using the `have_read_post` page object from
`topic_view` instead of the page object for `topic` because it's
implementation has a longer wait time as it uses the ENV variable for
wait time: `Capybara.default_max_wait_time * 2`.

If this works out we should probably remove the duplicated
`have_read_post` page object so that we have a single implementation.
2024-11-20 16:34:44 -07:00
Kris
acc7caa816
A11Y: make the uppy image uploader keyboard navigable () 2024-11-19 15:38:13 -05:00
Krzysztof Kotlarek
04bac33ed9
UX: consistent flags page ()
Add/Edit form should not have an admin header
2024-11-19 14:46:08 +11:00
Jan Cernik
2ac1894292
FIX: Error with social logins and fullpage signup () 2024-11-14 16:02:17 -03:00
Régis Hanol
fd1220af69
FIX: chat bookmarks in drawer mode ()
When using chat in drawer mode, after you've clicked on a chat bookmark in the user menu, clicking any other chat bookmark would "do nothing".

In 8b18fd1556 we added an optimization to prevent the same route from being reloaded, but it ended up breaking the bookmarks.

This commit reverts the changed made the above commit and adds a system specs that ensure we can click two chat bookmarks in the user menu when using chat in drawer mode.

Internal ref - t/134362
2024-11-14 17:20:11 +01:00
Penar Musaraj
9b691853e0
FIX: Dismiss unread posts in subcategories ()
When a parent category shows topics from subcategories, dismissing
should dismiss posts in both parent and subcategories.

Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
2024-11-14 10:06:12 -05:00
Krzysztof Kotlarek
42b1ca8f78
UX: redesign admin permalinks page ()
Redesign the permalinks page to follow the UX guide. In addition, the ability to edit permalinks was added.

This change includes:
- move to RestModel
- added Validations
- update endpoint and clear old values after the update
- system specs and improvements for unit tests
2024-11-14 10:03:58 +11:00
Kris
9a22d7df7b
UX: reduce bottom topic map threshold, with protections () 2024-11-13 07:58:44 -05:00
Jan Cernik
920fa4c248
FIX: Correctly load the invites model when using full page logins () 2024-11-13 08:56:16 -03:00
Krzysztof Kotlarek
a0242764f3
FIX: flaky system flags spec ()
Wait for the flag button to arrive before clicking it.
2024-11-13 07:13:18 +11:00
Krzysztof Kotlarek
34ed35e174
FIX: filterable staff logs for flags ()
Flag actions must be added to `staff_actions` method to be filterable.
2024-11-12 11:23:18 +11:00
Sérgio Saquetim
3019bb577b
DEV: Modernize the post menu from widgets to Glimmer components ()
This commit modernizes the post menu by migrating it from the existing widget-based implementation to Glimmer components. This transition aims to improve the maintainability, performance, and overall developer experience.

It also introduces a new DAG-based transformer API for customizations that aims to be more flexible than the widget base one.

---------

Co-authored-by: David Taylor <david@taylorhq.com>
2024-11-11 15:36:08 -03:00
Ted Johansson
189d98f3ca
DEV: Convert admin emojis UI to new layout ()
This PR converts the custom emoji UI in the admin pages to follow the new admin UI guidelines.
2024-11-11 15:04:15 +08:00
Ted Johansson
f573fd8f5e
FEATURE: Add more bulk dismiss buttons with confirmation ()
When performing bulk dismissal in Unread and New views, the dismiss button stays at the top of the UI. Because of this we want to provide the dismiss action also in the "sticky" menu that's always in view, even when scrolling a long list of topics.
2024-11-08 15:59:12 +08:00
Osama Sayegh
4bc030f76f
FIX: Add back the option to create invite without emailing ()
Follow-up to a5497b74be

In the linked commit, as part of simplifying the invite modal, we removed the option to skip sending an email when creating an invite restricted to a specific address. This has caused confusion about whether an email will be sent by Discourse or not, so we're adding back the option to create a restricted invite without emailing.

Internal topic: t/134023/48.
2024-11-08 07:59:24 +03:00
Kris
64291fedf8
UX: lower min_post_count to show bottom topic map () 2024-11-07 20:10:18 -05:00
Renato Atilio
7568e732cc
FIX: resume editing when through /new-message ()
"Resume editing" would do nothing when going through the `/new-message` flow.

This seems to be broken since [this commit](b0f6d074be). which moved `this._setModel` calls around – the same we're doing now, but to different places: the first one needs to happen after the `draft.data` has been set , while the second needs to happen before the `this.open` call.
2024-11-07 17:39:58 -03:00
Keegan George
fad0d2ec62
UX: New experimental features should be marked clearly ()
This PR adds a small visual change to the new feature item on the `/admin/whats-new` page. When features are marked with an experimental site setting, they should show an indication on the feature item that it is "Experimental"
2024-11-06 15:26:30 -08:00
Bianca Nenciu
635faaaf59
DEV: Add system spec for categories page ()
Follow up to commit 948e283e0f.
2024-11-06 20:01:27 +02:00
Krzysztof Kotlarek
973b599e11
FIX: correctly display category name in replace text modal ()
Bug introduced in this PR https://github.com/discourse/discourse/pull/23232

The previous modal was using `category.name`

https://github.com/discourse/discourse/pull/23232/files#diff-bfae353a2f3457780e5c281b6a165261cfe552dd9dd791f3859e52d60e22be7fL20
2024-11-06 13:39:52 +11:00
Osama Sayegh
c3bc7a6a05
DEV: Add support for image fields in FormKit PageObject ()
This commit adds an API `upload_image` to `FormKitField` page object for setting an image file on an `Image` field in FormKit. Usage is like this:

```ruby
form.field("image_field").upload_image(image_path)
```

The `value` API also now supports `Image` fields; it returns an `Upload` record if the field has an uploaded image.
2024-11-05 15:35:53 +03:00
Martin Brennan
badca20749
DEV: Combine S3 system spec helpers into one ()
It's annoying to have to do both of these every
time you write an S3 system spec, let's just do them
in one call instead.
2024-11-05 09:28:14 +10:00
Keegan George
7a936da05c
DEV: Auto grid images no longer experimental ()
Recently we added a new feature for automatically gridding images in the composer (https://github.com/discourse/discourse/pull/29260). After testing this feature under a setting for a short period of time, the feature is no longer experimental anymore.

This PR removes the site setting `experimental_auto_grid_images`.
2024-11-04 08:21:40 -08:00
Penar Musaraj
c8e03f251f
DEV: Remove body docked class and its scroll event listener ()
Docking is a leftover from older header code, it looks like it is no
longer used in the app. This helper was registering a scroll event
listener to check if the header should be docked or not. Initially, a
"docked" class was added to the body element. This class persisted
through the lifecycle of the app and the scroll event was doing no
useful work.

Some older themes may still use it in CSS, that will cause a regression,
from a quick look at existing code, the surface area should be small
(2-3 themes). It's worth removing the event listener for performance
reasons. We could possibly add the class "docked" statically to the body
element, but it's redundant. It's best to clean up the relevant CSS in
themes, where applicable.
2024-10-31 10:21:50 -04:00
Osama Sayegh
0ad1c02932
FEATURE: Add 'Community title' field to about config page ()
This commit adds a new "Community title" field to the about config page. This field controls the `short_site_description` setting, which is shown in the browser tab for key pages such categories pages and topic lists.

Internal topic: t/140812.
2024-10-31 10:04:31 +03:00
Osama Sayegh
19672faba6
FEATURE: Add invite link to the sidebar ()
This commit adds a new "Invite" link to the sidebar for all users who can invite to the site. Clicking the link opens the invite modal without changing the current route the user is on. Admins can customize the new link or remove it entirely if they wish by editing the sidebar section.

Internal topic: t/129752.
2024-10-30 05:31:14 +03:00
Martin Brennan
c3f99c8634
DEV: Fix admin confirmation flaky spec () 2024-10-30 04:59:51 +10:00
Jan Cernik
e5ac69fd65
DEV: Revert flaky specs fix attempts () 2024-10-29 13:37:37 -03:00