Sam
4edbb5b98c
Merge pull request #2773 from riking/post-handlebars
...
(Trivial) Handlebars structure tweaks to post.handlebars
2014-09-10 09:04:12 +10:00
Robin Ward
2d32325ac7
FIX: Show user expansion on user stream too
2014-09-09 17:55:55 -04:00
Robin Ward
62c9e4228d
Rename {{icon}} helper to {{fa-icon}} for future Ember
...
compatibility.
2014-09-09 17:29:05 -04:00
Robin Ward
cec6b64a45
FIX: Don't show filter on user card if not in topic
2014-09-09 16:53:43 -04:00
Robin Ward
a09ff29dd9
UX: Only intercept Cmd-F/Ctrl-F for search on a topic when not all posts
...
are available in the DOM.
2014-09-09 16:05:17 -04:00
Robin Ward
504d61de94
FIX: Clicking on expanded user actions uses user expansion. Also added
...
integration test.
2014-09-09 15:18:04 -04:00
Régis Hanol
79030c874e
FIX: allow staff members to restore withdrawn posts that are flagged
2014-09-09 20:26:40 +02:00
riking
7bb1b8bc97
Handlebars structure tweaks to post.handlebars
...
- Combine bind-attrs on the <article> (seriously that made no sense)
- Hoist a bind-attr class to the view, allowing more fancy styling
- Hoist a <div> outside a conditional
- Change href='#' to unvalued hrefs
2014-09-09 11:20:25 -07:00
Robin Ward
8b33e659a1
FIX: Only use cached topic lists on popState
2014-09-09 12:57:51 -04:00
Robin Ward
a96ba8ed78
Revert "FIX: unread/new counts out of sync with tabs"
...
This reverts commit c093187d34
2014-09-09 12:57:51 -04:00
Régis Hanol
eb34ecfc0c
FEATURE: new 'prevent anons from download files' site setting
2014-09-09 18:41:13 +02:00
Régis Hanol
69bc24a16d
FIX: clicking a button that disappears in a modal would close the modal (take 2)
2014-09-09 10:44:26 +02:00
Régis Hanol
357c43e941
FIX: clicking the 'edit permission' button would close the category modal
2014-09-09 10:16:12 +02:00
Sam
c093187d34
FIX: unread/new counts out of sync with tabs
...
We were serving cached lists of topics to non popstate reqs
2014-09-09 16:56:20 +10:00
Robin Ward
2f04b53c9f
FIX: Clicking outside of modal wasn't closing it
2014-09-08 16:53:05 -04:00
Robin Ward
9d9d93ad3c
Merge pull request #2771 from techAPJ/patch-1
...
Don't show new topic indicator on New tab
2014-09-08 15:35:23 -04:00
Arpit Jalan
80510c5114
Don't show new topic indicator on New tab
2014-09-09 01:02:16 +05:30
Robin Ward
56eda5abf9
FIX: Don't allow profile bios longer than 3k chars
2014-09-08 15:23:21 -04:00
Régis Hanol
948e0740c9
FEATURE: add glyphs in the composer 'save' button
2014-09-08 19:02:53 +02:00
Régis Hanol
ea6cab66cb
FIX: remove curvy arrow on reply to topic button
2014-09-08 19:02:14 +02:00
Régis Hanol
00bd665c96
FEATURE: add count of previous flags on the post
2014-09-08 17:53:29 +02:00
Robin Ward
7d6f3a5089
FIX: Only show warning creation to staff. Server side was OK.
2014-09-08 11:22:11 -04:00
Robin Ward
334e21a03a
Revert "Revert "FEATURE: Can create warnings for users via PM""
...
This reverts commit 1c7559380c
2014-09-08 11:11:56 -04:00
Robin Ward
1c7559380c
Revert "FEATURE: Can create warnings for users via PM"
...
This reverts commit b0bfc1f93f
2014-09-08 10:38:59 -04:00
Robin Ward
b0bfc1f93f
FEATURE: Can create warnings for users via PM
2014-09-08 10:27:06 -04:00
Jeff Atwood
9b2e850553
UX: suppress outgoing right arrow on gutter links
2014-09-08 01:15:40 -07:00
Jeff Atwood
107cffcc84
FIX: revert readonly on share link field
2014-09-08 01:03:50 -07:00
Sam
563a313179
Merge pull request #2767 from gschlager/i18n_fix04
...
FIX: Some default group names could not be translated
2014-09-08 13:06:29 +10:00
Sam
2a7355405e
FEATURE: add age to results of search
2014-09-08 10:02:47 +10:00
Jeff Atwood
65e941f652
UX: remove current username from header
2014-09-07 14:01:51 -07:00
Jeff Atwood
3cf433ab1e
FIX: quote icon in Quote Reply not clickable
2014-09-07 13:55:31 -07:00
Jeff Atwood
aa0d14825a
add spaces for flag/admin glyphs on hamburger
2014-09-07 13:24:33 -07:00
Gerhard Schlager
970aafecb4
FIX: Some default group names could not be translated
2014-09-07 14:48:03 +02:00
Jeff Atwood
3bdc6f9fad
UX: remove email display from profile page
2014-09-05 13:11:50 -07:00
Robin Ward
66501190bd
FIX: Missing id attribute caused failing test
2014-09-05 13:15:50 -04:00
Robin Ward
4bec839d9d
Using Discourse.XYZ in templates is deprecated. This fixes that, plus
...
adds some more integration tests to make sure login required is working.
2014-09-05 13:09:01 -04:00
Neil Lalonde
ca5f361d0a
FEATURE: restrict admin access based on IP address
2014-09-05 12:06:01 -04:00
Jeff Atwood
dc8fc8c9e4
UX: move "show more" in search to bottom of results
2014-09-05 02:19:06 -07:00
Arpit Jalan
0db66d3a18
Add education panel for starred tab
2014-09-05 11:15:10 +05:30
cpradio
2ef499d021
UX: Add g, t keyboard shortcut to modal window for go to top
...
https://meta.discourse.org/t/add-shortcut-g-t-to-go-to-top-page/19586
2014-09-04 18:28:03 -04:00
Jeff Atwood
bbbca820d8
FIX: edit history user setting was appearing
2014-09-04 13:47:05 -07:00
Jeff Atwood
fad0394a40
more renaming of trust level settings
2014-09-04 13:32:00 -07:00
Jeff Atwood
fcca64c0cf
rename site settings for trust levels as numbers
2014-09-04 13:16:51 -07:00
Robin Ward
229566fc32
Remove deprecated Ember.Set
2014-09-04 15:01:12 -04:00
Robin Ward
52e25c9272
FIX: tabindex was not set on the category chooser when creating a topic.
2014-09-04 13:50:51 -04:00
Jeff Atwood
742e2b1fa9
FIX: add classes to mobile education panels
2014-09-04 10:39:47 -07:00
Robin Ward
1c5e8efa68
FEATURE: Show an email icon beside posts that arrived via email
2014-09-04 13:04:41 -04:00
Robin Ward
8ac955247c
Convert category helpers to ES6.
2014-09-04 11:32:30 -04:00
Sam
a3863b52db
More highlight tweaking for search, makes it much easier to theme
2014-09-04 18:00:01 +10:00
Sam
9d75f41172
try softening highlight on topic stop highlighting categories
2014-09-04 15:30:17 +10:00
Sam
0ade9bafff
FIX: highlight in yellow, not blue
...
FEATURE: highlight in title
2014-09-04 15:01:13 +10:00
Sam
b8c36bd2da
FIX: broken search for admins when selecting topics
2014-09-04 12:21:57 +10:00
Robin Ward
a67e400027
FIX: Remove contents class
2014-09-03 17:17:53 -04:00
riking
824dadbc1b
FIX: Add .cooked class to composer preview
...
This should make any custom styling apply to both the rendered posts and
the composer equally, as long as a .topic-body parent or a #wmd-preview
parent is not specified.
2014-09-03 13:18:48 -07:00
Robin Ward
dac4ed5a1e
Prune dead code for search keyboard navigation in search, remove bad
...
tests.
2014-09-03 15:05:22 -04:00
Robin Ward
40b1558f83
Merge pull request #2747 from cpradio/remove-additional-search-code
...
FIX: Remove additional search code related to the up/down navigation
2014-09-03 14:46:09 -04:00
Robin Ward
e9600d7cb1
Convert some application helpers to ES6 format.
2014-09-03 13:30:22 -04:00
Robin Ward
0b6c84e292
UX: Remove background color from new badge. DRY up lots of repeated code
...
for rendering badges on topics.
2014-09-03 12:22:18 -04:00
Neil Lalonde
6489c1d7e3
FIX: admin page for users who have not been activated makes it more clear that the account is inactive, and won't offer actions that don't work yet
2014-09-03 10:41:13 -04:00
Neil Lalonde
ff136ddeea
FEATURE: accounts that have not been activated are grey in admin user lists
2014-09-03 10:09:30 -04:00
Sam
c6aab831ed
Merge pull request #2741 from riking/badges_create_checks
...
FIX: Apply contract checks when first creating a badge
2014-09-03 22:19:09 +10:00
Sam
9c16dee843
Merge pull request #2742 from riking/patch-1
...
UX: Change Impersonate to btn-danger
2014-09-03 22:18:19 +10:00
cpradio
44a25271f1
FIX: Remove additional search code related to the up/down navigation
...
Removed additional search code that was related to the up/down navigation and their related tests.
https://meta.discourse.org/t/magic-search-code-for-keyboard-shortcuts/19563
2014-09-03 06:51:52 -04:00
Sam
d4f08f442c
FIX: correct template for search in post (regression)
2014-09-03 17:09:01 +10:00
Sam
921dd75dd9
FIX: anonymous had <a> items for pin/unpin
...
FEATURE: display category in search results
FEATURE: display topic state (locked/pinned/etc) in search results
UI cleanup for search results, clearing floats and so on.
2014-09-03 12:13:26 +10:00
Sam
4f09d552ed
FEATURE: increase search expansion to 50 results
...
refactor search code to deal with proper objects
use proper serializers, test the controllers
2014-09-03 12:13:25 +10:00
riking
71b7c80257
UX: CSS tweaks for badge query previews
2014-09-02 19:09:51 -07:00
riking
8979020b9d
Clean up unused translations
2014-09-02 15:40:23 -07:00
riking
3413228e89
UX: Change Impersonate to btn-danger
2014-09-02 15:33:54 -07:00
Robin Ward
b04a52676e
FIX: Don't show wrong flag choices after undo
2014-09-02 17:37:54 -04:00
Jeff Atwood
defe1dd86f
Merge pull request #2739 from techAPJ/patch-1
...
hide poster avatars when only two posts
2014-09-02 09:54:52 -07:00
Robin Ward
abd84cd2a1
FIX: Redirect to Top was showing "latest" content because it was in the
...
preload store.
2014-09-02 12:29:22 -04:00
Robin Ward
d09f109b2c
FIX: Re-enable filtering on user expansions on topics
2014-09-02 12:08:02 -04:00
Robin Ward
ce745b737e
Renamed poster-expansion to user-expansion because it's not specific
...
to a poster anymore.
2014-09-02 12:08:02 -04:00
Robin Ward
2b0e11dad8
Merge pull request #2711 from hydrarulz/localize_romanian
...
Add translation for Romanian.
2014-09-02 10:48:38 -04:00
Robin Ward
065101afac
Merge pull request #2734 from cpradio/readd-dismiss-bindings
...
FIX: Readd the dismiss keybindings
2014-09-02 10:42:53 -04:00
Arpit Jalan
8955bf02d8
hide poster avatars when only two posts
2014-09-02 20:10:36 +05:30
Sam
e0c8abc911
Merge pull request #2717 from riking/badge-solid
...
Admin badge interface improvements
2014-09-02 08:21:06 +10:00
Sam
202656a679
Merge pull request #2725 from cpradio/german-keyboard-support
...
FIX: Support J/K bindings on German Keyboards
2014-09-02 08:02:10 +10:00
cpradio
02a7a579f4
FIX: Duplicate badge titles can still occur
...
Send false instead of true to .uniq as the badges are not sorted.
https://meta.discourse.org/t/set-title-dialog-shows-multiple-instances-of-the-same-badge-2/19495
2014-09-01 13:56:19 -04:00
Jeff Atwood
03a7b01e4b
Merge pull request #2735 from techAPJ/patch-3
...
suppress post count on avatar for single post
2014-09-01 08:11:32 -07:00
Arpit Jalan
eba3f6b408
suppress post count on avatar for single post
2014-09-01 14:23:34 +05:30
Sam
69e418facf
FEATURE: wider search with more context
2014-09-01 17:04:57 +10:00
cpradio
42c052d21b
FIX: Readd the dismiss keybindings
...
https://meta.discourse.org/t/new-updated-bar-and-dismiss-new-button-unreachable-by-keyboard/18946/10?u=cpradio
2014-08-31 21:56:38 -04:00
cpradio
6234284243
FIX: Remove the old keyboard bindings for next/prev section, update client.en.yml to reflect the new bindings
2014-08-31 21:42:03 -04:00
riking
1833b43ae2
FEATURE: Badge query validation, preview results, and EXPLAIN
...
Upon saving a badge or requesting a badge result preview,
BadgeGranter.contract_checks! will examine the provided badge SQL for
some contractual obligations - namely, the returned columns and use of
trigger parameters.
Saving the badge is wrapped in a transaction to make this easier, by
raising ActiveRecord::Rollback on a detected violation.
On the client, a modal view is added for the badge query sample run
results, named admin-badge-preview.
The preview action is moved up to the route.
The save action, on failure, triggers a 'saveError' action (also in the
route).
The preview action gains a new parameter, 'explain', which will give the
output of an EXPLAIN query for the badge sql, which can be used by forum
admins to estimate the cost of their badge queries.
The preview link is replaced by two links, one which omits (false) and
includes (true) the EXPLAIN query.
The Badge.save() method is amended to propogate errors.
Badge::Trigger gets some utility methods for use in the
BadgeGranter.contract_checks! method.
Additionally, extra checks outside of BadgeGranter.contract_checks! are
added in the preview() method, to cover cases of null granted_at
columns.
An uninitialized variable path is removed in the backfill() method.
TODO - it would be nice to be able to get the actual names of all
columns the provided query returns, so we could give more errors
2014-08-31 11:25:44 -07:00
Sam
5c244c6f8f
FIX: autocomplete username failing to pop up
...
Janky autocomplete behavior due to debounce not being accounted for
correctly when dealing with promises
This also fixes a promise leak
2014-09-01 01:48:17 +10:00
Jeff Atwood
6d1be665a1
Merge pull request #2729 from cpradio/firefox-kbd-post-navigation
...
FIX: j/k navigation for posts using Firefox
2014-08-30 13:32:15 -07:00
cpradio
37639308c0
FIX: Firefox j/k post navigation is inconsistent
...
https://meta.discourse.org/t/j-k-navigation-in-lengthy-topics/18945
2014-08-30 08:59:08 -04:00
cpradio
3f5d530553
Change SHIFT+J and SHIFT+K to move up/down sections instead of posts.
2014-08-30 07:31:38 -04:00
Arpit Jalan
82d4c29c88
TRIVIAL: add line break before time for post navigator
2014-08-30 16:14:00 +05:30
Jeff Atwood
7a50ba600a
Merge pull request #2726 from techAPJ/patch-4
...
FIX: use short date format for post navigator
2014-08-29 23:11:31 -07:00
Arpit Jalan
3c005557e6
FIX: use short date format for post navigator
2014-08-30 11:34:33 +05:30
Jeff Atwood
4281b16616
UX: dim the new and unread education
2014-08-29 22:54:11 -07:00
cpradio
89eb03aff0
FIX: Support J/K bindings on German Keyboards
...
J/K are not supported on German keyboards, shift+j and shift+k have been added to remedy this.
https://meta.discourse.org/t/keyboard-shortcuts-for-next-previous-section-do-not-work-with-german-keyboard-layout/18902
2014-08-29 22:18:03 -04:00
cpradio
8b349b43a5
UX: Add keyboard binding for reply as new topic
...
Removed extra translation in the keyboard shortcut modal window
2014-08-29 20:10:34 -04:00
cpradio
2e200ffbf0
Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics
...
Conflicts:
config/locales/client.en.yml
2014-08-29 20:05:59 -04:00
cpradio
875b39fb5f
Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics
2014-08-29 19:56:39 -04:00
Jeff Atwood
cb45d5fa25
Merge pull request #2724 from cpradio/key-binding-reply-new-topic
...
UX: Add keyboard binding for reply as new topic
2014-08-29 16:46:34 -07:00
Jeff Atwood
d74f94afa1
Merge pull request #2722 from cpradio/dismiss-keyboard-bindings
...
UX: Add key-bindings for Dismiss New, Dismiss Posts, and Dismiss Topics
2014-08-29 16:28:25 -07:00
cpradio
68e807f791
UX: Add keyboard binding for reply as new topic
2014-08-29 19:14:42 -04:00
cpradio
bc07bc4819
Remove incoming/updated topics logic (not sure how that got in here, but it is causing a conflict)
2014-08-29 18:19:06 -04:00
Neil Lalonde
1291e94c78
Merge pull request #2715 from cpradio/master
...
UX: Add focus to menu only if it comes from a keyboard shortcut and improve keyboard functionality for search
2014-08-29 17:04:52 -04:00
Robin Ward
6dcde9ccc3
FIX: Navigating to None was not working
2014-08-29 15:51:28 -04:00
Robin Ward
926e45d030
SECURITY: User action route was returning too much data
2014-08-29 13:46:50 -04:00
Robin Ward
16c9f073b5
FIX: Back button breaks translation of incoming stuff
2014-08-29 12:53:06 -04:00
Neil Lalonde
ec42b61a4d
FIX: suspended users cannot be trust level 3
2014-08-29 12:33:34 -04:00
cpradio
8033972536
UX: Add keyboard bidning for incoming/updated topics
...
Fixed the selector used to gain access to the clickable div
2014-08-29 10:01:36 -04:00
cpradio
5ca96e741d
UX: Add keyboard bidning for incoming/updated topics
2014-08-29 09:44:26 -04:00
cpradio
096bc0c0ae
Merge branch 'keyboard-binding-new-topics-banner' into dismiss-keyboard-bindings
...
Conflicts:
app/assets/javascripts/discourse/lib/keyboard_shortcuts.js
2014-08-29 09:36:34 -04:00
cpradio
cde64580b1
Change the Dismiss keybindings to use 'x' instead of 'd' - moved it to a function binding
2014-08-29 09:35:38 -04:00
cpradio
3f085c3fd3
Change the Dismiss keybindings to use 'x' instead of 'd'
2014-08-29 09:22:47 -04:00
cpradio
ede9d1e057
Change the Dismiss keybindings to use 'x' instead of 'd'
2014-08-29 08:46:35 -04:00
cpradio
9e72b97a75
Corrected an issue with using the same ID for the header/footer of the buttons
2014-08-29 08:33:45 -04:00
cpradio
e4ce995369
FIX: Changed Dismiss New and Dismiss Posts to use d + r because p is reserved for the profile menu and n is reserved for the notifications menu
2014-08-29 08:11:23 -04:00
cpradio
ed8d828ff1
FIX: Added keyboard bindings for dismiss buttons
2014-08-29 08:04:57 -04:00
Régis Hanol
fd6dd88afb
FIX: dual modal when deleting spammer in the flag modal
2014-08-29 13:05:51 +02:00
Régis Hanol
521cb6bd0d
FIX: dual modal when selecting 'delete spammer' in flags section
2014-08-29 12:54:24 +02:00
Jeff Atwood
8bda8a2235
Revert "UX: stop displaying "user deleted, OK" dialog"
...
This reverts commit 36405287b4
2014-08-29 03:49:00 -07:00
Jeff Atwood
36405287b4
UX: stop displaying "user deleted, OK" dialog
2014-08-29 03:34:23 -07:00
riking
3396e6fea3
Centralize MessageBus post updates
...
After this change, only two files directly publish to MessageBus with a
topic interpolated in the channel: Post and TopicUser.
2014-08-28 20:40:36 -07:00
cpradio
0784c52a24
FIX: Remove up/down key bindings for search results
...
Up/down key bindings make it difficult to access Show More on search results.
https://meta.discourse.org/t/keyboard-users-cant-select-show-more-in-search-results/19394
2014-08-28 21:39:19 -04:00
cpradio
3e7084743c
FIX: Remove up/down key bindings for search results
...
Up/down key bindings make it difficult to access Show More on search results.
https://meta.discourse.org/t/keyboard-users-cant-select-show-more-in-search-results/19394
2014-08-28 19:58:07 -04:00
Robin Ward
9e2c72e277
Allow restoring from backups in development mode even if the setting is
...
off.
2014-08-28 17:02:48 -04:00
cpradio
1acb2a13f1
Added a:first
2014-08-28 16:06:48 -04:00
cpradio
4fd73a2b2f
Set focus on site-map and user menu
...
Set focus on first item in the site-map and user drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-28 16:04:54 -04:00
Robin Ward
8a6c4234fc
FIX: Re-enable searching for topic by id when using the split topic
...
interface.
2014-08-28 15:42:29 -04:00
Robin Ward
b5b13b8c5f
Revert "Merge pull request #2713 from cpradio/master"
...
This reverts commit a9de189682b7ab43e454
2014-08-28 15:08:06 -04:00
Robin Ward
a9de189682
Merge pull request #2713 from cpradio/master
...
Set focus on first item in drop down (textbox, link, whatever it may be)
2014-08-28 14:47:38 -04:00
Robin Ward
8bf27642ad
FIX: Refresh was losing top controls after bulk operation. Removed
...
console.log
2014-08-28 14:44:38 -04:00
Robin Ward
69cb5bc425
FIX: Centralize Top rendering, remove old code paths. Fix some bugs.
2014-08-28 14:34:31 -04:00
Robin Ward
30b102aa98
FIX: Show uncategorized with badge/description in the category chooser
2014-08-28 12:42:31 -04:00
cpradio
a40b08f210
Set focus on first item in drop down (textbox, link, whatever it may be)
...
Set focus on first item in the drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-28 11:33:45 -04:00
Luca Daniel
2cf92dbe7b
Add translation for Romanian.
2014-08-28 14:01:14 +03:00
Sam
3a9f0445bb
HACK: remove jarring scroll when hitting back from topic
2014-08-28 11:57:24 +10:00
Robin Ward
fc71662a13
FIX: Don't show topics as unread when hitting back
2014-08-27 18:01:02 -04:00
Neil Lalonde
940c0d5dbb
FIX: topicCountStats was depending on the wrong properties
2014-08-27 15:58:32 -04:00
Robin Ward
f05d2ed7cf
PERF: Do far fewer checks and use a lot less memory when loading more
2014-08-27 15:31:06 -04:00
Robin Ward
aab8eaac03
FIX: Double clicking quote expansion shouldn't break stuff.
2014-08-27 14:04:00 -04:00
Robin Ward
09ea159afc
UX: Add link to change username on admin page
2014-08-27 13:52:01 -04:00
Robin Ward
b1c0a3d01c
FIX: Retain back button scroll position even if we don't load more.
2014-08-27 13:33:52 -04:00
Arpit Jalan
3a76f9e79f
FIX: allow localization in timestamp
2014-08-27 20:57:06 +05:30
Sam
f48b78c0bb
FEATURE: Allow localization sessions
...
use: I18n.verbose_localization_session()
2014-08-27 17:50:29 +10:00
Arpit Jalan
0453da6fa5
FIX: use short date format for timestamp
2014-08-27 12:56:52 +05:30
Sam
16c34c206d
FEATURE: verbose localization option
2014-08-27 14:12:11 +10:00
cpradio
1678a91a60
Add shortcuts for Profile Menu and Hamburger Menu
...
Added shortcuts of p and = for the profile and hamburger menu
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-26 20:30:20 -04:00
Robin Ward
105959c402
Merge pull request #2696 from riking/errors
...
Fix "Server Error: [missing {{code}} value]" page
2014-08-26 11:14:57 -04:00
Jens Maier
c58565d09f
Fix: dialect block parser should not eat next block's whitespace
2014-08-26 14:11:23 +02:00
Jeff Atwood
d63c6292b3
change "Visit Profile" to just "Profile"
2014-08-26 00:37:10 -07:00
Jeff Atwood
553e0290a6
mods can use shield glyph as well, don't need two
2014-08-25 23:49:39 -07:00
