discourse

mirror of https://github.com/discourse/discourse.git synced 2024-12-02 22:53:44 +08:00

Author	SHA1	Message	Date
Régis Hanol	6b51d84dc5	FIX: Don't enqueue topics if the user can't create them Co-authored-by: Vinoth Kannan <vinothkannan@vinkas.com>	2018-11-09 18:24:28 +01:00
Sam	bc7c1e411c	DEV: Ruby 2.5.1 is no longer supported with Discourse This removes a monkey patch we no longer need since our containers require 2.5.2 or up for all Discourse installs. If you are looking to deploy on 2.5.1 which is highly not recommended you will need to figure out how to apply this diff.	2018-11-09 18:24:58 +11:00
Sam	7d52f5869d	Revert "FIX: Don't enqueue topics if the user can't create them" This reverts commit `515e103db6`.	2018-11-09 15:25:38 +11:00
Vinoth Kannan	515e103db6	FIX: Don't enqueue topics if the user can't create them	2018-11-09 06:10:23 +05:30
Gerhard Schlager	24e5be3f0c	FIX: Relative links in translations should work with subfolder	2018-11-08 23:31:05 +00:00
Guo Xiang Tan	14ff47f6f1	Fix typo.	2018-11-08 16:42:12 +08:00
Guo Xiang Tan	7290145641	PERF: Speed up `migrate_to_s3` rake task. * Prioritizes non-image uploads * Does one remap per upload instead of 3 remaps previously * Every 100 uploads migrated, do 2 remaps which fixes broken URLs * Exclude email_logs table from remap	2018-11-08 16:39:56 +08:00
Guo Xiang Tan	57f92ac808	Revert "Swtich to regexp for `DbHelper.remap`." Regexp is so much slower. This reverts commit `c3f89e3cd7`.	2018-11-08 14:20:09 +08:00
Guo Xiang Tan	c3f89e3cd7	Swtich to regexp for `DbHelper.remap`.	2018-11-08 14:08:38 +08:00
Sam	42572ff138	Revert font awesome 5 changes We are still pushing ahead on this 100% just need a bit longer to prepare all plugins	2018-11-08 16:12:18 +11:00
Guo Xiang Tan	0232a3b5e5	PERF: Exclude tables when remapping in `migrate_to_s3` rake task.	2018-11-08 12:37:36 +08:00
Guo Xiang Tan	9737938a4a	Add option to skip tabels when using `DbHelper.remap`.	2018-11-08 12:29:37 +08:00
Penar Musaraj	09dc922b3b	Fix several FontAwesome 5 issues add missing icons, update SvgSprite methods (to fix ruby 2.4 issues), update whisper icon in composer, fix alignment issues	2018-11-07 22:20:53 -05:00
Guo Xiang Tan	3365753bd0	PERF: Reduce number of database queries for `DbHelper.remap` * Cuts number of queries from 273 to 89 * Add some specs * For a table with 500 posts, benchmarks locally shows a runtime reduction from 0.046929135 to 0.032694705.	2018-11-08 10:54:39 +08:00
Penar Musaraj	9a34c6153e	Fix small issues with FA5 icons	2018-11-07 16:39:04 -05:00
Penar Musaraj	005e1ecb9b	FEATURE: Update Font Awesome to v5.4.1 and SVGs (#6557 ) * First take on subsetting svg icons * FontAwesome 5 svg subset WIP * Include icons from plugins/badges into svg sprite subset * add svg icon support to themes * Add spec for SvgSprite * Misc. SVG icon fixes * Use FA5 svgs in local-dates plugin * CSS adjustments, fix SVG icons in group flair * Use SVG icons in poll plugin * Add SVG icons to /wizard	2018-11-07 13:05:43 -05:00
Gerhard Schlager	555f467727	DEV: Add less confusing aliases for base_uri and base_url_no_prefix	2018-11-07 11:33:52 +01:00
Guo Xiang Tan	dfc0519cd3	Remove deprecation notice for old site settings.	2018-11-07 14:36:59 +08:00
Sam	0a442e319c	FIX: correct svg handling for images We regressed and optimized images no longer worked with svg The following adds the correct logic to simply copy file for svgs and bypasses resizing for svg avatars	2018-11-07 15:29:26 +11:00
Bianca Nenciu	2070edf889	FIX: Clarify User.group_locked_trust_level. * Rename User.group_locked_trust_level to User.group_granted_trust_level. * Remove the column from users table.	2018-11-07 10:27:44 +08:00
Sam	06b9d8223a	FIX: search within topic not working correctly in CJK We were splitting the term prior to search causing everything to miss	2018-11-07 09:41:55 +11:00
Robin Ward	71460fc203	PERF: Use mini_sql for the query On sites with many flages, it could take quite a long time for ActiveRecord to return all the joined data. It's now 3 queries instead of one, but significantly faster, especially if you have a minimum threshold set.	2018-11-05 14:44:27 -05:00
Jeff Atwood	afbdf9c2d2	Merge pull request #6558 from pmusaraj/disallow-flagging-deleted-post FIX: disable flagging hidden posts	2018-11-05 11:05:32 -08:00
Penar Musaraj	7b3432f711	Enforce disabling flagging hidden posts server-side	2018-11-05 10:00:59 -05:00
Bianca Nenciu	5fc09a6467	DEV: Fix build.	2018-11-05 14:16:03 +02:00
David Taylor	1acbf8262b	Version bump to v2.2.0.beta4	2018-11-05 11:16:58 +00:00
David Taylor	a84b6b6b0c	SECURITY: Add CSRF protections to OpenID callback	2018-11-05 11:16:57 +00:00
Maja Komel	1ac3e5473a	FIX: don't strip eml attachments from received emails	2018-11-05 09:35:22 +01:00
Bianca Nenciu	ab02b9a5d8	FIX: Use 'require' for dependencies. (#6552 )	2018-11-02 09:16:45 +11:00
Robin Ward	ec91450aae	FEATURE: Track how many user flags are agreed/disagreed/ignored Display the percentage when reviewing flags.	2018-11-01 09:59:50 -04:00
Sam	23423ba112	correct spec and error reporting previous commit misused warn_exception which caused a spec to fail	2018-10-31 13:38:05 +11:00
Sam	31ad7a60ab	FIX: improve error handling for missing maxmind dbs Correct issue where we kept on looking up data on a Logster::Message object	2018-10-31 12:57:18 +11:00
Sam	32b1f34910	PERF: avoid DNS lookups when getting IP info Also cleans up interface in DiscourseIpInfo grew cache to 2000 entries	2018-10-31 12:38:57 +11:00
Bianca Nenciu	e1e392f15b	DEV: Use DiscourseIpInfo for all IP queries. (#6482 ) * DEV: Use DiscourseIpInfo for all IP queries. * UX: Use latitude and longitude for more precision.	2018-10-30 22:08:57 +00:00
Sam	5c86e2d749	tweaks to related message list generation - exclude users in groups I am in from related message search - correctly limit number of related messages	2018-10-29 16:09:58 +11:00
Sam	9933059426	FEATURE: push related PMs to take first 3 slots Previously the related PMs were last meaning you would have to work through all unread to see them. Also amends it so it either asks for related by group OR user not both.	2018-10-29 10:47:59 +11:00
Régis Hanol	d17c8df926	Only check for suspicious login for staff members	2018-10-26 00:29:28 +02:00
Régis Hanol	306d77b54f	FIX: don't use srcset on cropped thumbnails	2018-10-25 16:08:10 +02:00
David Taylor	56e0f47bcd	FIX: Do not update `last_seen` for API access This regressed in `2dc3a50`. I have now added tests for the behavior.	2018-10-25 13:38:57 +01:00
Bianca Nenciu	effbef7d0b	UX: Use user locale for locations. (#6527 ) * UX: Use user locale for locations. * DEV: Added MaxMindDB test data and fixed test.	2018-10-25 10:54:01 +00:00
Bianca Nenciu	6a3767cde7	FEATURE: Warn users via email about suspicious logins. (#6520 ) * FEATURE: Warn users via email about suspicious logins. * DEV: Move suspicious login check to a job.	2018-10-25 09:45:31 +00:00
Régis Hanol	addf6f6d17	FIX: support comma in 'sso_provider_secrets' site setting	2018-10-24 21:23:18 +02:00
Sam	e955a7b49d	Revert "Revert "FIX: GlobalPath#upload_cdn_path when S3 bucket has a folder (#6523 )"" This reverts commit `322b27b6dc`. Oops rushed on the revert here... should be good	2018-10-24 15:14:01 +11:00
Sam	322b27b6dc	Revert "FIX: GlobalPath#upload_cdn_path when S3 bucket has a folder (#6523 )" This reverts commit `63356d883e`. This caused an outage, got to revert	2018-10-24 15:03:58 +11:00
Kyle Zhao	63356d883e	FIX: GlobalPath#upload_cdn_path when S3 bucket has a folder (#6523 )	2018-10-24 14:34:10 +11:00
Daniel Hollas	cee51672c9	FIX: Strip accents from search query `4481836` introduced accent stipping in search_indexer, but we need to strip it from the query itself as well TODO in search with diacritics: - Still need to fix excerpts on search page - need to support accent stripping in in_topic search - need to make sure that in:title works correctly - need to fix "word boldening" in titles	2018-10-23 12:10:33 +11:00
David Taylor	bafe3cd99a	Revert "DEV: Lint official plugins in CI (#6519 )" This reverts commit `093cab2db0`.	2018-10-22 22:30:33 +01:00
David Taylor	093cab2db0	DEV: Lint official plugins in CI (#6519 )	2018-10-22 21:28:38 +01:00
Kyle Zhao	e9a971a2b6	FEATURE: [Experimental] Content Security Policy (#6514 ) do not register new MIME type, parse raw body instead	2018-10-22 13:22:23 -04:00
Bianca Nenciu	99b43f281b	FIX: Fix browser detection for Microsoft Edge. (#6516 ) cool!	2018-10-22 23:15:41 +11:00
Arpit Jalan	597d4863d6	fix the build	2018-10-22 15:09:25 +05:30
Arpit Jalan	ce0a51665e	FIX: count emoji shortcuts in topic title https://meta.discourse.org/t/max-emojis-in-title-set-to-0-conflicting-with-emoji-shortcuts/98368/3?u=techapj	2018-10-22 13:44:05 +05:30
Kyle Zhao	dca830cb73	Revert "FEATURE: [Experimental] Content Security Policy (#6504 )" This reverts commit `fb8231077a`.	2018-10-19 11:53:29 -04:00
Kyle Zhao	fb8231077a	FEATURE: [Experimental] Content Security Policy (#6504 )	2018-10-19 10:39:22 -04:00
Bianca Nenciu	b69652278f	FEATURE: Add Wiki Editor badge. (#6511 )	2018-10-19 15:30:27 +02:00
Gerhard Schlager	341836eb42	Fix the rake task and importer instead	2018-10-17 16:48:09 +02:00
Gerhard Schlager	ee18d9ace0	FIX: mbox importer and rake task were broken	2018-10-17 16:34:18 +02:00
David Taylor	c6f364224e	FEATURE: Allow plugins to whitelist user custom fields for public display (#6499 ) This works exactly the same as `whitelist_staff_user_custom_fields`, but is not limited to staff	2018-10-17 10:33:27 +01:00
Matt Palmer	b1d7582abe	Run specs on discourse-prometheus-alert-receiver Sam wants to watch the world burn.	2018-10-17 15:32:57 +11:00
Matt Palmer	f367eebb10	Override problematic .gemrc setting	2018-10-17 15:31:58 +11:00
Penar Musaraj	b06dccac49	FIX: force enable a user's email_private_messages option when user replies via email (#6478 ) * Enable user email PM when posting to group or replying to topic via email * remove extra line * Add test and fix snake_case * Only reenable email_private_messages for PM replies	2018-10-16 10:51:57 +11:00
Bianca Nenciu	c68a456baa	FIX: Do not award badges for links in restricted categories. (#6492 )	2018-10-16 10:38:59 +11:00
Vinoth Kannan	4c2331260e	run specs on discourse-calendar plugin	2018-10-16 01:26:24 +05:30
Neil Lalonde	d166c38ab7	REFACTOR: distributed_cache is moved to the message_bus gem	2018-10-15 15:01:45 -04:00
Maja Komel	c104256991	FIX: SSO provider secrets - check wildcard domains last, toggle secrets visibility	2018-10-15 16:18:29 +02:00
Arpit Jalan	d76658ff8c	FEATURE: new rake task to anonymize all users	2018-10-15 16:19:25 +05:30
Guo Xiang Tan	8fa59f0548	FIX: Can't clean a tag if the given string is frozen.	2018-10-15 14:48:45 +08:00
Maja Komel	27e732a58d	FEATURE: allow multiple secrets for Discourse SSO provider This splits off the logic between SSO keys used incoming vs outgoing, it allows to far better restrict who is allowed to log in using a site. This allows for better auditing of the SSO provider feature	2018-10-15 16:03:53 +11:00
Bianca Nenciu	d408073fc2	DEV: Update official plugins list canned replies is now named discourse-canned-replies which keeps our naming consistent	2018-10-15 13:53:21 +11:00
Guo Xiang Tan	84d4c81a26	FEATURE: Support backup uploads/downloads directly to/from S3. This reverts commit `3c59106bac`.	2018-10-15 09:43:31 +08:00
Joshua Rosenfeld	fd58ca1903	remove manually mapping of discourse-logster-rate-limit-checker, repo renamed to match	2018-10-12 15:56:23 -04:00
Joshua Rosenfeld	43a7b08a48	don't run specs on prometheus-alert-receiver for now either	2018-10-12 12:20:49 -04:00
Joshua Rosenfeld	ca71815bb2	don't run specs on calendar for now	2018-10-12 12:12:21 -04:00
Neil Lalonde	d19fb61f10	Version bump to v2.2.0.beta3	2018-10-12 10:55:45 -04:00
Joshua Rosenfeld	9d4916012a	manually map discourse-perspective too	2018-10-12 10:32:07 -04:00
Joshua Rosenfeld	2cb176f1ed	manually map discourse-logster-rate-limit-checker also remove obsolete plugins	2018-10-12 10:27:24 -04:00
Joshua Rosenfeld	aba4dec27f	Update official plugin list * Remove duplicate entry * Add missing plugins * Update list for new names	2018-10-12 10:12:31 -04:00
Sam	057087e0e8	FEATURE: log long running jobs in the defer queue If a job in the defer queue takes longer than 90 seconds log an error	2018-10-12 17:03:47 +11:00
Sam	a1c912b630	Return 400 instead of 404 for bad token	2018-10-12 10:51:41 +11:00
Bianca Nenciu	048cdfbcfa	FIX: Do not allow revoking the token of current session. (#6472 ) * FIX: Do not allow revoking the token of current session. * DEV: Add getter of current auth_token from Guardian.	2018-10-12 10:40:48 +11:00
Gerhard Schlager	7a41a783a4	FIX: Don't reply to Unsubscribe email sent to mailing list mirror	2018-10-11 16:09:22 +02:00
Chris Butler	ddbed82bca	Exit with an error if there are errors with settings import (#6475 ) If the site_settings import has any errors or settings that are not found, this will cause the task to exit with a non-zero exit code. This is useful when using this task as part of automated configuration deployment, where you may not want to continue with the process if a setting fails to import.	2018-10-11 15:57:57 +08:00
Guo Xiang Tan	3c59106bac	Revert "FEATURE: Support backup uploads/downloads directly to/from S3." This reverts commit `c29a4dddc1`. We're doing a beta bump soon so un-revert this after that is done.	2018-10-11 11:08:23 +08:00
Guo Xiang Tan	c92bda95e1	Fix the build.	2018-10-11 10:45:01 +08:00
Gerhard Schlager	c29a4dddc1	FEATURE: Support backup uploads/downloads directly to/from S3.	2018-10-11 10:38:43 +08:00
Guo Xiang Tan	5039a6c3f1	FIX: Strip null bytes in mail subjects.	2018-10-11 09:46:32 +08:00
Vinoth Kannan	59be289084	FIX: Do not add lightbox to onebox images (#6479 )	2018-10-11 08:57:21 +11:00
Robin Ward	a566ed42ae	FEATURE: Option to disable user presence and profile This allows users who are privacy conscious to disable the presence features of the forum as well as their public profile.	2018-10-10 17:34:33 -04:00
Bianca Nenciu	4e0533a20b	FIX: Generate Onebox for posts of type moderator_action. (#6466 )	2018-10-10 18:39:03 +08:00
Guo Xiang Tan	918633aa12	FIX: `upload:migrate_to_s3` rake task not remapping properly.	2018-10-10 15:09:21 +08:00
Sam	45f01e637b	FIX: when associating Github account disassociate others There are some cases where an email floats from one GitHub account to another if this happens just take over the Github mapping record	2018-10-10 15:46:50 +11:00
Guo Xiang Tan	f26804394a	DEV: Remove the use of stubs on `Rails.logger` in our test suite.	2018-10-10 09:34:50 +08:00
Sam	9b01e2b855	FIX: maxmind download task does not need environment	2018-10-10 11:16:28 +11:00
Bianca Nenciu	1d26a473e7	FEATURE: Show "Recently used devices" in user preferences (#6335 ) * FEATURE: Added MaxMindDb to resolve IP information. * FEATURE: Added browser detection based on user agent. * FEATURE: Added recently used devices in user preferences. * DEV: Added acceptance test for recently used devices. * UX: Do not show 'Show more' button if there aren't more tokens. * DEV: Fix unit tests. * DEV: Make changes after code review. * Add more detailed unit tests. * Improve logging messages. * Minor coding style fixes. * DEV: Use DropdownSelectBoxComponent and run Prettier. * DEV: Fix unit tests.	2018-10-09 22:21:41 +08:00
Bianca Nenciu	1fb1f4c790	FIX: Make error in Discourse Hub more descriptive. (#6438 )	2018-10-09 22:05:31 +08:00
Erin Kosewic	51aba32651	FEATURE: add branch option to remote theme import * FEATURE: add branch option to remote theme import * FIX: Add missing variable in params * FIX: Add missing param for import_theme method * SPEC: Add test methods for branch support in git import * FIX: Add missing space to scss style * Do not assume default branch as master * Change branch field placeholder * FIX: add missing div start tag	2018-10-09 17:01:08 +11:00
Guo Xiang Tan	1c9b5e75e7	DEV: Support post deployment migrations for plugins.	2018-10-09 13:11:45 +08:00
Kyle Zhao	8b2a379e4e	DEV: transpile certain ES6 files without producing a module (#6460 ) `.js.no-module.es6` files will be transpiled without producing a module. import/export statements are deliberately not supported, so one would still need to use `const module = require('moduleName').default.`	2018-10-09 09:18:23 +08:00
Gerhard Schlager	4881fb028f	FIX: allow_uppercase_posts didn't work for topic titles	2018-10-08 23:50:06 +02:00
Guo Xiang Tan	40fa96777d	FEATURE: Post deployment migrations. (#6406 ) This moves us away from the delayed drops pattern which was problematic on two counts. First, it uses a hardcoded "delay for" duration which may be too short for certain deployment strategies. Second, delayed drop doesn't ensure that it only runs after the latest application code has been deployed. If the migration runs and the application code fails to deploy, running the migration after "delay for" has been met will cause the application to blow up. The new strategy allows post deployment migrations to be skipped if the env `SKIP_POST_DEPLOYMENT_MIGRATIONS` is provided. ``` SKIP_POST_DEPLOYMENT_MIGRATIONS=1 rake db:migrate -> deploy app servers SKIP_POST_DEPLOYMENT_MIGRATIONS=0 rake db:migrate ``` To aid with the generation of a post deployment migration, a generator has been added. Simply run `rails generate post_migration`.	2018-10-08 15:47:38 +08:00
Kyle Zhao	9bbc1ae7b2	FIX: raise if staged user creation failed (#6461 )	2018-10-08 15:45:23 +08:00
Arpit Jalan	c0bb04d89d	FIX: convert tag string to array when filtering topic list by tags	2018-10-08 08:56:25 +05:30
Penar Musaraj	26956bbe1a	FIX: Safari issue with some emojis (#6456 ) https://meta.discourse.org/t/emojis-selected-on-ios-displaying-additional-rectangles/86132/8	2018-10-08 10:32:25 +08:00
Vinoth Kannan	4000dddd32	Merge pull request #6458 from vinothkannans/fix-giphy FIX: Display large/broken image placeholders for image oneboxes	2018-10-07 18:08:54 +05:30
Vinoth Kannan	c499872597	FIX: Display large/broken image placeholders for image oneboxes	2018-10-07 17:42:41 +05:30
David Taylor	9bf522f227	FEATURE: Mixed case tagging (#6454 ) - By default, behaviour is not changed: tags are made lowercase upon creation and edit. - If force_lowercase_tags is disabled, then mixed case tags are allowed. - Tags must remain case-insensitively unique. This is enforced by ActiveRecord and Postgres. - A migration is added to provide a `UNIQUE` index on `lower(name)`. Migration includes a safety to correct any current tags that do not meet the criteria. - A `where_name` scope is added to `models/tag.rb`, to allow easy case-insensitive lookups. This is used instead of `Tag.where(name: "blah")`. - URLs remain lowercase. Mixed case URLs are functional, but have the lowercase equivalent as the canonical.	2018-10-05 10:23:52 +01:00
Vinoth Kannan	8430ea927e	FIX: Generate webhook payloads before destroy events (#6325 )	2018-10-05 16:53:59 +08:00
Sam	5b630f3188	FIX: stop logging every time invalid params are sent Previously we were logging warning for invalid encoded params, this can cause a log flood	2018-10-05 14:33:19 +10:00
Guo Xiang Tan	77c293f82d	Prefer `Process.clock_gettime` over `Time.now`.	2018-10-05 10:25:52 +08:00
Maja Komel	361ad7ed2b	FEATURE: add indication if incoming email attachment was rejected and inform sender about it (#6376 ) * FEATURE: add indication if incoming email attachment was rejected and inform sender about it * include errors for rejected attachments in email * don't send warning email to staged users * use user object instead of user_id in add_attachments method	2018-10-04 22:08:28 +08:00
Rishabh Nambiar	943f017a17	Mark discourse-perspective-api as an official plugin	2018-10-04 14:34:22 +05:30
Lucas Nicodemus	1907338834	FIX: No longer educate users who are editing A user editing a post will no longer get composer messages that are meant for new users posting replies and threads. These messages don't make sense in an edit context at all -- they're usually discussing making salient replies or topics, or adding avatars. They make even less sense when a user is an admin attempting to change the default topics for the first time. Since these messages actually do make sense for a user when they have a low post count, though, they're still going to occur. They just occur when a user is creating new content (and thus, more likely to read the notice), not during edits. This is in response to this issue: https://meta.discourse.org/t/education-message-for-editing-wiki-topic/66682	2018-10-04 13:20:13 +08:00
Jeff Wong	632ca42db9	FIX: edit checks for editing posts with no topic	2018-10-03 18:34:47 -07:00
Penar Musaraj	dc8a16b43b	Use Yarn to manage dependencies, cleanup unused bootstrap libs (#6436 )	2018-10-03 10:15:43 -04:00
Guo Xiang Tan	13dde44c72	FIX: Limit concurrent `assets:precompile` to number of available cores.	2018-10-03 16:46:21 +08:00
Sam	eba3117e08	Missed one spot where url needed cooking	2018-10-03 15:06:37 +10:00
Sam	ad0e768742	FEATURE: add support for responsive images in posts When creating lightboxes we will attempt to create 1.5x and 2x thumbnails for retina screens, this can be controlled with a new hidden site setting called responsice_post_image_sizes, if you wish to create 3x images run SiteSetting.responsive_post_image_sizes = "1\|1.5\|2\|3" The default should be good for most of the setups as it balances filesize with quality. 3x thumbs can get big.	2018-10-03 13:44:53 +10:00
Penar Musaraj	34516c72bd	FIX: Recover public actions (likes) when recovering a post (#6412 )	2018-10-02 11:25:08 -04:00
Guo Xiang Tan	3b1e13e4ab	Remove unecessary code.	2018-10-02 15:24:12 +08:00
Bianca Nenciu	e0d7cdac12	UX: Improve error messages for minimum and maximum username lengths.	2018-10-02 13:10:20 +08:00
Penar Musaraj	da9eee5262	FIX: Force enable user PM emails option when user posts to a group by email.	2018-10-02 12:38:10 +08:00
Gerhard Schlager	e2770bc1c4	FIX: async reload of locales could result in missing translations	2018-10-01 17:14:36 +02:00
Guo Xiang Tan	ac52d8d3c7	Fix `UploadRecovery` from S3 fails with bucket name containing sub-folder.	2018-10-01 19:03:02 +08:00
Guo Xiang Tan	a3dbe3685e	Fix the build.	2018-10-01 16:42:38 +08:00
Guo Xiang Tan	de85bb0a39	FIX: Don't update user_profile URLs unless upload is persisted.	2018-10-01 14:21:39 +08:00
Guo Xiang Tan	e262a08350	Add `UploadRecovery#recover_user_profile_backgrounds`.	2018-10-01 10:51:54 +08:00
Penar Musaraj	70d74f8fc1	FIX: advanced search ordering broken when using tags	2018-09-28 17:27:08 +08:00
Bianca Nenciu	5407036ef9	DEV: Run prettier. (#6420 )	2018-09-21 11:02:23 +00:00
Arpit Jalan	2e02a28ab4	FIX: do not revise post if post revision is not present	2018-09-21 14:08:58 +05:30
Kyle Zhao	4bb980b9f7	FEATURE: do not allow moderators to export user list (#6418 )	2018-09-21 09:07:13 +08:00
Guo Xiang Tan	1a64b3a487	FIX: Don't try to recover an invalid sha1.	2018-09-20 14:21:57 +08:00
Sam	df45e82377	SECURITY: only allow picking of avatars created by self (#6417 ) * SECURITY: only allow picking of avatars created by self Also adds origin tracking to all uploads including de-duplicated uploads	2018-09-19 22:33:10 -07:00
Sam	e0be5145cf	FIX: correct readonly timeout So it only applies in readonly mode	2018-09-20 15:15:46 +10:00
Jeff Wong	d5442fbf08	FIX: do not send tl1 welcome message when a user has the basic user badge	2018-09-19 12:53:36 -07:00
Gerhard Schlager	469a2c36ed	FIX: Always unpause Sidekiq after backup and restore * Logs exceptions during the cleanup phase, but doesn't stop executing subsequent cleanup tasks. * Notifies the user at the end of the cleanup phase, so that the log contains possible errors during that phase.	2018-09-19 20:35:43 +02:00
Guo Xiang Tan	293cf600f0	FIX: Use a tmp file in `UploadRecovery` for local store.	2018-09-19 15:47:15 +08:00
Sam	e0e6dae6a7	minor cleanup to previous commit from code review	2018-09-19 16:07:29 +10:00
Sam	5302709343	FIX: in redis readonly raise an exception from DistributedMutex If we detect redis is in readonly we can not correctly get a mutex raise an exception to notify caller When getting optimized images avoid the distributed mutex unless for some reason it is the first call and we need to generate a thumb In redis readonly no thumbnails will be generated	2018-09-19 15:50:58 +10:00
Guo Xiang Tan	bc7f58191e	FIX: `UploadRecovery` should look at links too.	2018-09-19 11:52:57 +08:00
Guo Xiang Tan	4a92c5b2d6	`UploadRecovery` should recover attachments too.	2018-09-19 10:44:36 +08:00
Guo Xiang Tan	5a9b029014	Improve error messaging in `SocketServer`.	2018-09-19 09:11:10 +08:00
Arpit Jalan	fadcd36f92	FIX: do not treat ignore_redirects domains as blacklisted This fix prevents domains present in `ignore_redirects` to be treated as blacklisted domains and makes sure that onboxing happens for those domains. Issue reported here: https://meta.discourse.org/t/steam-store-oneboxing-no-longer-works/97266	2018-09-18 10:38:02 +05:30
Guo Xiang Tan	ce6a0a5e9e	FIX: Moving upload to tombstone should update modification time. A upload created a long time ago will be nuked from the tombstone immediately if it gets deleted.	2018-09-18 10:48:29 +08:00
Sam	0e9841b995	SECURITY: remove admin memory diagnostics routes	2018-09-18 08:35:09 +10:00
Régis Hanol	4481836de2	FEATURE: new 'search_ignore_accents' site setting	2018-09-17 10:42:30 +02:00
Guo Xiang Tan	b71af05d62	Backward compatibility for dropping functions in `ColumnDropper`. https://meta.discourse.org/t/launcher-rebuild-error-pg-error-schema-discourse-functions-does-not-exist/96209	2018-09-17 14:46:05 +08:00
Rishabh	4f46aa1ba3	FEATURE: Add SiteSetting for s3_configure_tombstone_policy Add SiteSetting for s3_configure_tombstone_policy, skip policy generation if turned off (default on)	2018-09-17 10:57:50 +10:00
OsamaSayegh	c7d81e2682	FIX/FEATURE: don't blow up when can't reach theme's repo, show problem themes on dashboard	2018-09-17 09:49:53 +10:00
Neil Lalonde	526ffc4966	FIX: error in response body to blocked crawlers, showing 500 Internal Server Error with status of 403	2018-09-14 15:40:20 -04:00
Neil Lalonde	b87a089822	FIX: don't block api requests when whitelisted_crawler_user_agents is set	2018-09-14 15:40:20 -04:00
Neil Lalonde	81dc36ba16	Version bump to v2.2.0.beta2	2018-09-14 11:43:35 -04:00
Guo Xiang Tan	f2363650c9	Merge pull request #6395 from discourse/plugin-migrations DEV: apply plugin migrations when testing in Travis and Docker	2018-09-13 06:51:30 -07:00
David Taylor	b8c0e77908	DEV: apply plugin migrations when testing in Travis and Docker In `RAILS_ENV=test`, plugins are not loaded by default. Therefore we need to explicitly specify `LOAD_PLUGINS=1` when we want to apply plugin migrations.	2018-09-13 12:39:54 +01:00
Guo Xiang Tan	529e4018f0	DEV: Avoid using `send` and make the method public instead.	2018-09-13 16:34:32 +08:00
Guo Xiang Tan	0a06b3d977	Accept custom AR relation for `UploadRecovery`.	2018-09-13 16:33:14 +08:00
Guo Xiang Tan	6c65718301	Include response body when raising an error in `FileHelper#download`.	2018-09-13 15:43:58 +08:00
Guo Xiang Tan	5eb65ad612	FIX: Do not try to recover invalid `Upload#short_url` in `UploadRecovery`.	2018-09-13 13:59:17 +08:00
Guo Xiang Tan	d99dd840e4	Add basic test case for `UploadRecovery`.	2018-09-13 13:26:23 +08:00
Guo Xiang Tan	a3b3b0810d	Rescue errors when running dry run for `UploadRecovery`.	2018-09-13 11:57:51 +08:00
Guo Xiang Tan	4dc25ad201	Fix s3 recovery from tombstone in `UploadRecovery`.	2018-09-13 09:19:45 +08:00
David Taylor	9461c99210	DEV: Add travis_fold to termination stage	2018-09-12 18:59:48 +01:00
David Taylor	26bd67a865	DEV: Add travis_fold statements to docker_test	2018-09-12 17:52:58 +01:00
Guo Xiang Tan	24c55bd613	Add dry run option to `UploadRecovery`.	2018-09-12 21:53:01 +08:00
Guo Xiang Tan	2cc48cfd06	Fix incorrect variable.	2018-09-12 02:06:14 -07:00
Guo Xiang Tan	c053f8ccf6	New rake task `uploads:recover`.	2018-09-12 01:52:30 -07:00
Guo Xiang Tan	6d01e0aa04	DEV: Print the error class in `uploads:list_posts_with_broken_images`.	2018-09-12 01:06:51 -07:00
Guo Xiang Tan	71185c13b5	Merge pull request #6377 from tgxworld/remove_tif_tiff Drop `tif`, `tiff`, `webp` and `bmp` from supported images.	2018-09-12 09:32:32 +08:00
Guo Xiang Tan	71caf7521d	Drop `tif`, `tiff`, `webp` and `bmp` from supported images. https://meta.discourse.org/t/cr2-raw-files-are-being-treated-as-tiff-files/96775/3?u=tgxworld	2018-09-12 09:29:54 +08:00
Guo Xiang Tan	e1b16e445e	Rename `FileHelper.is_image?` -> `FileHelper.is_supported_image?`.	2018-09-12 09:22:28 +08:00
Guo Xiang Tan	d59e635a77	Rename `FileHelper.images` to `FileHelper.supported_images`.	2018-09-12 09:22:28 +08:00
Kyle Zhao	f1cb431968	FIX: rescue ActiveRecord::RecordInvalid in find_or_create_by_safe! (#6385 ) AR uniqueness validation could raise ActiveRecord::RecordInvalid	2018-09-12 11:03:12 +10:00
Gerhard Schlager	1a01385e88	FIX: "false" didn't work as locale_default	2018-09-11 13:42:10 +02:00
Neil Lalonde	b3b9ac3b19	Version bump to v2.2.0.beta1	2018-09-10 19:43:15 -04:00
Rishabh	80eace4268	Merge pull request #6383 from discourse/fix_username_suggester FIX: don't raise an error on integer usernames in user_name_suggester	2018-09-11 00:30:29 +05:30
Rishabh Nambiar	81c87df18a	FIX: don't raise an error on integer usernames	2018-09-10 22:17:56 +05:30
Blake Erickson	1d41f3c3fb	Merge pull request #6380 from discourse/rake-destroy-sub-category FIX: Allow `rake destroy:topics` to delete topics in sub-categories	2018-09-10 10:26:04 -06:00
Guo Xiang Tan	94ff428571	Pass the right value to rake task.	2018-09-10 20:07:28 +08:00
David Taylor	84fc7abb73	FIX: Allow `rake destroy:topics` to delete topics in sub-categories	2018-09-10 12:52:14 +01:00
Guo Xiang Tan	4a966c639d	DEV: Update `uploads:list_posts_with_broken_images` to recover from tombstone.	2018-09-10 17:01:41 +08:00
Guo Xiang Tan	df04e69cde	FIX: `S3Helper#list` creates incorrect prefix.	2018-09-10 16:34:40 +08:00
Guo Xiang Tan	68572b8afc	Print error messages on why upload fails to save.	2018-09-10 16:02:13 +08:00
Guo Xiang Tan	0aca80e92a	Fixes to `uploads:list_posts_with_broken_images`.	2018-09-10 15:16:29 +08:00
Guo Xiang Tan	8496537590	Add `RECOVER_FROM_S3` to `uploads:list_posts_with_broken_images` rake task.	2018-09-10 15:14:30 +08:00
Joshua Rosenfeld	afaa722c32	sort official plugin list, remove duplicate entry `discourse-sitemap` was listed twice, sorted list to help avoid duplication	2018-09-09 13:41:26 -04:00
Sam	879067d000	FIX: check admin theme cookie against user selectable previously admin got a free pass and could set theme via cookie to anything including themes that are not selectable this refactor ensures that only "preview" gets a free pass, all the rest goes through the same pipeline	2018-09-07 10:47:28 +10:00
Gerhard Schlager	3dea48f1d9	Resetting miniracer context results in segfault	2018-09-07 00:19:23 +02:00
Gerhard Schlager	f13c34aaed	Adds a check for invalid message formats to rake i18n:check	2018-09-06 17:27:17 +02:00
Gerhard Schlager	3c09026fe4	Minor improvements to rake i18n:check	2018-09-06 16:54:30 +02:00
Guo Xiang Tan	d4b05d7bc5	Always link post to uploads in post process. The operation is cheap anyway so no point skipping.	2018-09-06 14:08:03 +08:00
Guo Xiang Tan	434035f167	FIX: Link post to uploads in `PostCreator`. * This ensures that uploads are linked to their post on creation instead of a background job which may be delayed if Sidekiq is facing difficulties.	2018-09-06 11:18:11 +08:00
Gerhard Schlager	26082688d1	FIX: Zero is a valid value for the page parameter	2018-09-05 20:43:05 +02:00
Guo Xiang Tan	f3aef2cc83	FIX: Incorrect/missing extension in short_url fails to map to upload. `Hash#invert` causes us to lose keys if the hash contains similar values.	2018-09-05 21:48:58 +08:00
Guo Xiang Tan	72834f19ff	DEV: Add rake tasks to list posts with broken images.	2018-09-05 16:54:15 +08:00
Gerhard Schlager	f4956f79a5	Make Rubocop happy	2018-09-05 01:04:43 +02:00
Gerhard Schlager	6658a6601c	Remove unused rake task	2018-09-05 00:47:39 +02:00
Gerhard Schlager	0d8c72d8c4	DEV: Add rake task to check locale files for errors	2018-09-05 00:47:39 +02:00
Gerhard Schlager	b8fc699164	FIX: Detect {{foo}} as interpolation key	2018-09-05 00:47:39 +02:00
Vinoth Kannan	d8b543bb67	FIX: redirect to original URL after social signup	2018-09-05 01:44:23 +05:30
David Taylor	4382fb5fac	DEV: Allow plugins to whitelist specific user custom_fields for editing (#6358 )	2018-09-04 20:45:36 +10:00
Guo Xiang Tan	d1af89e3b3	DEV: Extract global admin api rate limiting into a dedicated method. * We have a use case for overriding the rate limiting logic in a plugin.	2018-09-04 16:37:54 +08:00
Guo Xiang Tan	3b337bfc6b	Revert "FIX: Don't rate limit admin and staff constraints when matching routes." This reverts commit `651b50b1a1`.	2018-09-04 14:27:21 +08:00
Guo Xiang Tan	651b50b1a1	FIX: Don't rate limit admin and staff constraints when matching routes. * When an error is raised when checking route constraints, we can only return true/false which either lets the request through or return a 404 error. Therefore, we just skip rate limiting here and let the controller handle the rate limiting.	2018-09-04 13:52:58 +08:00
Guo Xiang Tan	08b268c5bc	Be more forceful in disconnecting connections during failover.	2018-09-04 10:32:43 +08:00
Guo Xiang Tan	8dc1463ab3	Enable `Lint/ShadowingOuterLocalVariable` for Rubocop.	2018-09-04 10:16:42 +08:00
Gerhard Schlager	eeedc3901e	FIX: Replying to deleted post via email should create new reply to topic	2018-09-03 23:06:40 +02:00
Vinoth Kannan	24a14af15a	FIX: Respect invalidate_oneboxes option for inline oneboxes	2018-09-03 22:33:43 +05:30
Gerhard Schlager	f33433bf9e	Validation of params should restrict to max int (#6331 ) * FIX: Validation of params should restrict to max int * FIX: Send status 400 when "page" param isn't between 1 and max int	2018-09-03 14:45:32 +10:00
Guo Xiang Tan	747c9bb47f	Merge pull request #6317 from nbianca/ignore_blacklisted_domains FIX: Ignore OneBox blacklisted domains.	2018-09-03 11:10:52 +08:00
Guo Xiang Tan	45f092a49d	Extract `badge_posts` view management logic into a service object. * Avoid defininig a global constant and method. Fixes https://github.com/discourse/discourse/pull/6318	2018-09-03 09:51:35 +08:00
Maja Komel	182d9a4666	FIX: escape regex chars when searching site texts	2018-09-02 17:25:57 +10:00
Osama Sayegh	60eff9421a	FIX: precompile `desktop_theme` and `mobile_theme` stylesheets required for environments that pre stage docker images and keep old image running during the deploy	2018-08-31 21:23:55 +10:00
Sam	9b7cab589a	FIX: revert diacritic stripping See more details in test case and at: https://meta.discourse.org/t/discourse-should-ignore-if-a-character-is-accented-when-doing-a-search/90198/16?u=sam	2018-08-31 11:46:55 +10:00
Vinoth Kannan	297e8aaf2e	FIX: Escape regex pattern variable before using it	2018-08-31 03:02:24 +05:30
Neil Lalonde	4b6381367e	add support for Excon connection options in hub requests	2018-08-30 15:57:11 -04:00
Neil Lalonde	415201e1b4	Version bump to v2.1.0.beta6	2018-08-30 10:53:20 -04:00
Joffrey JAFFEUX	2dfb097dd9	DEV: plugin generator support for spec/test/controller/routes (#6344 )	2018-08-30 16:38:25 +02:00
Joffrey JAFFEUX	90e67b671b	DEV: support for settings/locales in plugin generator (#6341 )	2018-08-30 14:12:06 +02:00
Osama Sayegh	9efbf2c49f	FIX: changing component settings should trigger refresh for parent theme CSS (#6340 )	2018-08-30 20:53:03 +10:00
Joffrey JAFFEUX	d40d241e72	DEV: adds --help --no-help options to plugin generator (#6338 ) help will add helpful comments in the various generated files	2018-08-30 12:16:37 +02:00
Joffrey JAFFEUX	acc96abe1a	DEV: plugin generator will now ask for github username (#6337 )	2018-08-30 12:03:30 +02:00
Guo Xiang Tan	492b6dc306	DEV: `yarn exec` doesn't do what I think it does.	2018-08-30 15:55:36 +08:00
Sam	e6970151a6	FEATURE: allow specifying locale via SSO Use: locale locale_force_update To force user locale on users where SiteSetting.allow_user_locale is enabled Note: If an invalid locale is specified no action will occur	2018-08-30 09:58:03 +10:00
Joffrey JAFFEUX	06f18b0e9f	typo	2018-08-29 13:51:16 +02:00
Joffrey JAFFEUX	ef36fdfb64	DEV: rails generator to create plugin skeleton (#6332 ) rails g plugin --help rails g plugin DiscourseRacoon --author joffrey	2018-08-29 13:32:41 +02:00
Dax74	5f51ef27e7	Added sitemap plugin in the official list	2018-08-29 10:58:26 +02:00
Guo Xiang Tan	720726ea68	Use `yarn exec` when running eslint and prettier.	2018-08-29 11:03:42 +08:00
Sam	44cf3cf975	FIX: queue heartbeats in readonly modes If sidekiq is paused or Discourse is in readonly continue to queue heartbeats If we do not do that then a master process can end up reaping sidekiq workers and causing various badness This also impacts restore which can do weird stuff TM in cases like this	2018-08-29 12:36:59 +10:00
Sam	9ab1fb7dfc	FEATURE: correctly store width and height on uploads Previously we used width and height for thumbnails, new code ensures 1. We auto correct width and height 2. We added extra columns for thumbnail_width and height, this is determined by actual upload and no longer passed in as a side effect 3. Optimized Image now stores filesize which can be used for analysis, decisions Also - fixes Android image manifest as a side effect - fixes issue where a thumbnail generated that is smaller than the upload is no longer used	2018-08-28 12:59:22 +10:00
Neil Lalonde	ebe7835316	FIX: links in rss feeds are sometimes wrong on subfolder installs	2018-08-27 18:05:15 -04:00
Bianca Nenciu	b6963b8ffb	FIX: Ignore OneBox blacklisted domains.	2018-08-27 20:40:55 +02:00
Sam	4205c528d0	FEATURE: hide enable_personal_email_messages and min_trust_to_send_email_messages These site settings are very hard to explain and only applicable for very specific Discourse setups. If an admin "enables staged users" which is used in support scenarios then all staff can send "messages" directly to an "email". The setting allows you to extend this to TL4 or any trust level. Actual use case would be a support type setup with restricted staff. It is quite rare so hiding this for now and re-evaluate keeping the setting in 2019	2018-08-27 11:38:22 +10:00
Maja Komel	020eba4623	FIX: find tags with non-latin names (#6312 )	2018-08-27 11:05:28 +10:00
Sam	47e6b8b318	discourse etiquette is an official plugin	2018-08-27 10:03:49 +10:00
Sam	ac11f8df52	correct regression searching with diacritics	2018-08-24 10:00:51 +10:00
Gerhard Schlager	6588a45880	Make Rubocop happy	2018-08-23 15:09:20 +02:00
Gerhard Schlager	409ee66839	Add optional "ignore_case" parameter to posts:remap rake task	2018-08-23 14:49:17 +02:00
Arpit Jalan	7a91df3248	Merge pull request #6290 from techAPJ/latest-full-name UX: show full name on /latest page	2018-08-23 17:34:54 +05:30
Arpit Jalan	1a7cd6648b	UX: show full name on /latest page	2018-08-23 14:41:06 +05:30
Guo Xiang Tan	dd810b8b05	Merge pull request #6304 from tgxworld/create_functions_in_different_schema FIX: Create `BaseDropper` functions in a different schema.	2018-08-23 15:01:41 +08:00
Sam	6ee352510a	Correctly handle exception	2018-08-23 16:27:00 +10:00
Sam	cbd9045c6b	FIX: avoid race condition creating posts in some cases the distributed mutex was not protecting us and transactions would fail	2018-08-23 15:11:06 +10:00
Guo Xiang Tan	212ee15804	FIX: Create `BaseDropper` functions in a different schema. https://meta.discourse.org/t/error-when-restore-db-backup/93145/25?u=tgxworld	2018-08-23 12:52:21 +08:00
Osama Sayegh	2711f173dc	FIX: don't allow inviting more than `max_allowed_message_recipients` * FIX: don't allow inviting more than `max_allowed_message_recipients` setting allows * add specs for guardian * user preferences for auto track shouldn't be applicable to PMs (it auto watches on visit) Execlude PMs from "Automatically track topics I enter..." and "When I post in a topic, set that topic to..." user preferences * groups take only 1 slot in PM * just return if topic is a PM	2018-08-23 14:36:49 +10:00
Guo Xiang Tan	36a7028f19	FEATURE: Clean up `PostReplyKey` records. * Default retention of 90 days.	2018-08-23 10:40:02 +08:00
Régis Hanol	f01169d6ff	FIX: don't send email when the post was deleted	2018-08-22 13:13:58 +02:00
Sam	d3b4f24ced	DEV: correct watcher for controller specs	2018-08-22 14:35:57 +10:00
Sam	272de95175	FIX: client duplicate registration should be cleaned up If for any reason we are unable to correct client id on a user api key invalidate old keys for client/user	2018-08-22 12:56:49 +10:00
Sam	5d96809abd	FIX: improve support for subfolder S3 CDN	2018-08-22 12:31:13 +10:00
Sam	f5142861e5	Revert "Revert "FIX: upload URLs from S3 on subfolder installs"" This reverts commit `26c96e97e5`. We have no choice but to run this code	2018-08-22 11:31:33 +10:00
Sam	26c96e97e5	Revert "FIX: upload URLs from S3 on subfolder installs" This reverts commit `357df2ff4f`.	2018-08-22 10:51:40 +10:00
Robin Ward	410b0f591f	FIX: Flagged Post custom fields were not respecting type	2018-08-21 15:33:15 -04:00
Neil Lalonde	357df2ff4f	FIX: upload URLs from S3 on subfolder installs	2018-08-21 14:58:55 -04:00
Régis Hanol	d1607a387a	FIX: only allow printable characters in uploads filename	2018-08-21 18:11:01 +02:00
Neil Lalonde	e94b5b4d78	Version bump to v2.1.0.beta5	2018-08-21 11:54:23 -04:00
Guo Xiang Tan	0f07494b12	Merge pull request #6259 from pfaffman/patch-2 FIX: disable_2fa fix method selection	2018-08-21 17:29:42 +08:00
Guo Xiang Tan	791ddb8630	PERF: Memoize `EmailReceiver#sent_to_mailinglist_mirror?`.	2018-08-21 15:44:47 +08:00
Guo Xiang Tan	7dcc69aef4	DEV: Refactor test to not call private method.	2018-08-21 14:29:58 +08:00
Sam	57d04200a1	Add Rails 6 note here	2018-08-21 11:09:10 +10:00
Sam	ca5a6f0a9d	FIX: handle concurrently creating post reply keys In some very rare conditions this would be called concurrently and fail	2018-08-21 10:59:18 +10:00
Sam	8fa5dd4a1f	FEATURE: discourse-checklist is now an official plugin	2018-08-21 10:44:40 +10:00
Bianca Nenciu	860c1c3dcd	FEATURE: Automatically expire keys if not used for a configurable amount of time. (#6264 )	2018-08-20 17:36:14 +02:00
Neil Lalonde	ac40fede66	Revert "FIX: subfolder support for S3 CDN"	2018-08-20 10:30:44 -04:00
Neil Lalonde	0b8f6d3637	FIX: subfolder support for S3 CDN	2018-08-20 10:22:03 -04:00
Sam	f5fe58384f	correct regression around file renaming	2018-08-20 16:08:05 +10:00
Sam	d7b1919ead	correct specs	2018-08-20 12:46:14 +10:00
Sam	8b5e42ea16	FIX: always test and coerce to image on upload In the past the filename of the origin was used as the source for the extension of the file when optimizing on upload. We now use the actual calculated extension based on upload data.	2018-08-20 12:18:59 +10:00
Robin Ward	a83f662492	FIX: Allow silenced users to like / bookmark, just not flag.	2018-08-17 11:06:18 -04:00
Guo Xiang Tan	16c0ebe8a8	Fix the build.	2018-08-17 16:53:07 +08:00
Guo Xiang Tan	a26ef7738f	FIX: `FileHelper#download` should return nil if max size is exceeded.	2018-08-17 16:19:59 +08:00
Guo Xiang Tan	be89f593f9	DEV: Include caller in error message for `Discourse#execute_command`.	2018-08-17 16:17:07 +08:00
Guo Xiang Tan	fae8757cd4	FIX: `Guardian#post_can_act?` shouldn't raise an error if user of post has been deleted.	2018-08-17 15:11:30 +08:00
Sam	70155f0923	DEV: decrease log level of compile failures We do not need to report his in logs, our failure mode is fine here.	2018-08-17 17:10:02 +10:00
Guo Xiang Tan	a9e502936f	FIX: Converting PNG to JPEG does not set the correct extension.	2018-08-17 13:09:48 +08:00
Gerhard Schlager	802ad0dc61	Add rake task for updating static pages	2018-08-16 19:51:20 +02:00
Régis Hanol	98898ff4b3	FIX: raise an exception when 'downsize'git st fails	2018-08-16 19:20:07 +02:00
Joffrey JAFFEUX	3fbf7b164d	FEATURE: emoji 11.0 "recently added" update (#6275 ) Adds support for emojis in the http://www.unicode.org/emoji/charts-11.0/emoji-released.html list	2018-08-16 11:59:45 +02:00
Gerhard Schlager	937ab3f213	FIX: Validation of min_posts and max_posts didn't work	2018-08-16 10:36:53 +02:00
Arpit Jalan	8e3b685aa4	make rubocop happy	2018-08-16 14:03:46 +05:30
Arpit Jalan	df55e5bac4	optimize categories:create_definition task	2018-08-16 14:00:07 +05:30
Arpit Jalan	78e14abb32	new rake task to bulk tag all topics in a category	2018-08-16 13:56:57 +05:30
Arpit Jalan	777055f960	new rake task to create category definition	2018-08-16 13:50:52 +05:30
Sam	796164b58c	FIX: automatically correct bad avatars on access Also start relying on upload extension for optimized images	2018-08-16 16:32:56 +10:00
Guo Xiang Tan	33f4aa2835	Fix `migrate_to_s3` rake task, `File#close!` is not a valid method.	2018-08-16 13:26:58 +08:00
Neil Lalonde	ac3b0f0164	REFACTOR: move remap out of script into a class	2018-08-15 12:37:52 -04:00
David Taylor	7b089f7af4	FIX: Don't throw exception if welcome topic cannot be found	2018-08-15 15:50:55 +01:00
Sam	38c10a3dc2	correct the validator	2018-08-15 14:56:24 +10:00
Sam	91e0a77a60	FEATURE: silenced users should not be allowed to edit posts	2018-08-15 14:29:36 +10:00
Sam	06f82a7d72	correct exception handling, always do to_i in array	2018-08-15 11:31:42 +10:00
Sam	bc47148d35	add validation to exclude_category_ids	2018-08-15 09:53:28 +10:00
Régis Hanol	12bab65167	FIX: going from /categories to /latest on mobile might break infinite scrolling	2018-08-15 01:22:03 +02:00
Gerhard Schlager	ba0e322fd0	FIX: Validation of topic params broke discourse-assign	2018-08-14 18:45:46 +02:00
Robin Ward	87fa26b6c8	FIX: Silenced users shouldn't be able to act on posts	2018-08-14 11:43:39 -04:00
Gerhard Schlager	2927294cc6	FIX: Bulk deleting topics should ignore already deleted topics	2018-08-14 16:37:52 +02:00
Régis Hanol	de92913bf4	FIX: store the topic links using the cooked upload url	2018-08-14 12:23:32 +02:00
Sam	ad5f502332	FIX: add a basic validator for topic params This cuts down on log noise when people try out sql injection	2018-08-14 17:01:04 +10:00
Sam	6cae47aa53	collect extra environment correctly	2018-08-13 16:33:28 +10:00
Sam	168ffd8384	FEATURE: group warnings about IP level rate limiting	2018-08-13 14:38:20 +10:00
Guo Xiang Tan	d10c9d7d75	FIX: Missing extensions for non-image uploads due to `2b57239389`.	2018-08-13 10:58:55 +08:00
Jay Pfaffman	71a1d75d7e	FIX: disable_2fa fix method selection The previous code resulted in NameError: undefined local variable or method `totp' for main:Object I now understand what @tgxworld meant about we should only disable totp when I submitted this before. This is the kind of Ruby stuff that I still don't understand well,(perhaps this isn't the most Ruby way to do this?) but this does what I think is supposed to happen. And it worked just now.	2018-08-10 14:45:40 -07:00
Osama Sayegh	865cb3feb9	FIX: allow selecting site's default theme from preference	2018-08-10 14:12:02 +03:00
Sam	ea8394b080	typo in error message	2018-08-10 11:34:01 +10:00
Sam	1fc2597626	better error handling for upload extension fixer	2018-08-10 11:28:22 +10:00
Gerhard Schlager	b9072e8292	FEATURE: Add "Reset Bump Date" action to topic admin wrench (#6246 )	2018-08-10 10:51:03 +10:00
Gerhard Schlager	ef4b9f98c1	FEATURE: Allow admins to reply without topic bump	2018-08-10 10:48:30 +10:00
Neil Lalonde	d77dccc636	FIX: user-deleted posts with deferred flags can be destroyed	2018-08-09 14:54:31 -04:00
Gerhard Schlager	6ddf7fcd1f	Fix warnings about already initialized constants	2018-08-09 17:29:02 +02:00
Robin Ward	5895507153	FEATURE: Ability for plugins to whitelist custom fields for flags You can now call `whitelist_flag_post_custom_field` from your plugins and those custom fields will be available on the flagged posts area of the admin section.	2018-08-09 10:49:14 -04:00
Sam	ed4c0f256e	FIX: check permalinks for deleted topics - allow to specify 410 vs 404 in Discourse::NotFound exception - remove unused `permalink_redirect_or_not_found` which - handle JS side links to topics via Discourse-Xhr-Redirect mechanism	2018-08-09 15:05:12 +10:00
Guo Xiang Tan	1ea23b1eae	FIX: Wrong order for `S3Helper#copy_file`.	2018-08-08 15:58:54 +08:00
Guo Xiang Tan	0879610ffd	Add missing require in `uploads:fix_incorrect_extensions`.	2018-08-08 15:39:37 +08:00
Sam	a35f2984e9	FIX: support Arrays with Marshal dump in distributed cache Theme cache uses arrays here	2018-08-08 16:44:56 +10:00
Guo Xiang Tan	17047806b9	Add a rake task to fix uploads with wrong extension.	2018-08-08 13:15:17 +08:00
Osama Sayegh	0b7ed8ffaf	FEATURE: backend support for user-selectable components * FEATURE: backend support for user-selectable components * fix problems with previewing default theme * rename preview_key => preview_theme_id * omit default theme from child themes dropdown and try a different fix * cache & freeze stylesheets arrays	2018-08-08 14:46:34 +10:00
Guo Xiang Tan	aafff740d2	Add `FileStore::S3Store#copy_file`.	2018-08-08 11:30:34 +08:00
Neil Lalonde	4e6e4a83df	FIX: subfolder digest emails have incorrect URLs	2018-08-07 16:38:17 -04:00
Neil Lalonde	1fcb5c1b6d	Version bump to v2.1.0.beta4	2018-08-07 12:32:57 -04:00
Guo Xiang Tan	2b57239389	FIX: Upload's content is the only source of truth for the file type.	2018-08-07 13:15:00 +08:00
Sam	4b000f5d12	FIX: do not use `lib` for requires this breaks loading the app from arbitrary dirs	2018-08-07 11:04:29 +10:00
Arpit Jalan	ffc8c52bf5	FIX: store welcome topic id in custom field	2018-08-06 23:46:03 +05:30
David Taylor	812add18bd	REFACTOR: Serve auth provider information in the site serializer. At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.	2018-08-06 09:25:48 +01:00
Régis Hanol	0cd9e2acb9	fix build	2018-08-04 01:56:26 +02:00
Joffrey JAFFEUX	066010db7d	FEATURE: introduces list/compact_list components	2018-08-03 16:41:37 -04:00
Régis Hanol	ac2513b0f2	FEATURE: automatic PM when a user's email is revoked	2018-08-03 16:39:22 +02:00
Jeff Atwood	c81bad3232	Merge pull request #6232 from OsamaSayegh/message-email-short-reply UX: better rejection message when reply via email is too short	2018-08-02 14:25:04 -07:00
OsamaSayegh	a157dfd418	UX: better rejection message when reply via email is too short	2018-08-02 22:43:53 +03:00
Régis Hanol	14bbd5d167	FIX: use the right URL when downloading the file from S3	2018-08-02 10:04:41 +02:00
Penar Musaraj	4a872823e7	Improvements to user drafts (#6226 ) * drafts in user profile: only show to user herself (not to admins), use avatar replying to (instead of topic OP), add keyboard shortcut for drafts, simplify display labels * use JSON when testing Draft.stream	2018-08-02 07:41:27 +10:00
Régis Hanol	0f1137dafa	FIX: 'migrate_from_s3' rake task wasn't handling short urls	2018-08-01 22:58:46 +02:00
Jeff Wong	059862ed46	Mark discord auth plugin official	2018-08-01 09:33:14 -07:00
Neil Lalonde	b829452c75	Merge pull request #6209 from discourse/mini_scheduler REFACTOR: extract scheduler to the mini_scheduler gem	2018-08-01 10:28:24 -04:00
Joffrey JAFFEUX	0b9437cee7	FIX: more resilient/consistent dashboard caching (#6223 )	2018-08-01 09:45:50 -04:00
Gerhard Schlager	a115aae45f	Use rchardet instead of charlock_holmes gem	2018-08-01 10:41:20 +02:00
Gerhard Schlager	ff942ed2f3	FIX: Try detecting encoding of RSS feed	2018-08-01 10:41:20 +02:00
Penar Musaraj	1f45215537	FEATURE: Drafts view in user profile * add drafts.json endpoint, user profile tab with drafts stream * improve drafts stream display in user profile * truncate excerpts in drafts list, better handling for resume draft action * improve draft stream SQL query, add rspec tests * if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username) * cleanup * linting fixes * apply prettier styling to modified files * add client tests for drafts, includes a fixture for drafts.json * improvements to code following review * refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix * added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed * prettier, eslint fixes * use "username_lower" from users table, added error handling for rejected promises * adds guardian spec for can_see_drafts, adds improvements following code review * move DraftsController spec to its own file * fix failing drafts qunit test, use getOwner instead of deprecated this.container * limit test fixture for draft.json testing to new_topic request only	2018-08-01 16:34:54 +10:00
Vinoth Kannan	6aee22b88f	FIX: Onebox images are not downloaded locally without css class	2018-08-01 02:51:02 +05:30
Neil Lalonde	4ad7ce70ce	REFACTOR: extract scheduler to the mini_scheduler gem	2018-07-31 17:12:55 -04:00
Arpit Jalan	afe3b00c0f	FIX: use hidden setting for max export file size	2018-07-31 11:25:28 +05:30
Sam	f0c203a5cf	clean up previous commit	2018-07-31 14:50:02 +10:00
Jay Pfaffman	b55d9e63a0	Rake mail test debugging (#6171 ) * FEATURE: rake emails:test add debugging * Oops! Remove safety code * more language tweaks	2018-07-31 14:45:59 +10:00
Neil Lalonde	fd29ecb91a	UX: include a flag reason in the post-deleted-by-staff-because-of-flags message	2018-07-30 16:45:46 -04:00
Régis Hanol	8f1db615db	FIX: don't break restore if function does not exist	2018-07-30 22:11:38 +02:00
Arpit Jalan	17b851cf08	FEATURE: show last updated date for wiki topics	2018-07-30 20:27:49 +05:30
David Taylor	6566b2f11a	FEATURE: Allow revoke and connect for Instagram logins	2018-07-30 14:38:53 +01:00
Arpit Jalan	dfcb2a0d42	FEATURE: include published_time in metadata	2018-07-30 17:09:56 +05:30
David Taylor	8d1acbd4c2	DEV: Include specific authenticator name in warning message	2018-07-30 11:33:48 +01:00
Guo Xiang Tan	b94633e844	FIX: `FileHelper` should prioritize response content-type. Request to a URL with `.png` extension may return a jpg instead causing us to attach the wrong extension to an upload.	2018-07-30 10:54:36 +08:00
David Taylor	5f1fd0019b	FEATURE: Allow revoke and connect for GitHub logins	2018-07-27 17:18:53 +01:00
David Taylor	6296f63804	FEATURE: Revoke and connect for Yahoo logins	2018-07-27 16:20:47 +01:00
David Taylor	9c72c00206	FEATURE: Revoke and reconnect for Twitter logins	2018-07-27 12:28:51 +01:00
Arpit Jalan	c74dd2fa08	FIX: welcome topic should not be a private message	2018-07-27 15:15:13 +05:30
Guo Xiang Tan	6740631fdb	TEMPFIX: Fix broken restores.	2018-07-27 12:48:16 +08:00
Neil Lalonde	135c803f49	FIX: don't send PM if flagged post is deleted but flags were deferred or cleared	2018-07-26 15:12:31 -04:00
Neil Lalonde	a74024b1c9	Version bump to v2.1.0.beta3	2018-07-26 14:16:06 -04:00
David Taylor	467c529920	FIX: Remove return statement from inside block	2018-07-26 15:52:39 +01:00
David Taylor	88241f57a3	FEATURE: allow auth plugins to have a site setting for full screen login	2018-07-26 11:11:16 +01:00
Nick Shearer	def2c977ce	allow auth plugins to have a site setting for if they should be full screen vs popup window	2018-07-25 19:20:11 -05:00
Régis Hanol	f94aeaf6cf	SECURITY: force IM decoder based on file extension - part 3	2018-07-25 23:55:06 +02:00
Régis Hanol	800c57c6ab	SECURITY: force IM decoder based on file extension - part 2	2018-07-25 23:08:02 +02:00
Régis Hanol	4bf3bf6786	SECURITY: force IM decoder based on file extension	2018-07-25 22:00:04 +02:00
David Taylor	0d0d78841b	FIX: Remove `plugin.enabled?` checks at initialization time (#6166 ) Checking `plugin.enabled?` while initializing plugins causes issues in two ways: - An application restart is required for changes to take effect. A load-balanced multi-server environment could behave very weirdly if containers restart at different times. - In a multisite environment, it takes the `enabled?` setting from the default site. Changes on that site affect all other sites in the cluster. Instead, `plugin.enabled?` should be checked at runtime, in the context of a request. This commit removes `plugin.enabled?` from many `instance.rb` methods. I have added a working `plugin.enabled?` implementation for methods that actually affect security/functionality: - `post_custom_fields_whitelist` - `whitelist_staff_user_custom_field` - `add_permitted_post_create_param`	2018-07-25 16:44:09 +01:00
Joffrey JAFFEUX	796639a797	FIX: makes disk_space computation more resilient (#6172 )	2018-07-25 11:04:01 -04:00
David Taylor	fa399ce1c5	FEATURE: Add revoke and reconnect functionality for google logins	2018-07-25 16:03:14 +01:00
Joffrey JAFFEUX	578c8e861b	FIX: refreshes disk_space on backup create/destroy (#6169 )	2018-07-25 08:26:30 -04:00
David Taylor	776fd0de66	FIX: Filter open-id logins by identifier	2018-07-25 11:47:09 +01:00
Gerhard Schlager	84d14fd8a0	FIX: Don't rely on setting data type read from database	2018-07-25 11:40:59 +02:00
Neil Lalonde	417bcf7d2e	add checks for staff and system user before sending flags_agreed_and_post_deleted message	2018-07-24 19:25:11 -04:00
Neil Lalonde	fe39cdc90a	FEATURE: when a post is deleted because a moderator agreed with flags, send a message to the post author	2018-07-24 17:17:56 -04:00
Robin Ward	7058205f70	FIX: Broken specs	2018-07-24 12:00:34 -04:00
Robin Ward	236243f38a	SECURITY: Consider `0.0.0.0` a private IP	2018-07-24 11:16:27 -04:00
Joffrey JAFFEUX	7a3c541077	UX: Preview multiple color schemes in wizard (#6151 ) It was a dropdown to provide choices of color schemes, and only one scheme could be shown. With this commit, multiple color scheme previews can be displayed on one page at the same time, making admins choose color schemes more easily. Theme preview windows are shrinked. Imported default color schemes. Co-Authored-By: Misaka 0x4e21 <misaka4e21@gmail.com>	2018-07-24 09:00:20 -04:00
Guo Xiang Tan	fa19d3a53c	Merge pull request #6108 from discourse/transaction-sidekiq-fix Fix notifications for topics moved between categories	2018-07-24 17:44:03 +08:00
David Taylor	20a21b1240	Move into MiniSQLMultisiteConnection, and add test for rollback	2018-07-24 09:41:55 +01:00
Guo Xiang Tan	fad9c2b971	PERF: Move `EmailLog#reply_key` into new `post_reply_keys` table.	2018-07-24 13:51:53 +08:00
Guo Xiang Tan	ae8b0a517f	PERF: Split skipped email logs into a seperate table.	2018-07-24 13:14:37 +08:00
Gerhard Schlager	e42038eae2	Rake task called method with wrong arguments	2018-07-24 00:10:09 +02:00
David Taylor	eda1462b3b	FEATURE: List, revoke and reconnect associated accounts. Phase 1 (#6099 ) Listing connections is supported for all built-in auth providers. Revoke and reconnect is currently only implemented for Facebook.	2018-07-23 16:51:57 +01:00
Guo Xiang Tan	b165cfdfbe	FIX: Raise a better error in `SiteSettings::TypeSupervisor`.	2018-07-19 16:41:00 +08:00
Arpit Jalan	14a0879658	FIX: allow Twitter videos to go fullscreen	2018-07-19 10:22:36 +05:30
David Taylor	2dc3a50dac	FIX: Do not update `last seen` time for suspended users	2018-07-18 16:04:57 +01:00
Régis Hanol	6d6e026e3c	FEATURE: selectable avatars	2018-07-18 12:57:43 +02:00
Sam	379384ae1e	FIX: never block /srv/status which is used for health checks This route is also very cheap so blocking it is not required It is still rate limited and so on elsewhere	2018-07-18 12:37:01 +10:00
Guo Xiang Tan	3874d40910	Prepare to drop `EmailLog#topic_id`.	2018-07-18 10:22:24 +08:00
Guo Xiang Tan	1d74ccaaf8	Add compatibility for ImageMagick7.	2018-07-17 15:50:58 +08:00
Arpit Jalan	a7ec949e02	make RuboCop happy	2018-07-17 13:15:44 +05:30
Arpit Jalan	7c7509e1bd	FEATURE: update TwitterApi for prettifying like/retweet count	2018-07-17 12:59:40 +05:30
Neil Lalonde	7b3ef4d13f	FIX: use email color settings consistently in notification emails	2018-07-16 12:30:42 -04:00
Rishabh	a6c589d882	FEATURE: Add custom S3 Endpoint and DigitalOcean Spaces/Minio support for Backups (#6045 ) - Add custom S3 Endpoints and DigitalOcean Spaces support - Add Minio support using 'force_path_style' option and fix uploads to custom endpoint	2018-07-16 14:44:55 +10:00
Jay Pfaffman	0ed2834c2d	FEATURE: Add users:disable_2factor rake task https://meta.discourse.org/t/admin-locked-out-of-2fa/92156/2?u=pfaffman	2018-07-16 09:56:55 +08:00
Arpit Jalan	b1082924b9	FIX: do not validate topic deletions	2018-07-13 22:53:36 +05:30
Guo Xiang Tan	711371e8c8	FIX: Select+below will ask server for post ids on megatopics.	2018-07-13 15:10:39 +08:00
Guo Xiang Tan	c722b07057	FIX: `/t/:topic_id/last` route did not return any posts.	2018-07-13 14:26:10 +08:00
Kyle Zhao	2901691e87	FEATURE: per-category approval settings (#5778 ) - disallow moving topics to a category that requires topic approval	2018-07-13 12:51:08 +10:00
David Taylor	81f9500f5c	FIX: Change megatopic threshold to 10,000 posts	2018-07-12 22:00:53 +01:00
Guo Xiang Tan	258e9e35ca	PERF: Make mega topics work without a stream. There are tradeoffs that we took here. For the complete story see https://meta.discourse.org/t/performance-improvements-on-long-topics/30187/27?u=tgxworld.	2018-07-12 12:46:12 +08:00
OsamaSayegh	decf1f27cf	FEATURE: Groundwork for user-selectable theme components * Phase 0 for user-selectable theme components - Drops `key` column from the `themes` table - Drops `theme_key` column from the `user_options` table - Adds `theme_ids` (array of ints default []) column to the `user_options` table and migrates data from `theme_key` to the new column. - Removes the `default_theme_key` site setting and adds `default_theme_id` instead. - Replaces `theme_key` cookie with a new one called `theme_ids` - no longer need Theme.settings_for_client	2018-07-12 14:18:21 +10:00
Arpit Jalan	536cef86f4	PERF: do not carry post ids in memory when rebaking all posts	2018-07-11 14:34:33 +05:30
Maja Komel	0942e2c795	allow adding tags as a custom subject format for emails (#5846 ) allow adding tags as a custom subject format for emails	2018-07-11 12:24:07 +10:00
Neil Lalonde	f69b7deb80	FIX: wizard emoji images on subfolder installs	2018-07-10 11:02:22 -04:00
Guo Xiang Tan	b4e1388f9b	PERF: Drop support for gaps in mega topics. Based on our current implementation, there isn't a practical way to determine the gaps of large topics cheaply. We tried to load the gaps in chunks but felt that the code becomes too complicated. Note that megatopics are quite rare in the wild.	2018-07-10 16:27:02 +08:00
Guo Xiang Tan	21f333654c	REFACTOR: Reduce dependency on the post stream in `TopicView`. This will allow us to drop the post stream from the payload for mega-topics. On smaller topics, the extra query is fast because of an existing index.	2018-07-10 15:53:00 +08:00
Guo Xiang Tan	4163f9e61e	DEV: Better clean up for PostgreSQL failover test.	2018-07-10 09:53:25 +08:00
Guo Xiang Tan	96aca6d7e6	Remove legacy vote post action code. (#6009 )	2018-07-09 16:54:18 +08:00
Guo Xiang Tan	72a3457379	Bump `discourse_image_optim` which uses a global timeout. Our previous solution has the timeout set at the worker level which means the total timeout would be X timeout secs * N number of workers.	2018-07-09 10:30:18 +08:00
Andrew Schleifer	dba22bbde2	rollback changes This reverts: * 1baba84c438e "fix s3 subfolders harder" * ea5e57938edf "fix test for absolute_base_url change"	2018-07-06 17:16:40 -05:00
Andrew Schleifer	52e9f49ec1	fix s3 subfolders harder specifically, include the folder in absolute_base_url	2018-07-06 16:28:40 -05:00
Guo Xiang Tan	59a2767de8	Ensure that we restore the site setting in posts:rebake rake task.	2018-07-06 16:22:54 +08:00
Neil Lalonde	eabc8f7fbd	Merge pull request #6023 from misaka4e21/only-staff-can-create-tag FEATURE: Support disabling tag creation for non-staff users.	2018-07-05 11:12:44 -04:00
Neil Lalonde	92000bc8a0	FEATURE: add a rake task to recalculate user stats post_count and topic_count	2018-07-05 10:38:46 -04:00
Patrick Gansterer	28dd7fb562	FEATURE: Create hidden posts for received spam emails (#6010 ) * Add possibility to add hidden posts with PostCreator * FEATURE: Create hidden posts for received spam emails Spamchecker usually have 3 results: HAM, SPAM and PROBABLY_SPAM SPAM gets usually directly rejected and needs no further handling. HAM is good message and usually gets passed unmodified. PROBABLY_SPAM gets an additional header to allow further processing. This change addes processing capabilities for such headers and marks new posts created as hidden when received via email.	2018-07-05 11:07:46 +02:00
Sam	7b26f5086b	PERF: we have no use for topic percent rank Prepare to remove this column	2018-07-05 15:10:19 +10:00
Régis Hanol	272646c1df	FIX: only show the sequential replies warning for regular posts	2018-07-04 22:51:19 +02:00
Régis Hanol	8a53941fe0	FIX: less aggressive gmail eliding	2018-07-04 20:04:46 +02:00
Régis Hanol	448e2fe1a2	FIX: properly delete files in the download cache	2018-07-04 18:18:39 +02:00
Neil Lalonde	f134701c7b	FIX: user topic and post counts can become negative when staff deletes posts in personal messages	2018-07-04 09:31:16 -04:00
Arpit Jalan	7590128d38	fix typo	2018-07-04 12:01:15 +05:30
Guo Xiang Tan	0af159546a	FIX: `BackupRestore::Backuper#remove_tar_leftovers` not cleaning up files. Wildcard is sanitized when passed to `system()`.	2018-07-04 13:58:39 +08:00
Sam	e72fd7ae4e	FIX: move crawler blocking into anon cache This refinement of previous fix moves the crawler blocking into anonymous cache This ensures we never poison the cache incorrectly when blocking crawlers	2018-07-04 11:14:43 +10:00
Sam	7f98ed69cd	FIX: move crawler blocking to app controller We need access to site settings in multisite, we do not have access yet if we attempt to get them in request tracker middleware	2018-07-04 10:30:50 +10:00
Sam	d1b21aa73b	add timings to asset precompile	2018-07-04 09:42:38 +10:00
Sam	b6e9c734f2	replace error with message So Discourse continues to work on Ruby trunk	2018-07-04 09:42:38 +10:00
Neil Lalonde	e8a6323bea	remove crawler blocking until multisite support	2018-07-03 17:54:45 -04:00
Kasia Bułat	b71cf6d422	FEATURE: Add search not operator for tags.	2018-07-03 15:57:34 +08:00
Joshua Rosenfeld	212f518cd1	Add invite tokens to official plugins list	2018-06-30 17:24:45 -04:00
Guo Xiang Tan	252e5574cc	FIX: Prevent ambigous column errors when joining `TopicView` queries.	2018-06-29 10:33:08 +08:00
Sam	db14e10943	SECURITY: category badges should HTML escape names	2018-06-28 18:15:07 +10:00
Maja Komel	ec3e6a81a4	FEATURE: Second factor backup	2018-06-28 10:12:32 +02:00
Gerhard Schlager	23acddc9fa	Add descriptions for rake tasks	2018-06-27 20:24:46 +02:00
Guo Xiang Tan	eb427f7cf4	PERF: Update `TopicView#participant_count` to use `Topic#posts_count`. Use the counter cache instead of hitting the DB and plucking every single id.	2018-06-27 17:18:47 +08:00
Guo Xiang Tan	cfa7898c2d	Rename `TopicView#last_read_post_id` to `TopicView#filtered_post_id`.	2018-06-27 12:33:57 +08:00
Guo Xiang Tan	cb69888758	PERF: Don't pluck all the columns just to retrieve a single value.	2018-06-27 11:41:35 +08:00
misaka4e21	47cb46671a	FEATURE: Support disabling tag creation for non-staff users.	2018-06-27 07:15:02 +08:00
Arpit Jalan	6bcdc3ba4b	FEATURE: allow author to delete posts irrespective of post_edit_time_limit	2018-06-26 21:43:06 +05:30
Guo Xiang Tan	49ffc1eb61	Revert "PERF: Send down gaps as the relevant posts load instead of front loading." This reverts commit `4c3352528e`.	2018-06-26 12:54:14 +08:00
Guo Xiang Tan	4c3352528e	PERF: Send down gaps as the relevant posts load instead of front loading.	2018-06-26 12:49:06 +08:00
Guo Xiang Tan	0b6a2e9d1f	Remove force summary mode for megatopics for now. The logic is too hairy and we can't reliably determine when to force summary mode. Work is underway to improve perf for megatopics so this will not be required eventually.	2018-06-26 12:49:06 +08:00
Guo Xiang Tan	5100a62fc0	FIX: Megatopics forced into summary mode when loading posts.	2018-06-25 22:11:56 +08:00
David Lee	4644d777bd	FEATURE: add website field to SSO	2018-06-25 16:09:39 +10:00
Jeff Wong	41f76a74f8	FEATURE: send message when a user reaches tl1	2018-06-22 13:20:00 -07:00
Robin Ward	6901e0e043	FIX: Rails.logger isn't always available when loading plugin locales	2018-06-22 10:20:20 -04:00
Guo Xiang Tan	50f14c6e61	Prefer `update!` -> `update!`.	2018-06-22 15:13:04 +08:00
Guo Xiang Tan	f69356e628	FIX: Users can't "show all posts" in forced summary topics.	2018-06-22 11:32:45 +08:00
Neil Lalonde	544254f7a8	Version bump to v2.1.0.beta2	2018-06-21 10:41:52 -04:00
Guo Xiang Tan	97d8cd820e	No need to expire readonly mode key immediately.	2018-06-21 17:52:42 +08:00
Guo Xiang Tan	9a7a079f4d	Force summary mode when user enters at the top of megalodoon topics.	2018-06-21 15:18:52 +08:00
Guo Xiang Tan	f7d22bad90	FEATURE: Forced summary mode for megalodon topics. This is mainly done for performance reasons and megalodon topics are usually a byproduct of imports where site setting limits are not respected.	2018-06-21 14:00:20 +08:00
Guo Xiang Tan	5cef4e281b	PERF: Memoize `TopicView#gaps` results.	2018-06-21 12:37:24 +08:00
Sam	2d59d06916	PERF: mega_topics get no post counts per user	2018-06-21 11:09:45 +10:00
Sam	f66efc601d	FIX: cubot android devices were detected as crawlers	2018-06-21 10:56:46 +10:00
Joffrey JAFFEUX	2f7960bd2a	DEV: updates prettier and displays linters/prettifiers version in CI	2018-06-20 18:34:49 +02:00
Joffrey JAFFEUX	8126b603e4	fix prettier	2018-06-20 18:26:43 +02:00
Joffrey JAFFEUX	c5c1b45d19	higher loglevel for prettier	2018-06-20 16:51:48 +02:00
Guo Xiang Tan	0365806b93	FIX: Properly display error when post action fails to create.	2018-06-20 21:20:23 +08:00
Guo Xiang Tan	ff5fc3cb08	Use a fixed limit for mega topic posts count.	2018-06-20 16:58:52 +08:00
Guo Xiang Tan	9c925a66ff	PERF: Don't display days ago on timeline for megatopics. Analysis using `pg_stat_statements` showed this query to be eating up a significant portion of CPU.	2018-06-20 16:25:54 +08:00
Sam	cbdab71179	PERF: stop counting participants on very large topics This query gets very expensive and can be bypassed on large topics	2018-06-20 18:11:39 +10:00
Sam	2f0e73f2d6	DEV: fast pluck to use type_map in mini_sql	2018-06-20 17:53:49 +10:00
Sam	44091f20c6	DEV: allow for method deprecation using Discourse.deprecate New method deprecator will ensure one log message an hour happens for all deprecated method calls per call site Also removes unused monkey patches to ActiveRecord::Base	2018-06-20 17:53:49 +10:00
Sam	cb824a6b33	DEV: remove all calls to SqlBuilder use DB.build instead This is part of the migration to mini_sql, SqlBuilder.new is being deprecated and replaced with DB.build	2018-06-20 17:53:49 +10:00
Guo Xiang Tan	806f0ca19d	FIX: URL with params for svg images should not be light boxed.	2018-06-20 10:47:14 +08:00
Arpit Jalan	aedc61a3b4	FEATURE: allow large icon to be uploaded in wizard	2018-06-19 21:08:02 +05:30
Joffrey JAFFEUX	24c27b5321	FEATURE: adds a add_report method accessible in plugin.rb	2018-06-19 15:00:11 +02:00
Guo Xiang Tan	7eff64773c	Revert "FIX: Don't clear active connections in defer queue." This reverts commit `c9feadf9ec`.	2018-06-19 17:58:21 +08:00
Guo Xiang Tan	df24c51c6f	Revert "FIX: Don't try to dequeue an empty queue." This reverts commit `1af7d4a894`.	2018-06-19 15:49:45 +08:00
Guo Xiang Tan	41c1e1b302	FIX: `Discourse.keep_readonly_mode` does not work for multisite.	2018-06-19 15:44:08 +08:00
Guo Xiang Tan	1af7d4a894	FIX: Don't try to dequeue an empty queue.	2018-06-19 15:25:44 +08:00
Sam	b8e5989201	correct rake db:create, which needs a defer DB object	2018-06-19 16:43:50 +10:00
Sam	5f64fd0a21	DEV: remove exec_sql and replace with mini_sql Introduce new patterns for direct sql that are safe and fast. MiniSql is not prone to memory bloat that can happen with direct PG usage. It also has an extremely fast materializer and very a convenient API - DB.exec(sql, params) => runs sql returns row count - DB.query(sql, params) => runs sql returns usable objects (not a hash) - DB.query_hash(sql, params) => runs sql returns an array of hashes - DB.query_single(sql, params) => runs sql and returns a flat one dimensional array - DB.build(sql) => returns a sql builder See more at: https://github.com/discourse/mini_sql	2018-06-19 16:13:36 +10:00
Sam	cc3fc87dd7	DEV: handle termination cleanly in autospec	2018-06-19 16:13:36 +10:00
Guo Xiang Tan	c9feadf9ec	FIX: Don't clear active connections in defer queue.	2018-06-19 12:45:16 +08:00
Guo Xiang Tan	34e4c8f573	FIX: `Discourse.keep_readonly_mode` spins a new thread each time it is called.	2018-06-19 10:24:08 +08:00
Guo Xiang Tan	6e97242bb9	Monkey patch in `7830a950ef`	2018-06-19 09:45:48 +08:00
Jeff Wong	68e4e6a575	FIX: staged users are still tl0 but do not trigger spam if 1 week old.	2018-06-18 17:20:04 -07:00
Guo Xiang Tan	630b4570ef	Add specs for `RateLimiter::LimitExceeded#description`.	2018-06-19 07:48:03 +08:00
Neil Lalonde	3725fd8345	Merge pull request #6002 from featheredtoast/trust-previously-staged-users FIX: don't punish a user for being previously staged for spam flags.	2018-06-18 15:14:31 -04:00
Neil Lalonde	320cd9a19e	UX: rate limiter message will say to wait "a few seconds" instead of 0 to 3 seconds	2018-06-18 14:14:47 -04:00
Joffrey JAFFEUX	913d97e780	fix prettier	2018-06-18 20:10:48 +02:00
Joffrey JAFFEUX	6f2c5ea1f2	increases loglevel to debug CI only failure	2018-06-18 19:25:54 +02:00
Blake Erickson	9963078dd1	Add to offical plugins list	2018-06-18 10:20:49 -06:00
Robin Ward	e5c156b226	Add `characters-required` to official plugins list	2018-06-18 10:30:46 -04:00
Guo Xiang Tan	c18b86d9b2	UX: Don't add light box for SVG images.	2018-06-18 17:11:06 +08:00
Jeff Wong	9e55767f6a	FIX: don't punish a user for being previously staged for spam flags.	2018-06-15 12:25:25 -07:00
Joffrey JAFFEUX	03a7d532cf	DEV: introduces prettier for es6 files	2018-06-15 17:03:24 +02:00
Arpit Jalan	c7ee70941e	FEATURE: show category page options on wizard 'homepage' step	2018-06-15 19:11:41 +05:30
OsamaSayegh	2427c0a17c	FIX: theme CSS should recompile when theme uploads change	2018-06-15 13:12:09 +10:00
Guo Xiang Tan	c34100d1e7	Remove unused variable.	2018-06-15 07:45:51 +08:00
Sam Saffron	6123f61f5f	seconds is not needed here	2018-06-14 20:53:24 +10:00
Sam	87fabdc2f3	FIX: correct pool reaper This removes a freedom patch and replaces with a custom reaper thread it also captures an issue where reaper would fail when connections where empty	2018-06-14 18:22:02 +10:00
Sam	71aa20bd30	FIX: pool drainer to use Rails 5.2 implementation old implementation did not reap abandoned connections	2018-06-14 15:54:48 +10:00
Sam	66982c7800	FIX: stop using Rails connection reaper in multisite The Rails 5.2 connection reaper appears to be leaking threads this is a quick fix to stop it, though we need to make sure we never leak connection pools as well.	2018-06-14 12:49:30 +10:00
Robin Ward	fd54c92a52	FEATURE: New site setting, whitelisted_link_domains If provided, users who normally couldn't post links (say, due to a low trust level), can post links to those specific hosts.	2018-06-13 16:11:22 -04:00
Robin Ward	ae728702a6	Revert "Revert "Preload custom user fields when viewing flag queue"" This reverts commit `1bb12ee1b6`.	2018-06-13 11:44:13 -04:00
Guo Xiang Tan	139d0813b4	Re-enable fast_pluck freedom patch.	2018-06-13 09:25:23 +08:00
Joshua Rosenfeld	1bb12ee1b6	Revert "Preload custom user fields when viewing flag queue" This reverts commit `5bd1c5cc95`.	2018-06-12 16:46:31 -04:00
Robin Ward	5bd1c5cc95	Preload custom user fields when viewing flag queue	2018-06-12 16:17:22 -04:00
Robin Ward	e0096b0d1c	Safety in case translations are missing root keys	2018-06-12 10:09:57 -04:00
Guo Xiang Tan	7c173265d5	FIX: Don't clear connections on the same process.	2018-06-12 13:06:25 +08:00
Guo Xiang Tan	646ed87aba	Clear all connections once master recovers.	2018-06-12 12:13:59 +08:00
Guo Xiang Tan	fd75e54793	Disconnect the pool during failover and fallback.	2018-06-12 11:09:19 +08:00
Guo Xiang Tan	a7be68500d	Better error reporting in PostgreSQL fallover thread.	2018-06-12 09:39:11 +08:00
Jeff Atwood	0dee603ffc	Merge pull request #5985 from featheredtoast/pm-participants-two-lines FIX: PM participants listed inline	2018-06-11 18:33:15 -07:00
Guo Xiang Tan	805fd17b23	ActiveRecord in Rails 5.2 discards connection pools after fork.	2018-06-12 09:30:52 +08:00
Jeff Wong	4599cc8435	FIX: PM participants listed inline	2018-06-11 18:14:25 -07:00
Michael Brown	8d92c73aad	Merge pull request #5952 from Supermathie/remap_enhance DbHelper.remap/find: add option to anchor at left/right of the column value	2018-06-11 15:15:17 -04:00
Guo Xiang Tan	bfa0f71e2b	FIX: `Discouse.keep_readonly_mode` incorrect extends expiry.	2018-06-12 00:21:29 +08:00
Guo Xiang Tan	2adae2a0b6	FIX: Be more aggressive in checking master when trying to fallback.	2018-06-12 00:09:15 +08:00
Régis Hanol	4d75535f9e	Revert "Revert "Revert "Add discourse-group-tracker to official plugin list.""" This reverts commit `d1dc8e4226`.	2018-06-11 15:52:20 +02:00
Régis Hanol	d1dc8e4226	Revert "Revert "Add discourse-group-tracker to official plugin list."" This reverts commit `1a00aaa825`.	2018-06-11 14:30:16 +02:00
Guo Xiang Tan	c0b0c66a9e	FIX: PostgreSQL fallback thread doesn't run server starts in readonly.	2018-06-11 15:23:58 +08:00
Guo Xiang Tan	d06af14c26	FIX: Notify all processes to fallback when PostgreSQL recovers.	2018-06-11 15:10:28 +08:00
Guo Xiang Tan	d192924876	FIX: Can't boot Discourse app with read-only PG connection take 2.	2018-06-11 13:25:51 +08:00
OsamaSayegh	93b1386fb2	REFACTOR: admin site settings controller specs to requests (#5966 )	2018-06-11 12:48:09 +08:00
Guo Xiang Tan	5656e8f366	FIX: Can't boot Discourse with a read-only PG connection.	2018-06-11 12:29:23 +08:00
Guo Xiang Tan	b91a3c12a5	Revert "Smoke test should wait up to 5 minutes before it fails" This reverts commit `34d4712133`.	2018-06-11 08:47:57 +08:00
Guo Xiang Tan	e82d45b009	FIX: Ensure we have proper timeout for MiniRacer.	2018-06-11 08:41:04 +08:00
Neil Lalonde	4b2e42757d	fix indent	2018-06-08 13:56:20 -04:00
Neil Lalonde	b8cf0788c6	FIX: broken mailto href's in emails	2018-06-08 13:11:58 -04:00
Joffrey JAFFEUX	d96c775833	enforces prettier	2018-06-08 17:38:29 +02:00
Gerhard Schlager	4ba910ac54	Update username only after successful user anonymization	2018-06-08 15:50:07 +02:00
Joffrey JAFFEUX	22c186a792	disables prettier enforcing for now	2018-06-08 15:44:00 +02:00
Joffrey JAFFEUX	eedf7ffc4f	force install with sudo	2018-06-08 13:25:33 +02:00
Joffrey JAFFEUX	bc7f16a406	forces install of prettier using npm	2018-06-08 13:22:36 +02:00
Joffrey JAFFEUX	3869a9d027	forces global install of prettier	2018-06-08 12:40:05 +02:00
Joffrey JAFFEUX	ddade9c145	better log of yarn setup	2018-06-08 12:12:17 +02:00
Joffrey JAFFEUX	bb920e9bb1	DEV: makes sure yarn is ran before docker:test	2018-06-08 12:04:53 +02:00
Joffrey JAFFEUX	174d392e5a	DEV: adds prettier (#5956 ) Run `prettier --write "app/assets/stylesheets/*/.scss" "plugins/*/.scss"` after making sure you installed it with `yarn` It's recommended to configure your editor to run prettier on file save.	2018-06-08 11:49:31 +02:00
Guo Xiang Tan	29c1f01494	Fix broken pool drainer after the upgrade. See `6cd5cc375a/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb (L467)` We think there is a leak at the moment because a discarded pool belonging to the parent process shouldn't be present in the forked process.	2018-06-08 13:19:07 +08:00
Sam	42847252a4	remove conditional code	2018-06-08 13:38:25 +10:00
Guo Xiang Tan	1a00aaa825	Revert "Add discourse-group-tracker to official plugin list." This reverts commit `e262cb07d4`.	2018-06-08 10:51:16 +08:00
Guo Xiang Tan	e262cb07d4	Add discourse-group-tracker to official plugin list.	2018-06-08 09:55:26 +08:00
Michael Brown	eba50f4591	DbHelper.remap: add options to anchor at left and right of the column value	2018-06-07 13:16:03 -04:00
Michael Brown	beef0d9dd2	fix my lint errors	2018-06-07 11:10:54 -04:00
Michael Brown	7e5f5a0b6b	DbHelper.find: column.table? strike that, reverse it	2018-06-07 10:59:34 -04:00
Michael Brown	8d57c712c3	Add DbHelper.find(needle) * searches the entire database for a text string (such as an old CDN name)	2018-06-07 10:51:16 -04:00
Arpit Jalan	f9ab3848ed	FEATURE: support disabling emails for non-staff users	2018-06-07 18:31:08 +05:30
Sam	1834417e2f	downgrade rails properly	2018-06-07 20:38:22 +10:00
Sam	322b66bcee	attempt to shuffle order of operation for test	2018-06-07 18:16:45 +10:00
Guo Xiang Tan	3533bdb83f	Remove line that is no longer required.	2018-06-07 15:56:16 +08:00
Guo Xiang Tan	1d5c176ea5	DEV: `docker:test` rake task should install plugins first before migrating.	2018-06-07 15:20:06 +08:00
Guo Xiang Tan	ad5082d969	Make rubocop happy again.	2018-06-07 13:28:18 +08:00
Sam	54c0aa788c	FIX: db:create was failing due to site settings	2018-06-07 14:51:14 +10:00
Sam	f331d2603d	DEV: improve design of site setting default provider This refactors it so "Defaults provider" is only responsible for "defaults" Locale handling and management of locale settings is moved back into SiteSettingExtension This eliminates complex state management using DistributedCache and makes it way easier to test SiteSettingExtension	2018-06-07 14:33:41 +10:00
Sam	89ad2b5900	DEV: Rails 5.2 upgrade and global gem upgrade This updates tests to use latest rails 5 practice and updates ALL dependencies that could be updated Performance testing shows that performance has not regressed if anything it is marginally faster now.	2018-06-07 14:21:33 +10:00
Guo Xiang Tan	cb9596e196	Remove invalid `hosted-site` plugin.	2018-06-07 08:49:19 +08:00
Guo Xiang Tan	aa5805e8b0	Revert "Initialize the v8 context after forking." This reverts commit `41c4e32e64`.	2018-06-06 14:33:20 +08:00
Régis Hanol	dc61eaad37	FEATURE: new 'min ratio to crop' site setting	2018-06-05 17:13:00 +02:00
Guo Xiang Tan	32c0ff4831	DEV: Install dependencies before running smoke test.	2018-06-05 18:46:41 +08:00
Guo Xiang Tan	41c4e32e64	Initialize the v8 context after forking.	2018-06-05 11:36:38 +08:00
Arpit Jalan	46fc57222f	FEATURE: improve handling of site setting secrets	2018-06-04 21:31:34 +05:30
Arpit Jalan	313ff264f2	use generic example domain	2018-06-01 14:20:41 +05:30
Blake Erickson	7750b30016	FIX: Allow a user to remove their title Somewhere there was a regression and a user couldn't remove their own title. If they selected '(none)' in the UI it would say it was saved, but it would not actually be updated in the db.	2018-05-31 17:16:52 -06:00

... 9 10 11 12 13 ...

6012 Commits