mirror of
https://github.com/discourse/discourse.git
synced 2024-12-04 19:33:41 +08:00
03b7b7d1bc
This PR enables the [`no-action-modifiers`](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-action-modifiers.md) template lint rule and removes all usages of the `{{action}}` modifier in core. In general, instances of `{{action "x"}}` have been replaced with `{{on "click" (action "x")}}`. In many cases, such as for `a` elements, we also need to prevent default event handling to avoid unwanted side effects. While the `{{action}}` modifier internally calls `event.preventDefault()`, we need to handle these cases more explicitly. For this purpose, this PR also adds the [ember-event-helpers](https://github.com/buschtoens/ember-event-helpers) dependency so we can use the `prevent-default` handler. For instance: ``` <a href {{on "click" (prevent-default (action "x"))}}>Do X</a> ``` Note that `action` has not in general been refactored away as a helper yet. In general, all event handlers should be methods on the corresponding component and referenced directly (e.g. `{{on "click" this.doSomething}}`). However, the `action` helper is used extensively throughout the codebase and often references methods in the `actions` hash on controllers or routes. Thus this refactor will also be extensive and probably deserves a separate PR. Note: This work was done to complement #17767 by minimizing the potential impact of the `action` modifier override, which uses private API and arguably should be replaced with an AST transform. This is a followup to #18333, which had to be reverted because it did not account for the default treatment of modifier keys by the {{action}} modifier. Commits: * Enable `no-action-modifiers` template lint rule * Replace {{action "x"}} with {{on "click" (action "x")}} * Remove unnecessary action helper usage * Remove ctl+click tests for user-menu These tests now break in Chrome when used with addEventListener. As per the comment, they can probably be safely removed. * Prevent default event handlers to avoid unwanted side effects Uses `event.preventDefault()` in event handlers to prevent default event handling. This had been done automatically by the `action` modifier, but is not always desirable or necessary. * Restore UserCardContents#showUser action to avoid regression By keeping the `showUser` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showUser` argument that's been passed. * Revert EditCategoryTab#selectTab -> EditCategoryTab#select Avoid potential breaking change in themes / plugins * Restore GroupCardContents#showGroup action to avoid regression By keeping the `showGroup` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showGroup` argument that's been passed. * Restore SecondFactorAddTotp#showSecondFactorKey action to avoid regression By keeping the `showSecondFactorKey` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showSecondFactorKey` property that's maintained on the controller. * Refactor away from `actions` hash in ChooseMessage component * Modernize EmojiPicker#onCategorySelection usage * Modernize SearchResultEntry#logClick usage * Modernize Discovery::Categories#showInserted usage * Modernize Preferences::Account#resendConfirmationEmail usage * Modernize MultiSelect::SelectedCategory#onSelectedNameClick usage * Favor fn over action in SelectedChoice component * Modernize WizardStep event handlers * Favor fn over action usage in buttons * Restore Login#forgotPassword action to avoid possible regression * Introduce modKeysPressed utility Returns an array of modifier keys that are pressed during a given `MouseEvent` or `KeyboardEvent`. * Don't interfere with click events on links with `href` values when modifier keys are pressed |
||
|---|---|---|
| .. | ||
| report-filters | ||
| site-settings | ||
| ace-editor.hbs | ||
| admin-backups-logs.hbs | ||
| admin-editable-field.hbs | ||
| admin-form-row.hbs | ||
| admin-nav.hbs | ||
| admin-penalty-history.hbs | ||
| admin-report-chart.hbs | ||
| admin-report-counters.hbs | ||
| admin-report-counts.hbs | ||
| admin-report-inline-table.hbs | ||
| admin-report-per-day-counts.hbs | ||
| admin-report-stacked-chart.hbs | ||
| admin-report-storage-stats.hbs | ||
| admin-report-table-cell.hbs | ||
| admin-report-table-header.hbs | ||
| admin-report-table-row.hbs | ||
| admin-report-table.hbs | ||
| admin-report-trust-level-counts.hbs | ||
| admin-report.hbs | ||
| admin-theme-editor.hbs | ||
| admin-user-field-item.hbs | ||
| admin-watched-word.hbs | ||
| admin-web-hook-event-chooser.hbs | ||
| admin-web-hook-event.hbs | ||
| admin-web-hook-status.hbs | ||
| composer-fullscreen-prompt.hbs | ||
| dashboard-new-feature-item.hbs | ||
| dashboard-new-features.hbs | ||
| dashboard-problems.hbs | ||
| email-styles-editor.hbs | ||
| embeddable-host.hbs | ||
| embedding-setting.hbs | ||
| emoji-value-list.hbs | ||
| flag-user-lists.hbs | ||
| flag-user.hbs | ||
| highlighted-code.hbs | ||
| inline-edit-checkbox.hbs | ||
| install-theme-item.hbs | ||
| ip-lookup.hbs | ||
| penalty-post-action.hbs | ||
| permalink-form.hbs | ||
| resumable-upload.hbs | ||
| screened-ip-address-form.hbs | ||
| secret-value-list.hbs | ||
| setting-validation-message.hbs | ||
| silence-details.hbs | ||
| simple-list.hbs | ||
| site-customization-change-details.hbs | ||
| site-customization-change-field.hbs | ||
| site-setting.hbs | ||
| site-text-summary.hbs | ||
| staff-actions.hbs | ||
| suspension-details.hbs | ||
| tags-uploader.hbs | ||
| themes-list-item.hbs | ||
| themes-list.hbs | ||
| value-list.hbs | ||
| version-checks.hbs | ||
| watched-word-form.hbs | ||
| watched-word-uploader.hbs | ||