mirror of
https://github.com/discourse/discourse.git
synced 2024-12-05 05:03:43 +08:00
03b7b7d1bc
This PR enables the [`no-action-modifiers`](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-action-modifiers.md) template lint rule and removes all usages of the `{{action}}` modifier in core. In general, instances of `{{action "x"}}` have been replaced with `{{on "click" (action "x")}}`. In many cases, such as for `a` elements, we also need to prevent default event handling to avoid unwanted side effects. While the `{{action}}` modifier internally calls `event.preventDefault()`, we need to handle these cases more explicitly. For this purpose, this PR also adds the [ember-event-helpers](https://github.com/buschtoens/ember-event-helpers) dependency so we can use the `prevent-default` handler. For instance: ``` <a href {{on "click" (prevent-default (action "x"))}}>Do X</a> ``` Note that `action` has not in general been refactored away as a helper yet. In general, all event handlers should be methods on the corresponding component and referenced directly (e.g. `{{on "click" this.doSomething}}`). However, the `action` helper is used extensively throughout the codebase and often references methods in the `actions` hash on controllers or routes. Thus this refactor will also be extensive and probably deserves a separate PR. Note: This work was done to complement #17767 by minimizing the potential impact of the `action` modifier override, which uses private API and arguably should be replaced with an AST transform. This is a followup to #18333, which had to be reverted because it did not account for the default treatment of modifier keys by the {{action}} modifier. Commits: * Enable `no-action-modifiers` template lint rule * Replace {{action "x"}} with {{on "click" (action "x")}} * Remove unnecessary action helper usage * Remove ctl+click tests for user-menu These tests now break in Chrome when used with addEventListener. As per the comment, they can probably be safely removed. * Prevent default event handlers to avoid unwanted side effects Uses `event.preventDefault()` in event handlers to prevent default event handling. This had been done automatically by the `action` modifier, but is not always desirable or necessary. * Restore UserCardContents#showUser action to avoid regression By keeping the `showUser` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showUser` argument that's been passed. * Revert EditCategoryTab#selectTab -> EditCategoryTab#select Avoid potential breaking change in themes / plugins * Restore GroupCardContents#showGroup action to avoid regression By keeping the `showGroup` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showGroup` argument that's been passed. * Restore SecondFactorAddTotp#showSecondFactorKey action to avoid regression By keeping the `showSecondFactorKey` action, we can avoid a breaking change for plugins that rely upon it, while not interfering with the `showSecondFactorKey` property that's maintained on the controller. * Refactor away from `actions` hash in ChooseMessage component * Modernize EmojiPicker#onCategorySelection usage * Modernize SearchResultEntry#logClick usage * Modernize Discovery::Categories#showInserted usage * Modernize Preferences::Account#resendConfirmationEmail usage * Modernize MultiSelect::SelectedCategory#onSelectedNameClick usage * Favor fn over action in SelectedChoice component * Modernize WizardStep event handlers * Favor fn over action usage in buttons * Restore Login#forgotPassword action to avoid possible regression * Introduce modKeysPressed utility Returns an array of modifier keys that are pressed during a given `MouseEvent` or `KeyboardEvent`. * Don't interfere with click events on links with `href` values when modifier keys are pressed
85 lines
3.2 KiB
Handlebars
85 lines
3.2 KiB
Handlebars
{{#if this.ip}}
|
|
<DButton @class="btn-default" @action={{action "lookup"}} @icon="globe" @label="admin.user.ip_lookup" />
|
|
{{/if}}
|
|
{{#if this.show}}
|
|
<div class="location-box">
|
|
<a href class="close pull-right" {{on "click" this.hide}}>{{d-icon "times"}}</a>
|
|
{{#if this.copied}}
|
|
<DButton @class="btn-hover pull-right" @icon="copy" @label="ip_lookup.copied" />
|
|
{{else}}
|
|
<DButton @action={{action "copy"}} @class="pull-right no-text" @icon="copy" />
|
|
{{/if}}
|
|
<h4>{{i18n "ip_lookup.title"}}</h4>
|
|
<p class="powered-by">{{html-safe (i18n "ip_lookup.powered_by")}}</p>
|
|
<dl>
|
|
{{#if this.location}}
|
|
{{#if this.location.hostname}}
|
|
<dt>{{i18n "ip_lookup.hostname"}}</dt>
|
|
<dd>{{this.location.hostname}}</dd>
|
|
{{/if}}
|
|
|
|
<dt>{{i18n "ip_lookup.location"}}</dt>
|
|
<dd>
|
|
{{#if this.location.location}}
|
|
<a href="https://maps.google.com/maps?q={{this.location.latitude}},{{this.location.longitude}}" rel="noopener noreferrer" target="_blank">
|
|
{{this.location.location}}
|
|
</a>
|
|
{{else}}
|
|
{{i18n "ip_lookup.location_not_found"}}
|
|
{{/if}}
|
|
</dd>
|
|
|
|
{{#if this.location.organization}}
|
|
<dt>{{i18n "ip_lookup.organisation"}}</dt>
|
|
<dd>{{this.location.organization}}</dd>
|
|
{{/if}}
|
|
{{else}}
|
|
{{loading-spinner size="small"}}
|
|
{{/if}}
|
|
|
|
<dt>
|
|
{{i18n "ip_lookup.other_accounts"}}
|
|
<strong>{{this.totalOthersWithSameIP}}</strong>
|
|
{{#if this.other_accounts.length}}
|
|
<DButton @class="btn-danger pull-right" @action={{action "deleteOtherAccounts"}} @icon="exclamation-triangle" @translatedLabel={{i18n "ip_lookup.delete_other_accounts" count=this.otherAccountsToDelete}} />
|
|
{{/if}}
|
|
</dt>
|
|
|
|
<ConditionalLoadingSpinner @size="small" @condition={{this.otherAccountsLoading}}>
|
|
{{#if this.other_accounts.length}}
|
|
<dd class="other-accounts">
|
|
<table class="table table-condensed table-hover">
|
|
<thead>
|
|
<tr>
|
|
<th>{{i18n "ip_lookup.username"}}</th>
|
|
<th>{{i18n "ip_lookup.trust_level"}}</th>
|
|
<th>{{i18n "ip_lookup.read_time"}}</th>
|
|
<th>{{i18n "ip_lookup.topics_entered"}}</th>
|
|
<th>{{i18n "ip_lookup.post_count"}}</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
{{#each this.other_accounts as |a|}}
|
|
<tr>
|
|
<td>
|
|
<LinkTo @route="adminUser" @model={{a}}>
|
|
{{avatar a usernamePath="user.username" imageSize="small"}}
|
|
|
|
<span>{{a.username}}</span>
|
|
</LinkTo>
|
|
</td>
|
|
<td>{{a.trustLevel.id}}</td>
|
|
<td>{{a.time_read}}</td>
|
|
<td>{{a.topics_entered}}</td>
|
|
<td>{{a.post_count}}</td>
|
|
</tr>
|
|
{{/each}}
|
|
</tbody>
|
|
</table>
|
|
</dd>
|
|
{{/if}}
|
|
</ConditionalLoadingSpinner>
|
|
</dl>
|
|
</div>
|
|
{{/if}}
|