mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 06:29:30 +08:00
ba1b95c9f4
When we introduced `existingUploads` as an arg to the ChatComposerUploads component, we also introduced a bug where if multiple uploads were being done at once, and the draft was saved, then because of didReceiveAttrs we would cancel the currently uploading files because the draft uploads became the existingUploads. To work around this, since we do want to keep this on didReceiveAttrs for cases when the user opens a draft or edits another message, the easiest thing to do is to just not save uploads into the chat draft if there are still uploads in progress. That way only when all uploads are complete do we make them a part of the draft. There is a small risk that the user could do something to lose their uploads in the draft, but it's a better gamble to have that happen rather than in progress uploads to be cancelled while the user is waiting for them to be done because of the draft. Also changes the uploads system spec back to the old way of attaching multiple files since that is why it was failing. |
||
|---|---|---|
| .. | ||
| chat | ||
| discourse-details | ||
| discourse-local-dates | ||
| discourse-narrative-bot | ||
| discourse-presence | ||
| lazy-yt | ||
| poll | ||
| styleguide | ||